From patchwork Mon Dec 10 22:03:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 26 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 09DE660B0F for ; Mon, 10 Dec 2018 23:03:05 +0100 (CET) Received: from avalon.bb.dnainternet.fi (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7711054B for ; Mon, 10 Dec 2018 23:03:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1544479384; bh=70Vs4LuSYsFnlFYiH+fsCqXCclYD1kc4DLHxFQEHIIY=; h=From:To:Subject:Date:From; b=GM+UcXVlVwoOIwLo20WEhkzTOVF9g5q735pFXO3Pm9oRjRIUnVmG6mMDdrbVJvhXt l93iPj/aPjZT5vGxcin/qeGPRhuHawjkl0d6X3vK4vG2Cyp6i0l5/HNh6VWHFIcthZ Vngs0Ma2jabYW7R3h/08AZbrRhjd6vnHX3l/IjEk= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Tue, 11 Dec 2018 00:03:30 +0200 Message-Id: <20181210220330.20774-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: log: Fix miscellaneous coding style issues X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2018 22:03:05 -0000 Those issues were pointed out during review. Signed-off-by: Laurent Pinchart Acked-by: Jacopo Mondi --- src/libcamera/include/log.h | 2 +- src/libcamera/log.cpp | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/libcamera/include/log.h b/src/libcamera/include/log.h index 76acd1520868..41f8a756bf0c 100644 --- a/src/libcamera/include/log.h +++ b/src/libcamera/include/log.h @@ -33,6 +33,6 @@ private: #define LOG(severity) LogMessage(__FILE__, __LINE__, Log##severity).stream() -}; +} /* namespace libcamera */ #endif /* __LIBCAMERA_LOG_H__ */ diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp index 18ccfa32d8b4..2a3824972c9a 100644 --- a/src/libcamera/log.cpp +++ b/src/libcamera/log.cpp @@ -2,7 +2,7 @@ /* * Copyright (C) 2018, Google Inc. * - * log.h - Logging infrastructure + * log.cpp - Logging infrastructure */ #include @@ -14,7 +14,7 @@ #include "utils.h" /** - * \file log.h + * \file log.cpp * \brief Logging infrastructure */ @@ -48,7 +48,7 @@ static const char *log_severity_name(LogSeverity severity) " ERR", }; - if ((unsigned int)severity < ARRAY_SIZE(names)) + if (static_cast(severity) < ARRAY_SIZE(names)) return names[severity]; else return "UNKN"; @@ -78,4 +78,4 @@ LogMessage::~LogMessage() fflush(stderr); } -}; +} /* namespace libcamera */