Patch Detail
Show a patch.
GET /api/patches/23617/?format=api
{ "id": 23617, "url": "https://patchwork.libcamera.org/api/patches/23617/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23617/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250620-vd56g3_support-v1-3-df434bdbc9bd@foss.st.com>", "date": "2025-06-20T13:49:18", "name": "[3/3] libcamera: libipa: Add vd56g3 support for libipa", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d34775a73948b34526449ce589de41411e26fc92", "submitter": { "id": 227, "url": "https://patchwork.libcamera.org/api/people/227/?format=api", "name": "Benjamin Mugnier", "email": "benjamin.mugnier@foss.st.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23617/mbox/", "series": [ { "id": 5236, "url": "https://patchwork.libcamera.org/api/series/5236/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5236", "date": "2025-06-20T13:49:18", "name": "Add vd56g3 support for rpi and libipa", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5236/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23617/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23617/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5A17ABDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 20 Jun 2025 13:50:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3CD5168DE9;\n\tFri, 20 Jun 2025 15:50:54 +0200 (CEST)", "from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com\n\t[91.207.212.93])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 11F6561535\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 20 Jun 2025 15:50:52 +0200 (CEST)", "from pps.filterd (m0046660.ppops.net [127.0.0.1])\n\tby mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id\n\t55KD7kLu010377; Fri, 20 Jun 2025 15:50:50 +0200", "from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35])\n\tby mx07-00178001.pphosted.com (PPS) with ESMTPS id 478x7aeqb3-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NOT); Fri, 20 Jun 2025 15:50:50 +0200 (MEST)", "from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20])\n\tby beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 5DABC40048; \n\tFri, 20 Jun 2025 15:50:18 +0200 (CEST)", "from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69])\n\tby euls16034.sgp.st.com (STMicroelectronics) with ESMTP id\n\tB4A2AAC0B49; Fri, 20 Jun 2025 15:49:38 +0200 (CEST)", "from localhost (10.130.73.167) by SHFDAG1NODE1.st.com\n\t(10.75.129.69) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39;\n\tFri, 20 Jun 2025 15:49:38 +0200" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=foss.st.com header.i=@foss.st.com\n\theader.b=\"1dod2iSX\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=selector1; bh=\n\tt8sZQI9gVi9ZTibK+ekvJG7/6sqbNWZhrMB3rLbw51s=; b=1dod2iSXO0LdLdVb\n\tJWleyoF03YRJB0LQXj8JBTizVCULC7v5XT9/OcRl0nhfaQJm1NZD8tiHOkUcFp3i\n\twnenHBiWq2FB//P4VfZfFppDQ5TA8SRHE4W/5nOzAs/Kvq70V8NRR5Rgymgw4lKJ\n\t69Ws1NXCSXTNfmrr46eaf0cVgaoyTNIsHl9ACvdyPmV0b6r5zwWw9nOx+J4707Gw\n\tD1v9NgptWkJb7a+ghR87xmQo6G8kAdGYyZ31FCX8KzQoVouailm2TTBavkY8ZegI\n\tpjf3rj8556MWeXQlfXAosX+e3WkeKNPH9H+WQnp2r7PyCD+cM93svhzBWqPxlFj2\n\trIDJ2Q==", "From": "Benjamin Mugnier <benjamin.mugnier@foss.st.com>", "Date": "Fri, 20 Jun 2025 15:49:18 +0200", "Subject": "[PATCH 3/3] libcamera: libipa: Add vd56g3 support for libipa", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-ID": "<20250620-vd56g3_support-v1-3-df434bdbc9bd@foss.st.com>", "References": "<20250620-vd56g3_support-v1-0-df434bdbc9bd@foss.st.com>", "In-Reply-To": "<20250620-vd56g3_support-v1-0-df434bdbc9bd@foss.st.com>", "To": "<libcamera-devel@lists.libcamera.org>", "CC": "Naushir Patuck <naush@raspberrypi.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, Sylvain Petinot\n\t<sylvain.petinot@foss.st.com>, Cyril Liotard <cyril.liotard@st.com>,\n\t\"Jean Poire\" <jean.poire@st.com>,\n\tBenjamin Mugnier <benjamin.mugnier@foss.st.com>", "X-Mailer": "b4 0.14.2", "X-Originating-IP": "[10.130.73.167]", "X-ClientProxiedBy": "SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE1.st.com\n\t(10.75.129.69)", "X-Proofpoint-Virus-Version": "vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1099, Hydra:6.0.736,\n\tFMLib:17.12.80.40\n\tdefinitions=2025-06-20_05,2025-06-20_01,2025-03-28_01", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Adapted from rpi cam_helper and tuning files. Values are sourced\ninitially from the vd56g3 user manual.\n\nSigned-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 12 ++++++++++++\n 1 file changed, 12 insertions(+)", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex 7c66cd57d6857e43863375d0b32d688fb5a1063c..dcd69d9f2bbb39feabfefe41cee8b45f0f958127 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -745,6 +745,18 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"ov13858\", CameraSensorHelperOv13858)\n \n+class CameraSensorHelperVd56g3 : public CameraSensorHelper\n+{\n+public:\n+\tCameraSensorHelperVd56g3()\n+\t{\n+\t\t/* From datasheet: 0x40 at 10bits. */\n+\t\tblackLevel_ = 4096;\n+\t\tgain_ = AnalogueGainLinear{ 0, 32, -1, 32 };\n+\t}\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"vd56g3\", CameraSensorHelperVd56g3)\n+\n #endif /* __DOXYGEN__ */\n \n } /* namespace ipa */\n", "prefixes": [ "3/3" ] }