Patch Detail
Show a patch.
GET /api/patches/22215/?format=api
{ "id": 22215, "url": "https://patchwork.libcamera.org/api/patches/22215/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22215/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241206142742.7931-5-david.plowman@raspberrypi.com>", "date": "2024-12-06T14:27:41", "name": "[4/5] pipeline: rpi: common: Add wallclock timestamp support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "87c42ea74ba7efca86c22914bf6d48b974310b19", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22215/mbox/", "series": [ { "id": 4856, "url": "https://patchwork.libcamera.org/api/series/4856/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4856", "date": "2024-12-06T14:27:37", "name": "Implement wallclock timestamps for frames", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4856/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22215/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22215/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ECD5CBE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 6 Dec 2024 14:27:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 848F766176;\n\tFri, 6 Dec 2024 15:27:53 +0100 (CET)", "from mail-wm1-x336.google.com (mail-wm1-x336.google.com\n\t[IPv6:2a00:1450:4864:20::336])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 71FC866166\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Dec 2024 15:27:48 +0100 (CET)", "by mail-wm1-x336.google.com with SMTP id\n\t5b1f17b1804b1-434e3953b65so892865e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 06 Dec 2024 06:27:48 -0800 (PST)", "from localhost.localdomain ([88.202.252.90])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-386220b071dsm4608219f8f.101.2024.12.06.06.27.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 06 Dec 2024 06:27:47 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"RRatNyea\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1733495268; x=1734100068;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=1BggXtC9eS3Pe4g0NtueKve30BwBdwUvqTaJYJVa6/M=;\n\tb=RRatNyea6Em4dta/RFj+dngdEc1LRNia//ut4tB6Gj8BaSFXdag3y/aj291mGt4YLK\n\t1m946IpMnLnm+RFuBqIati12kYGBatJKq1fXkaXqFRSXozH3417YrVv7TTucKMdg2/4F\n\t0jC9uYAIIxV2p7jSOlwcyorMhrd2AmbyEwvBvhzOsjSQB27HoSAukRq6baak1vy1OuL9\n\t/LBGnTLqm6qqzOfd0nttSih8fHxRI9NLXDLK5oSOAbJ8bV4XgjJpkAGhly6Si0IYLxv6\n\tR4ioFF6X3hCzDIodLSppfiw6pnMOfuw8QPTV6v4j2zZHJHc4ZUxeaClvSYbzraMXyDpR\n\tRlfw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1733495268; x=1734100068;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=1BggXtC9eS3Pe4g0NtueKve30BwBdwUvqTaJYJVa6/M=;\n\tb=QlnPgSwxo00qfZRfhlEgVY41mt/BlzvtKrEygCWR3fAUU7V6YKCCrnHZWqpuQu6Sw9\n\tce+ZQm8i2jv0gDEOG7gcuEcjl1iRRMtnnp8w17bDAvha66cpvijoLhRbKB1Q1ihSaTRp\n\tu9+EpDingTzApIhMduxuEpfHLeF4Rsqdvql0gFU03I3TWvolin2q3DRWu5T7jNm8mkDA\n\tGMMe+LSYN0p/HFTJIhWg+5x/g37W8q1C9GnlGmpW3WcuMhwb2Qb+dizGpkkarLIBmw5U\n\tu2uQ1I92wD+uvd6JJRgOrPVWOPEQG4KO7YQt1/MMPuMRa6ueFBp0f9cAKGa9+kwMX5ii\n\tlriw==", "X-Gm-Message-State": "AOJu0YwWJUC2qMJIQ4aH9Yvz9w2/yw28d9Z4g1Wx9dNW+sRIM4FG6coZ\n\tlaIdwSsuGVZtesCYmFGVnzS6HwMPeQWSUSdlQQ7pVvugPJuUr/dDDC6bID2bWDx0rClmNwIeEd2\n\tm", "X-Gm-Gg": "ASbGnctQMctdyxFz21QhzGdVXQHZ0uxu+FLBKgN6hAG0cCVG+f5b0Jt3t0yhDEuk4pv\n\tM/52fYGC96oF7MBgSWAokUU/wx2y1xSlKCsDm3W1nq+kJ54h4ow34CqqiBd5YGCi2ce4KxtFmEv\n\tWcgEAetf2u1QcIOvpCKOi4gZu1P1yFvQOV3+JxL1WfAN0DrDRqykoyoRBGQi35XIWKq3A1DSZiB\n\t5ECVmXNwD3k4yYCQmTT2H5IOjmRfM2hzEeEpUHEg32tnV79FFXtNch5HUx8JViT0MuErCeLRs8=", "X-Google-Smtp-Source": "AGHT+IEXkMvfVT8xbVSxt6RfxVlUst44WgdaWvUFvMVNhgXZDhYeuw2c7MRK0aHrZGrbOa3UQgoQBg==", "X-Received": "by 2002:a05:6000:178a:b0:385:f417:ee46 with SMTP id\n\tffacd0b85a97d-3862b33b786mr2368320f8f.2.1733495267690; \n\tFri, 06 Dec 2024 06:27:47 -0800 (PST)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "David Plowman <david.plowman@raspberrypi.com>", "Subject": "[PATCH 4/5] pipeline: rpi: common: Add wallclock timestamp support", "Date": "Fri, 6 Dec 2024 14:27:41 +0000", "Message-Id": "<20241206142742.7931-5-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.39.5", "In-Reply-To": "<20241206142742.7931-1-david.plowman@raspberrypi.com>", "References": "<20241206142742.7931-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "A ClockRecovery object is added for derived classes to use, and\nwallclock timetamps are copied into the request metadata for\napplications.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 2 ++\n src/libcamera/pipeline/rpi/common/pipeline_base.h | 3 +++\n 2 files changed, 5 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\nindex 6f278b29..34971973 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n@@ -1509,6 +1509,8 @@ void CameraData::fillRequestMetadata(const ControlList &bufferControls, Request\n {\n \trequest->metadata().set(controls::SensorTimestamp,\n \t\t\t\tbufferControls.get(controls::SensorTimestamp).value_or(0));\n+\trequest->metadata().set(controls::FrameWallClock,\n+\t\t\t\tbufferControls.get(controls::FrameWallClock).value_or(0));\n \n \tif (cropParams_.size()) {\n \t\tstd::vector<Rectangle> crops;\ndiff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.h b/src/libcamera/pipeline/rpi/common/pipeline_base.h\nindex aae0c2f3..9aa591d6 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.h\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.h\n@@ -20,6 +20,7 @@\n #include \"libcamera/internal/bayer_format.h\"\n #include \"libcamera/internal/camera.h\"\n #include \"libcamera/internal/camera_sensor.h\"\n+#include \"libcamera/internal/clock_recovery.h\"\n #include \"libcamera/internal/framebuffer.h\"\n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/media_object.h\"\n@@ -237,6 +238,8 @@ protected:\n \tvirtual int platformRegister(std::unique_ptr<CameraData> &cameraData,\n \t\t\t\t MediaDevice *unicam, MediaDevice *isp) = 0;\n \n+\tClockRecovery wallClockRecoery_;\n+\n private:\n \tCameraData *cameraData(Camera *camera)\n \t{\n", "prefixes": [ "4/5" ] }