Patch Detail
Show a patch.
GET /api/patches/19384/?format=api
{ "id": 19384, "url": "https://patchwork.libcamera.org/api/patches/19384/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19384/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240112100203.3000-1-laurent.pinchart@ideasonboard.com>", "date": "2024-01-12T10:02:03", "name": "[libcamera-devel] libipa: camera_sensor_helper: Mark createInstance() with override", "commit_ref": "439cfe7fbd1b854db63900225e526f9a3a4ac08d", "pull_url": null, "state": "accepted", "archived": false, "hash": "0a932261e869f6cd8783cd7681cf140fd8b309f6", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19384/mbox/", "series": [ { "id": 4140, "url": "https://patchwork.libcamera.org/api/series/4140/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4140", "date": "2024-01-12T10:02:03", "name": "[libcamera-devel] libipa: camera_sensor_helper: Mark createInstance() with override", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4140/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19384/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19384/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 77918C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Jan 2024 10:02:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AFC38628B7;\n\tFri, 12 Jan 2024 11:02:12 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 00C38628B1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Jan 2024 11:01:56 +0100 (CET)", "from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi\n\t[89.27.53.110])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 99C6C7E4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Jan 2024 11:00:50 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1705053732;\n\tbh=JZRprbbVo0SwW6i0lxp6RFYbeRh0s5BYgGyUhQ4Feb8=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=wm66NU0o3i+s15ceJTssR3V/YLlnE2gjg3zcExxW268w5rFgfpVEZyj3+QHUzqjiW\n\tqEDd5biNbRVdimZf6b+EMEwhZeKxYRLN87UORgZJzY5047XpeNxTsS5idQiGG9eFhp\n\teenz5U4uv299JzEDRJ/T5ybisjGVLycn3TaR5dIWN1Gy6UCEPzjcH/4X4TDqtVx2UW\n\tvkLJi62cN3dX+v3ppE131Fm52WtJup34+ajUGbshDUU9lYzKAOehRFRo0uhgJmZYcC\n\tXyjX26mwcXPdoIvEaxobPRmT3OJNOdW25+KMwwMPO7WYXWmfpT3OQboyFJqd0P8FTa\n\tfpZp4bBGnt+fA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1705053650;\n\tbh=JZRprbbVo0SwW6i0lxp6RFYbeRh0s5BYgGyUhQ4Feb8=;\n\th=From:To:Subject:Date:From;\n\tb=H7JMkLLCmCup1qS72IAcnaMJhL9y49AHiOJQJqG6YLNzb7ndIO+tmzutL734+L/3d\n\tnLh5wAh2RjFPoQlZUPEithGBCk/kJexBSZyevbb1MKGq8/pqfvfwHg34SqcemCc4PC\n\tE2BNdFKfetaaE3/RpNxCFVIvC6+Nn8CiO9pse2as=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"H7JMkLLC\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 12 Jan 2024 12:02:03 +0200", "Message-ID": "<20240112100203.3000-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.41.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libipa: camera_sensor_helper: Mark\n\tcreateInstance() with override", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The CameraSensorHelperFactory::createInstance() function overrides a\nvirtual function from CameraSensorHelperFactoryBase. The function\ndeclaration doesn't mark it with the override keyword. This could cause\nissues in the future if the base class' function changes, as the\ncompiler will not issue any warning in that case. Fix it.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/libipa/camera_sensor_helper.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: 89227a428a82e724548399d35c98ea89566f9045", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h\nindex 3ea1806cb1fd..1ca9371be6ff 100644\n--- a/src/ipa/libipa/camera_sensor_helper.h\n+++ b/src/ipa/libipa/camera_sensor_helper.h\n@@ -88,7 +88,7 @@ public:\n \t}\n \n private:\n-\tstd::unique_ptr<CameraSensorHelper> createInstance() const\n+\tstd::unique_ptr<CameraSensorHelper> createInstance() const override\n \t{\n \t\treturn std::make_unique<_Helper>();\n \t}\n", "prefixes": [ "libcamera-devel" ] }