From patchwork Fri Jan 12 10:02:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 19384 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 77918C323E for ; Fri, 12 Jan 2024 10:02:13 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id AFC38628B7; Fri, 12 Jan 2024 11:02:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1705053732; bh=JZRprbbVo0SwW6i0lxp6RFYbeRh0s5BYgGyUhQ4Feb8=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=wm66NU0o3i+s15ceJTssR3V/YLlnE2gjg3zcExxW268w5rFgfpVEZyj3+QHUzqjiW qEDd5biNbRVdimZf6b+EMEwhZeKxYRLN87UORgZJzY5047XpeNxTsS5idQiGG9eFhp eenz5U4uv299JzEDRJ/T5ybisjGVLycn3TaR5dIWN1Gy6UCEPzjcH/4X4TDqtVx2UW vkLJi62cN3dX+v3ppE131Fm52WtJup34+ajUGbshDUU9lYzKAOehRFRo0uhgJmZYcC XyjX26mwcXPdoIvEaxobPRmT3OJNOdW25+KMwwMPO7WYXWmfpT3OQboyFJqd0P8FTa fpZp4bBGnt+fA== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 00C38628B1 for ; Fri, 12 Jan 2024 11:01:56 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="H7JMkLLC"; dkim-atps=neutral Received: from pendragon.ideasonboard.com (89-27-53-110.bb.dnainternet.fi [89.27.53.110]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 99C6C7E4 for ; Fri, 12 Jan 2024 11:00:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1705053650; bh=JZRprbbVo0SwW6i0lxp6RFYbeRh0s5BYgGyUhQ4Feb8=; h=From:To:Subject:Date:From; b=H7JMkLLCmCup1qS72IAcnaMJhL9y49AHiOJQJqG6YLNzb7ndIO+tmzutL734+L/3d nLh5wAh2RjFPoQlZUPEithGBCk/kJexBSZyevbb1MKGq8/pqfvfwHg34SqcemCc4PC E2BNdFKfetaaE3/RpNxCFVIvC6+Nn8CiO9pse2as= To: libcamera-devel@lists.libcamera.org Date: Fri, 12 Jan 2024 12:02:03 +0200 Message-ID: <20240112100203.3000-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: Mark createInstance() with override X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The CameraSensorHelperFactory::createInstance() function overrides a virtual function from CameraSensorHelperFactoryBase. The function declaration doesn't mark it with the override keyword. This could cause issues in the future if the base class' function changes, as the compiler will not issue any warning in that case. Fix it. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- src/ipa/libipa/camera_sensor_helper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 89227a428a82e724548399d35c98ea89566f9045 diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h index 3ea1806cb1fd..1ca9371be6ff 100644 --- a/src/ipa/libipa/camera_sensor_helper.h +++ b/src/ipa/libipa/camera_sensor_helper.h @@ -88,7 +88,7 @@ public: } private: - std::unique_ptr createInstance() const + std::unique_ptr createInstance() const override { return std::make_unique<_Helper>(); }