Patch Detail
Show a patch.
GET /api/patches/19243/?format=api
{ "id": 19243, "url": "https://patchwork.libcamera.org/api/patches/19243/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19243/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231128035231.253676-1-bbrotherton@google.com>", "date": "2023-11-28T03:51:18", "name": "[libcamera-devel,v2] libcamera: pipeline: fix c++20 compile warning", "commit_ref": "61f6b372421ad96e283220c2c7beb1cb298b1eaf", "pull_url": null, "state": "accepted", "archived": false, "hash": "57fecadbfb9da14c76e62b03e5a52618daa0cfd4", "submitter": { "id": 174, "url": "https://patchwork.libcamera.org/api/people/174/?format=api", "name": "Brett Brotherton", "email": "bbrotherton@google.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19243/mbox/", "series": [ { "id": 4087, "url": "https://patchwork.libcamera.org/api/series/4087/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4087", "date": "2023-11-28T03:51:18", "name": "[libcamera-devel,v2] libcamera: pipeline: fix c++20 compile warning", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4087/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19243/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19243/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5E0F7BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 28 Nov 2023 03:52:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8F5C1629C2;\n\tTue, 28 Nov 2023 04:52:37 +0100 (CET)", "from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com\n\t[IPv6:2607:f8b0:4864:20::114a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F3E2561DA1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Nov 2023 04:52:35 +0100 (CET)", "by mail-yw1-x114a.google.com with SMTP id\n\t00721157ae682-5d1b431fa7bso260027b3.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Nov 2023 19:52:35 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1701143557;\n\tbh=6ZfocAI9ztRFJKNjGXhRpRGDZ0tNL7KUInrBETkKKYc=;\n\th=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=BHWJACW+Xv9c2QFtWfLB45UYrXCgC+8mseZ3reGVHgSAXwD32jKqpB3v4ae888il3\n\trV/4sIl4PrmQrJ8syjuiaqdf71d7oyb4MY5Lraz5AVtiIwERsX0vvZcEjFKj2dKsWS\n\tgYknO2KrbCRbNdZpnrEkPXtkAtkj+I1n5IKTP7fsnbYT82h0RkCUUzAByQIp/qyn2w\n\txNE0XWOiWBwQnwhiVLwoIYOR2dkUl+n7oj2P02PQP4nox8l5R+p+G7mJFKzZoMG4vE\n\tDZ7++hCg5g/CKQS+Jzkz+UlRWWtGghfrtD0EBbjwNIDh1IsfXOT3NUQcRb82gmoho7\n\tq17O7CPCm2Ngg==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20230601; t=1701143554; x=1701748354;\n\tdarn=lists.libcamera.org; \n\th=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=UitBZ/NU3gzU9Xr9ehEKuAI4Hx3EIG6vnuaF04AfMlE=;\n\tb=iOvcb1okRCnTpgVJhOYoUL7GSCLbcVwyNTZYo/F1howaPLYkAQEq0LdEcNWJuiKk8I\n\txNJByLjgOUxTxT1cEaLRKTBD9Zo9/gyA/0Q3C8/a0YMD3bdeSNSg/HxNYw4QOA8AkDsC\n\taU8leZNSUCs9OOEymiIG+jnJ/OLDu+ltvD0nH6tLx0S1IOMsG0fyrpB9DwGsHuy98Vz0\n\tc8fUsR+Uadt6dOMfXKYtzTgLquZmogPBj3DXyUUWvpYfFLlxFO7vD3+ttpu+JfDDcrtO\n\tltd+vxHdsnip4hRG0ipq3Mcrx9/8KqUuP54sbOiZuNYIGKku0PEW59EW5sC9rS1ykwoa\n\tcyqA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=google.com\n\theader.i=@google.com header.b=\"iOvcb1ok\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1701143554; x=1701748354;\n\th=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=UitBZ/NU3gzU9Xr9ehEKuAI4Hx3EIG6vnuaF04AfMlE=;\n\tb=NpOI5eO/4CeCn1GwBWLQv1UZNoYic0ljYi0ZpwMlj3JhC0ZvLHLjqnaxtjY4/u7oCv\n\tr2j+yKwT5QwCnmyWMaXcdAK7ZQyG616yoAsNYyR7o6MMDhQxc7yqhXkCm3dfVCRJoJMC\n\tH+iz2KgNgxxZqmM5TLUIbws9+MI6GsC0W1nONr5rnqnRCauk+yNMschUmmknaKEecFpA\n\t8UNuBbtS060TuO/JRAgPZVhfiJYdO6ycrs/kyxVLyMdrojNbXQtjnUXe81xiaYs5HZDy\n\tv6JPYvmioTDqmc6YAMcq6FAAxnipMrKe1ZGs5EoFx0/35mClzEzSW0tBZsgSw0/LZex3\n\tApSQ==", "X-Gm-Message-State": "AOJu0YwHLgNpjK5rqJHNWxpqQ9wJS/FwNDokBTOskXW7Hr+DTdUqkdlX\n\tHgT9D4JW9uGqAXKH8QI2xZsvAJfeVFra4Q75dEzVpPe8+3RuMNpwXKtWRzYo2Y2oPUmM2hoJJ7X\n\tPCuC8sGFIx5E6cglQhy2PBQ7EpnTEtW2+89dzQcnamQGOBtxfU3vA344T2o+FTVL6O8RT5Pvsgl\n\tpP0ejf/Utl+xsmqkDJ", "X-Google-Smtp-Source": "AGHT+IGTlRYwCE296l4o3yzJVY5eL8GAQce4apVq3Vs8Uts781T1CFD8E2T8fZHSO5jdyLozT79JlPuABb/IQBEpow==", "X-Received": "from bbrotherton-ws.bld.corp.google.com\n\t([2620:15c:183:200:99a0:2883:1daf:2ef7])\n\t(user=bbrotherton job=sendgmr) by 2002:a05:690c:250d:b0:5ce:3dd9:a380\n\twith SMTP id\n\tdt13-20020a05690c250d00b005ce3dd9a380mr346492ywb.2.1701143554521;\n\tMon, 27 Nov 2023 19:52:34 -0800 (PST)", "Date": "Mon, 27 Nov 2023 20:51:18 -0700", "Mime-Version": "1.0", "X-Mailer": "git-send-email 2.43.0.rc1.413.gea7ed67945-goog", "Message-ID": "<20231128035231.253676-1-bbrotherton@google.com>", "To": "libcamera-devel@lists.libcamera.org", "Content-Type": "text/plain; charset=\"UTF-8\"", "Subject": "[libcamera-devel] [PATCH v2] libcamera: pipeline: fix c++20 compile\n\twarning", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Brett Brotherton via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Brett Brotherton <bbrotherton@google.com>", "Cc": "Brett Brotherton <bbrotherton@google.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "fix -Wdeprecated-this-capture error when building with c++20 by\nexplicity naming this in the capture\n\nSigned-off-by: Brett Brotherton <bbrotherton@google.com>\n---\n\nupdated patch to do explicit capture for C++17 and C++20 compatibility\ncompiled with both\n\n src/libcamera/pipeline_handler.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 9c74c6cf..29e0c98a 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -649,7 +649,7 @@ void PipelineHandler::registerCamera(std::shared_ptr<Camera> camera)\n */\n void PipelineHandler::hotplugMediaDevice(MediaDevice *media)\n {\n-\tmedia->disconnected.connect(this, [=]() { mediaDeviceDisconnected(media); });\n+\tmedia->disconnected.connect(this, [this, media] { mediaDeviceDisconnected(media); });\n }\n \n /**\n", "prefixes": [ "libcamera-devel", "v2" ] }