From patchwork Tue Nov 28 03:51:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brett Brotherton X-Patchwork-Id: 19243 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5E0F7BDE6B for ; Tue, 28 Nov 2023 03:52:38 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8F5C1629C2; Tue, 28 Nov 2023 04:52:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1701143557; bh=6ZfocAI9ztRFJKNjGXhRpRGDZ0tNL7KUInrBETkKKYc=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=BHWJACW+Xv9c2QFtWfLB45UYrXCgC+8mseZ3reGVHgSAXwD32jKqpB3v4ae888il3 rV/4sIl4PrmQrJ8syjuiaqdf71d7oyb4MY5Lraz5AVtiIwERsX0vvZcEjFKj2dKsWS gYknO2KrbCRbNdZpnrEkPXtkAtkj+I1n5IKTP7fsnbYT82h0RkCUUzAByQIp/qyn2w xNE0XWOiWBwQnwhiVLwoIYOR2dkUl+n7oj2P02PQP4nox8l5R+p+G7mJFKzZoMG4vE DZ7++hCg5g/CKQS+Jzkz+UlRWWtGghfrtD0EBbjwNIDh1IsfXOT3NUQcRb82gmoho7 q17O7CPCm2Ngg== Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id F3E2561DA1 for ; Tue, 28 Nov 2023 04:52:35 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="iOvcb1ok"; dkim-atps=neutral Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-5d1b431fa7bso260027b3.1 for ; Mon, 27 Nov 2023 19:52:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701143554; x=1701748354; darn=lists.libcamera.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=UitBZ/NU3gzU9Xr9ehEKuAI4Hx3EIG6vnuaF04AfMlE=; b=iOvcb1okRCnTpgVJhOYoUL7GSCLbcVwyNTZYo/F1howaPLYkAQEq0LdEcNWJuiKk8I xNJByLjgOUxTxT1cEaLRKTBD9Zo9/gyA/0Q3C8/a0YMD3bdeSNSg/HxNYw4QOA8AkDsC aU8leZNSUCs9OOEymiIG+jnJ/OLDu+ltvD0nH6tLx0S1IOMsG0fyrpB9DwGsHuy98Vz0 c8fUsR+Uadt6dOMfXKYtzTgLquZmogPBj3DXyUUWvpYfFLlxFO7vD3+ttpu+JfDDcrtO ltd+vxHdsnip4hRG0ipq3Mcrx9/8KqUuP54sbOiZuNYIGKku0PEW59EW5sC9rS1ykwoa cyqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701143554; x=1701748354; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=UitBZ/NU3gzU9Xr9ehEKuAI4Hx3EIG6vnuaF04AfMlE=; b=NpOI5eO/4CeCn1GwBWLQv1UZNoYic0ljYi0ZpwMlj3JhC0ZvLHLjqnaxtjY4/u7oCv r2j+yKwT5QwCnmyWMaXcdAK7ZQyG616yoAsNYyR7o6MMDhQxc7yqhXkCm3dfVCRJoJMC H+iz2KgNgxxZqmM5TLUIbws9+MI6GsC0W1nONr5rnqnRCauk+yNMschUmmknaKEecFpA 8UNuBbtS060TuO/JRAgPZVhfiJYdO6ycrs/kyxVLyMdrojNbXQtjnUXe81xiaYs5HZDy v6JPYvmioTDqmc6YAMcq6FAAxnipMrKe1ZGs5EoFx0/35mClzEzSW0tBZsgSw0/LZex3 ApSQ== X-Gm-Message-State: AOJu0YwHLgNpjK5rqJHNWxpqQ9wJS/FwNDokBTOskXW7Hr+DTdUqkdlX HgT9D4JW9uGqAXKH8QI2xZsvAJfeVFra4Q75dEzVpPe8+3RuMNpwXKtWRzYo2Y2oPUmM2hoJJ7X PCuC8sGFIx5E6cglQhy2PBQ7EpnTEtW2+89dzQcnamQGOBtxfU3vA344T2o+FTVL6O8RT5Pvsgl pP0ejf/Utl+xsmqkDJ X-Google-Smtp-Source: AGHT+IGTlRYwCE296l4o3yzJVY5eL8GAQce4apVq3Vs8Uts781T1CFD8E2T8fZHSO5jdyLozT79JlPuABb/IQBEpow== X-Received: from bbrotherton-ws.bld.corp.google.com ([2620:15c:183:200:99a0:2883:1daf:2ef7]) (user=bbrotherton job=sendgmr) by 2002:a05:690c:250d:b0:5ce:3dd9:a380 with SMTP id dt13-20020a05690c250d00b005ce3dd9a380mr346492ywb.2.1701143554521; Mon, 27 Nov 2023 19:52:34 -0800 (PST) Date: Mon, 27 Nov 2023 20:51:18 -0700 Mime-Version: 1.0 X-Mailer: git-send-email 2.43.0.rc1.413.gea7ed67945-goog Message-ID: <20231128035231.253676-1-bbrotherton@google.com> To: libcamera-devel@lists.libcamera.org Subject: [libcamera-devel] [PATCH v2] libcamera: pipeline: fix c++20 compile warning X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Brett Brotherton via libcamera-devel From: Brett Brotherton Reply-To: Brett Brotherton Cc: Brett Brotherton Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" fix -Wdeprecated-this-capture error when building with c++20 by explicity naming this in the capture Signed-off-by: Brett Brotherton Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart Tested-by: Laurent Pinchart --- updated patch to do explicit capture for C++17 and C++20 compatibility compiled with both src/libcamera/pipeline_handler.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp index 9c74c6cf..29e0c98a 100644 --- a/src/libcamera/pipeline_handler.cpp +++ b/src/libcamera/pipeline_handler.cpp @@ -649,7 +649,7 @@ void PipelineHandler::registerCamera(std::shared_ptr camera) */ void PipelineHandler::hotplugMediaDevice(MediaDevice *media) { - media->disconnected.connect(this, [=]() { mediaDeviceDisconnected(media); }); + media->disconnected.connect(this, [this, media] { mediaDeviceDisconnected(media); }); } /**