Patch Detail
Show a patch.
GET /api/patches/18949/?format=api
{ "id": 18949, "url": "https://patchwork.libcamera.org/api/patches/18949/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18949/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230822131934.151781-1-umang.jain@ideasonboard.com>", "date": "2023-08-22T13:19:34", "name": "[libcamera-devel] libcamera: stream: Document stride will be 0 for compressed formats", "commit_ref": "ae9bcb2155957da3b6324676d706a901acb8343f", "pull_url": null, "state": "accepted", "archived": false, "hash": "9fb740a0892cb30ab60176183adef91ffd381756", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18949/mbox/", "series": [ { "id": 4005, "url": "https://patchwork.libcamera.org/api/series/4005/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4005", "date": "2023-08-22T13:19:34", "name": "[libcamera-devel] libcamera: stream: Document stride will be 0 for compressed formats", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4005/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18949/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18949/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 02531BE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 22 Aug 2023 13:19:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5E4E861E0A;\n\tTue, 22 Aug 2023 15:19:43 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F08F061E08\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Aug 2023 15:19:41 +0200 (CEST)", "from umang.jainideasonboard.com (unknown [103.251.226.9])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4C8AC814;\n\tTue, 22 Aug 2023 15:18:24 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1692710383;\n\tbh=MseAQnsaGFvlfgGZDo5O4WPRBv7ci2SYM8NQ3X2ucNA=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=OJzi1/PsT3BIwIX1RSbyWfOz6+5/3bJQScTz7aQR2x0KU5nhlx60murLjyHsVY+Dd\n\t8GgXgvaIt7VMR5W7JAp8PRaWuME9ALqIiQ8cdcgq+/56OcppnuO9HScD1Z2mcv8FjW\n\tnWveuHfKih7AIHSgvhIf/wzIMA5rugbf59m2NUSjQAW/N0t1Cqz8SObLZmWQsLmiKj\n\tfkkSiLO82NmfZcjgzky1iaiXQg5jRpShzPqyQTclRK9D4gx10/6uOv34maaUo5q+ln\n\tzm07kcG0RQOUXxssbBylOr46U70dgwaP/P5js0nCulhdPOmVlUCQ3dHfA5i35m66Pu\n\t97zLNmKGc68Kw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1692710304;\n\tbh=MseAQnsaGFvlfgGZDo5O4WPRBv7ci2SYM8NQ3X2ucNA=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=GhOOIixWUBKmrNVFJCq+FQjmJCJGXqfdT2AgQmxK6n4BYNHCrIQjc7/MYuTAEJMGU\n\tHHy2bbNP8AmwoWKCxIW3ZhFMkNdcIAbiMTbE1u8Tn9qFVTr/gCNyleemrl/k8gaE8V\n\t6OimAuQSCpbBM69etRd4V2upcDvcZtpy1VGbDy/Y=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"GhOOIixW\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 22 Aug 2023 18:49:34 +0530", "Message-Id": "<20230822131934.151781-1-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.40.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: stream: Document stride will\n\tbe 0 for compressed formats", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Umang Jain <umang.jain@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "For compressed formats, v4l2_pix_format.bytesperline value will be zero\nand is documented similarly in the kernel. Since we set the stride to\nv4l2_pix_format.bytesperline, document the case where it is expected\nto be zero (i.e. if the format is compressed).\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/libcamera/stream.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\nindex 272222b7..f3e00ead 100644\n--- a/src/libcamera/stream.cpp\n+++ b/src/libcamera/stream.cpp\n@@ -311,7 +311,8 @@ StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n * The stride value reports the number of bytes between the beginning of\n * successive lines in an image buffer for this stream. The value is\n * valid after successfully validating the configuration with a call to\n- * CameraConfiguration::validate().\n+ * CameraConfiguration::validate(). For compressed formats (such as MJPEG),\n+ * this value will be zero.\n */\n \n /**\n", "prefixes": [ "libcamera-devel" ] }