From patchwork Tue Aug 22 13:19:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 18949 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 02531BE080 for ; Tue, 22 Aug 2023 13:19:43 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5E4E861E0A; Tue, 22 Aug 2023 15:19:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1692710383; bh=MseAQnsaGFvlfgGZDo5O4WPRBv7ci2SYM8NQ3X2ucNA=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=OJzi1/PsT3BIwIX1RSbyWfOz6+5/3bJQScTz7aQR2x0KU5nhlx60murLjyHsVY+Dd 8GgXgvaIt7VMR5W7JAp8PRaWuME9ALqIiQ8cdcgq+/56OcppnuO9HScD1Z2mcv8FjW nWveuHfKih7AIHSgvhIf/wzIMA5rugbf59m2NUSjQAW/N0t1Cqz8SObLZmWQsLmiKj fkkSiLO82NmfZcjgzky1iaiXQg5jRpShzPqyQTclRK9D4gx10/6uOv34maaUo5q+ln zm07kcG0RQOUXxssbBylOr46U70dgwaP/P5js0nCulhdPOmVlUCQ3dHfA5i35m66Pu 97zLNmKGc68Kw== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id F08F061E08 for ; Tue, 22 Aug 2023 15:19:41 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="GhOOIixW"; dkim-atps=neutral Received: from umang.jainideasonboard.com (unknown [103.251.226.9]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4C8AC814; Tue, 22 Aug 2023 15:18:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1692710304; bh=MseAQnsaGFvlfgGZDo5O4WPRBv7ci2SYM8NQ3X2ucNA=; h=From:To:Cc:Subject:Date:From; b=GhOOIixWUBKmrNVFJCq+FQjmJCJGXqfdT2AgQmxK6n4BYNHCrIQjc7/MYuTAEJMGU HHy2bbNP8AmwoWKCxIW3ZhFMkNdcIAbiMTbE1u8Tn9qFVTr/gCNyleemrl/k8gaE8V 6OimAuQSCpbBM69etRd4V2upcDvcZtpy1VGbDy/Y= To: libcamera-devel@lists.libcamera.org Date: Tue, 22 Aug 2023 18:49:34 +0530 Message-Id: <20230822131934.151781-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: stream: Document stride will be 0 for compressed formats X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Umang Jain via libcamera-devel From: Umang Jain Reply-To: Umang Jain Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" For compressed formats, v4l2_pix_format.bytesperline value will be zero and is documented similarly in the kernel. Since we set the stride to v4l2_pix_format.bytesperline, document the case where it is expected to be zero (i.e. if the format is compressed). Signed-off-by: Umang Jain Reviewed-by: Nicolas Dufresne Reviewed-by: Kieran Bingham --- src/libcamera/stream.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp index 272222b7..f3e00ead 100644 --- a/src/libcamera/stream.cpp +++ b/src/libcamera/stream.cpp @@ -311,7 +311,8 @@ StreamConfiguration::StreamConfiguration(const StreamFormats &formats) * The stride value reports the number of bytes between the beginning of * successive lines in an image buffer for this stream. The value is * valid after successfully validating the configuration with a call to - * CameraConfiguration::validate(). + * CameraConfiguration::validate(). For compressed formats (such as MJPEG), + * this value will be zero. */ /**