Patch Detail
Show a patch.
GET /api/patches/18732/?format=api
{ "id": 18732, "url": "https://patchwork.libcamera.org/api/patches/18732/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18732/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230613103519.91370-2-robert.mader@collabora.com>", "date": "2023-06-13T10:34:49", "name": "[libcamera-devel,1/2] gstreamer: src: Style change", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "cac2c61a51272cec5f029ddc61dbdc8781937eae", "submitter": { "id": 140, "url": "https://patchwork.libcamera.org/api/people/140/?format=api", "name": "Robert Mader", "email": "robert.mader@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18732/mbox/", "series": [ { "id": 3921, "url": "https://patchwork.libcamera.org/api/series/3921/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3921", "date": "2023-06-13T10:34:48", "name": "gstreamer: src: Add transform property", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3921/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18732/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18732/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C190BBD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Jun 2023 10:36:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 73F8961E4B;\n\tTue, 13 Jun 2023 12:36:30 +0200 (CEST)", "from madras.collabora.co.uk (madras.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2B8AE61E49\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Jun 2023 12:36:29 +0200 (CEST)", "from thinkpad-t460p.fritz.box (unknown\n\t[IPv6:2001:4090:a243:8015:93c:83c3:533:d433])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits)\n\tserver-digest SHA256)\n\t(No client certificate requested) (Authenticated sender: rmader)\n\tby madras.collabora.co.uk (Postfix) with ESMTPSA id C0C326606EFD;\n\tTue, 13 Jun 2023 11:36:28 +0100 (BST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686652590;\n\tbh=DBfbRsuTJYHqdtuxUT8g4xq8oUEVgXRv/1XZBOdEXNs=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=1Eck84S9jfp3xw1b8FUTr4AvvIEVT70DZi+skr2W7OKdMbrA28Mi5T9Q0T+s5WO2C\n\tF0c2vLMByqi4JonP+1rCmy5zaJu3jhOXja791ldGLzqLM8PXAaCXY7JSiQpFWmmrMb\n\tghBA5RC8dLB6VgeU24rxgQcg7tWQNjRxBrWx+jCivywJexJEUp+psqCqILb/ZBb5BK\n\tLdkGVOQjoOFpONz89us0UTJqfPFLLdpAiIQ4X/z9YDHXLVu3i9HfCK3q9E9BRz8Ag8\n\tKBkhQ2arYgn1juBDyYs9+GJs43APo5uqfeamfPYf4fq8VhPNgBSTz3KzvXuBYFuTLr\n\tUTfpTjjfnAmcg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;\n\ts=mail; t=1686652588;\n\tbh=DBfbRsuTJYHqdtuxUT8g4xq8oUEVgXRv/1XZBOdEXNs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kwoBlEfXrM8r5ai+bUCS4sTy2D3VOPtlxAEsQfEEhxVFuE2JuTRq+wodlwosgnAwd\n\tOqhuLB7z9/rPzlzwlwZvBoOblOasiQGRDOdADXC9p1ONIvwssJ10eUO7Hj5yLSEE39\n\t4qTXmHN2Qf3p4Bt8hALQvoB8sqYHjiy5oPhr9yNV/RSdl4xavJ3QnMx4LLiLXGatJB\n\tgn2fu8AgH4ZTnU0qHsCazRxi16jJ69USTvzQx/u5fLa6f+UupEInM1fJaagQh4c7HR\n\t7aQLT4YUDj4HxKSlRvryDW45CV/JO8Woor5mfr7jCgFYUNdgNakyp51d73PTpno9xt\n\tVC4OBcwtSbUvg==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=collabora.com\n\theader.i=@collabora.com\n\theader.b=\"kwoBlEfX\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 13 Jun 2023 12:34:49 +0200", "Message-ID": "<20230613103519.91370-2-robert.mader@collabora.com>", "X-Mailer": "git-send-email 2.41.0", "In-Reply-To": "<20230613103519.91370-1-robert.mader@collabora.com>", "References": "<20230613103519.91370-1-robert.mader@collabora.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/2] gstreamer: src: Style change", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Robert Mader via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Robert Mader <robert.mader@collabora.com>", "Cc": "Robert Mader <robert.mader@collabora.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Get rid of a variable and use a more common style in Gstreamer in\npreparation for more properties.\n\nSigned-off-by: Robert Mader <robert.mader@collabora.com>\n---\n src/gstreamer/gstlibcamerasrc.cpp | 15 ++++++++-------\n 1 file changed, 8 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex a10cbd4f..721b35c2 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -837,11 +837,12 @@ gst_libcamera_src_class_init(GstLibcameraSrcClass *klass)\n \t\t\t\t\t\t\t &request_src_template,\n \t\t\t\t\t\t\t GST_TYPE_LIBCAMERA_PAD);\n \n-\tGParamSpec *spec = g_param_spec_string(\"camera-name\", \"Camera Name\",\n-\t\t\t\t\t \"Select by name which camera to use.\", nullptr,\n-\t\t\t\t\t (GParamFlags)(GST_PARAM_MUTABLE_READY\n-\t\t\t\t\t\t\t | G_PARAM_CONSTRUCT\n-\t\t\t\t\t\t\t | G_PARAM_READWRITE\n-\t\t\t\t\t\t\t | G_PARAM_STATIC_STRINGS));\n-\tg_object_class_install_property(object_class, PROP_CAMERA_NAME, spec);\n+\tg_object_class_install_property(object_class, PROP_CAMERA_NAME,\n+\t\tg_param_spec_string(\"camera-name\", \"Camera Name\",\n+\t\t\t\t \"Select by name which camera to use.\",\n+\t\t\t\t nullptr,\n+\t\t\t\t (GParamFlags)(GST_PARAM_MUTABLE_READY\n+\t\t\t\t\t\t | G_PARAM_CONSTRUCT\n+\t\t\t\t\t\t | G_PARAM_READWRITE\n+\t\t\t\t\t\t | G_PARAM_STATIC_STRINGS)));\n }\n", "prefixes": [ "libcamera-devel", "1/2" ] }