From patchwork Tue Jun 13 10:34:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Mader X-Patchwork-Id: 18732 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C190BBD78E for ; Tue, 13 Jun 2023 10:36:30 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 73F8961E4B; Tue, 13 Jun 2023 12:36:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1686652590; bh=DBfbRsuTJYHqdtuxUT8g4xq8oUEVgXRv/1XZBOdEXNs=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=1Eck84S9jfp3xw1b8FUTr4AvvIEVT70DZi+skr2W7OKdMbrA28Mi5T9Q0T+s5WO2C F0c2vLMByqi4JonP+1rCmy5zaJu3jhOXja791ldGLzqLM8PXAaCXY7JSiQpFWmmrMb ghBA5RC8dLB6VgeU24rxgQcg7tWQNjRxBrWx+jCivywJexJEUp+psqCqILb/ZBb5BK LdkGVOQjoOFpONz89us0UTJqfPFLLdpAiIQ4X/z9YDHXLVu3i9HfCK3q9E9BRz8Ag8 KBkhQ2arYgn1juBDyYs9+GJs43APo5uqfeamfPYf4fq8VhPNgBSTz3KzvXuBYFuTLr UTfpTjjfnAmcg== Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2B8AE61E49 for ; Tue, 13 Jun 2023 12:36:29 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="kwoBlEfX"; dkim-atps=neutral Received: from thinkpad-t460p.fritz.box (unknown [IPv6:2001:4090:a243:8015:93c:83c3:533:d433]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: rmader) by madras.collabora.co.uk (Postfix) with ESMTPSA id C0C326606EFD; Tue, 13 Jun 2023 11:36:28 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1686652588; bh=DBfbRsuTJYHqdtuxUT8g4xq8oUEVgXRv/1XZBOdEXNs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kwoBlEfXrM8r5ai+bUCS4sTy2D3VOPtlxAEsQfEEhxVFuE2JuTRq+wodlwosgnAwd OqhuLB7z9/rPzlzwlwZvBoOblOasiQGRDOdADXC9p1ONIvwssJ10eUO7Hj5yLSEE39 4qTXmHN2Qf3p4Bt8hALQvoB8sqYHjiy5oPhr9yNV/RSdl4xavJ3QnMx4LLiLXGatJB gn2fu8AgH4ZTnU0qHsCazRxi16jJ69USTvzQx/u5fLa6f+UupEInM1fJaagQh4c7HR 7aQLT4YUDj4HxKSlRvryDW45CV/JO8Woor5mfr7jCgFYUNdgNakyp51d73PTpno9xt VC4OBcwtSbUvg== To: libcamera-devel@lists.libcamera.org Date: Tue, 13 Jun 2023 12:34:49 +0200 Message-ID: <20230613103519.91370-2-robert.mader@collabora.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230613103519.91370-1-robert.mader@collabora.com> References: <20230613103519.91370-1-robert.mader@collabora.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/2] gstreamer: src: Style change X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Robert Mader via libcamera-devel From: Robert Mader Reply-To: Robert Mader Cc: Robert Mader Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Get rid of a variable and use a more common style in Gstreamer in preparation for more properties. Signed-off-by: Robert Mader Reviewed-by: Kieran Bingham Reviewed-by: Umang Jain --- src/gstreamer/gstlibcamerasrc.cpp | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp index a10cbd4f..721b35c2 100644 --- a/src/gstreamer/gstlibcamerasrc.cpp +++ b/src/gstreamer/gstlibcamerasrc.cpp @@ -837,11 +837,12 @@ gst_libcamera_src_class_init(GstLibcameraSrcClass *klass) &request_src_template, GST_TYPE_LIBCAMERA_PAD); - GParamSpec *spec = g_param_spec_string("camera-name", "Camera Name", - "Select by name which camera to use.", nullptr, - (GParamFlags)(GST_PARAM_MUTABLE_READY - | G_PARAM_CONSTRUCT - | G_PARAM_READWRITE - | G_PARAM_STATIC_STRINGS)); - g_object_class_install_property(object_class, PROP_CAMERA_NAME, spec); + g_object_class_install_property(object_class, PROP_CAMERA_NAME, + g_param_spec_string("camera-name", "Camera Name", + "Select by name which camera to use.", + nullptr, + (GParamFlags)(GST_PARAM_MUTABLE_READY + | G_PARAM_CONSTRUCT + | G_PARAM_READWRITE + | G_PARAM_STATIC_STRINGS))); }