Patch Detail
Show a patch.
GET /api/patches/18716/?format=api
{ "id": 18716, "url": "https://patchwork.libcamera.org/api/patches/18716/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18716/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230607100054.4576-2-naush@raspberrypi.com>", "date": "2023-06-07T10:00:52", "name": "[libcamera-devel,v1,1/3] ipa: rpi: tunings: Add missing short and long exposure profiles", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "64b3bb0dc0ae412b7e180e9c9609d7f930dce063", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18716/mbox/", "series": [ { "id": 3912, "url": "https://patchwork.libcamera.org/api/series/3912/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3912", "date": "2023-06-07T10:00:51", "name": "RPi: AGC error handling", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3912/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18716/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18716/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CE732C328F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 7 Jun 2023 10:01:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B361362894;\n\tWed, 7 Jun 2023 12:01:07 +0200 (CEST)", "from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n\t[IPv6:2a00:1450:4864:20::335])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 48CEA60579\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 7 Jun 2023 12:01:06 +0200 (CEST)", "by mail-wm1-x335.google.com with SMTP id\n\t5b1f17b1804b1-3f6da07ff00so71992405e9.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 07 Jun 2023 03:01:06 -0700 (PDT)", "from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tt7-20020a1c7707000000b003f6cf9afc25sm1556889wmi.40.2023.06.07.03.01.04\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 07 Jun 2023 03:01:04 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1686132067;\n\tbh=MRgLHUxFO8buWPu4AEhUvy/IRKXu8f7unVxNVXBNShg=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=qnvX/P919xCVNssI0SCn966A/v13o7JwW05kVSrxpE5GAIvyBykWwrgL51aVNnww6\n\t/QFFqihLZZmWgv5hdOtpH0N6NPMvWKQaT8v1KUB2ICOqTXRBunQTkkmRUD7yjlzO7Z\n\tIma4fCQJ/Cdoohz3A41wH7h8AdOEDSTMUk3g4zu+OGdPzDPBAZUaM3MPf2NVqdE4Yy\n\t8sx+CaOXRB1poDkA94sNnAXU5e5JzR5xWqpANm6c9WPutvXYAsM0Y0u82/oc5YRU7U\n\twY89cSE75NMqQxHUUpMP4dA/aDqymvEJgrNGfPi/W2NcxEB93d9eWGHFp2sJ+crHgz\n\t2CeHNeHioQYsQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1686132065; x=1688724065;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=7tnM6woDwDZQwegs4k3OcD6JK0jSuXKj5pk0MqLrt1E=;\n\tb=oeaD4RO2Ps314ULDDtR7vJpwbiNXk+HOKj0ZkjjTicw6p84ANE88x7VgAKXY3k9SKM\n\t4U+ijFhjnKEspuaVn/+ew5ONb91rReGdi26geElaA6kkjW8yGxv+HgYP3x/m0mr7N/JX\n\t1mOTZhM1YSay8TN2OXbKAn+fOLY56bIlUKVpQZS4q114GG05iwXWYM1FH49M+pVcvY6d\n\tj15v0U2fEFwV1EEE+E7BNXvsPo7SblxOywi0i3pIHVRz5D+yzdaBhxbXk/ksmQxI5oBl\n\tTWrSReG/G1jwDAuuA25zPka7wKqc/yY6a7O2K/NcJHt8f+FB3LU22mzgs4GvjXJk1ohC\n\t/YyA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"oeaD4RO2\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1686132065; x=1688724065;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=7tnM6woDwDZQwegs4k3OcD6JK0jSuXKj5pk0MqLrt1E=;\n\tb=RIG4q77k+wMa+TSWYeS5AMHjqK13oe5OE7G1pj57tx4aAcOyp57EmHTlRVwnKofSBz\n\tQT+QgP60n9T319CJXQfwxT3d2CDxQG3vWGTNpansEBlATYlMf7gfheD2czua1MiIk7co\n\tGWlayl6+79G2tdB/PrcORLxT6BI+P0prgdPCLALcRJCXUUV6PxJ8XplloLG8tdewIs/N\n\td86A2l5jEw9M0+vOtJRiUJmQW2Ze2yp0BuTKRj3sHHIZ/RdC08QFDm1Pzk1pS+FzxeKa\n\t16FVA5x2IpEkDudseBZZxAiGtmydXOVSSx8qBOMUPxH5wtBugZ6qpedfTy+KZvf/3Xjj\n\tFEqg==", "X-Gm-Message-State": "AC+VfDzkYB4HJrQa/lKk9LGDV0EYuWjU3RrIUak/JDO1x2yeYsm1ECwm\n\t4AduK37i0zglMpxl9i/DzVujmHtb4zv5rIyw0NfxzA==", "X-Google-Smtp-Source": "ACHHUZ4Na2qQmMix6Fez+YOT9Hvkf6k6IunEfGB6yIomE9i1+arX8KgGdvGAYkPQOoUSDKnY/ik6hQ==", "X-Received": "by 2002:a05:600c:2252:b0:3f6:962d:405c with SMTP id\n\ta18-20020a05600c225200b003f6962d405cmr5018992wmm.41.1686132065627; \n\tWed, 07 Jun 2023 03:01:05 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 7 Jun 2023 11:00:52 +0100", "Message-Id": "<20230607100054.4576-2-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230607100054.4576-1-naush@raspberrypi.com>", "References": "<20230607100054.4576-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 1/3] ipa: rpi: tunings: Add missing\n\tshort and long exposure profiles", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Some sensor tuning files were missing the short and/or long exposure\nmode profiles. Add the missing items to the relevant files.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/ipa/rpi/vc4/data/imx290.json | 5 +++++\n src/ipa/rpi/vc4/data/imx296.json | 5 +++++\n src/ipa/rpi/vc4/data/imx296_mono.json | 5 +++++\n src/ipa/rpi/vc4/data/imx378.json | 5 +++++\n src/ipa/rpi/vc4/data/imx519.json | 5 +++++\n src/ipa/rpi/vc4/data/imx708.json | 5 +++++\n src/ipa/rpi/vc4/data/imx708_noir.json | 5 +++++\n src/ipa/rpi/vc4/data/imx708_wide.json | 5 +++++\n src/ipa/rpi/vc4/data/imx708_wide_noir.json | 5 +++++\n src/ipa/rpi/vc4/data/ov9281_mono.json | 10 ++++++++++\n src/ipa/rpi/vc4/data/se327m12.json | 5 +++++\n src/ipa/rpi/vc4/data/uncalibrated.json | 10 ++++++++++\n 12 files changed, 70 insertions(+)", "diff": "diff --git a/src/ipa/rpi/vc4/data/imx290.json b/src/ipa/rpi/vc4/data/imx290.json\nindex ace68d0ebf1c..bcf9189b0008 100644\n--- a/src/ipa/rpi/vc4/data/imx290.json\n+++ b/src/ipa/rpi/vc4/data/imx290.json\n@@ -74,6 +74,11 @@\n {\n \"shutter\": [ 10, 5000, 10000, 20000, 120000 ],\n \"gain\": [ 1.0, 2.0, 4.0, 6.0, 8.0 ]\n+ },\n+ \"long\":\n+ {\n+ \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n }\n },\n \"constraint_modes\":\ndiff --git a/src/ipa/rpi/vc4/data/imx296.json b/src/ipa/rpi/vc4/data/imx296.json\nindex ae8722c46a85..9330d0a9c81f 100644\n--- a/src/ipa/rpi/vc4/data/imx296.json\n+++ b/src/ipa/rpi/vc4/data/imx296.json\n@@ -157,6 +157,11 @@\n {\n \"shutter\": [ 100, 5000, 10000, 20000, 30000 ],\n \"gain\": [ 1.0, 2.0, 4.0, 8.0, 16.0 ]\n+ },\n+ \"long\":\n+ {\n+ \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n }\n },\n \"constraint_modes\":\ndiff --git a/src/ipa/rpi/vc4/data/imx296_mono.json b/src/ipa/rpi/vc4/data/imx296_mono.json\nindex db020550d70e..955af43cccff 100644\n--- a/src/ipa/rpi/vc4/data/imx296_mono.json\n+++ b/src/ipa/rpi/vc4/data/imx296_mono.json\n@@ -60,6 +60,11 @@\n {\n \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n+ },\n+ \"long\":\n+ {\n+ \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n }\n },\n \"constraint_modes\":\ndiff --git a/src/ipa/rpi/vc4/data/imx378.json b/src/ipa/rpi/vc4/data/imx378.json\nindex 8b4ed22504b5..f7b68011b634 100644\n--- a/src/ipa/rpi/vc4/data/imx378.json\n+++ b/src/ipa/rpi/vc4/data/imx378.json\n@@ -155,6 +155,11 @@\n {\n \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n \"gain\": [ 1.0, 2.0, 4.0, 6.0, 8.0 ]\n+ },\n+ \"long\":\n+ {\n+ \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n }\n },\n \"constraint_modes\":\ndiff --git a/src/ipa/rpi/vc4/data/imx519.json b/src/ipa/rpi/vc4/data/imx519.json\nindex 8ccfd3a631ff..1b0a77476aab 100644\n--- a/src/ipa/rpi/vc4/data/imx519.json\n+++ b/src/ipa/rpi/vc4/data/imx519.json\n@@ -155,6 +155,11 @@\n {\n \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n \"gain\": [ 1.0, 2.0, 4.0, 6.0, 8.0 ]\n+ },\n+ \"long\":\n+ {\n+ \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n }\n },\n \"constraint_modes\":\ndiff --git a/src/ipa/rpi/vc4/data/imx708.json b/src/ipa/rpi/vc4/data/imx708.json\nindex b9830a3bf692..6b26d0a19609 100644\n--- a/src/ipa/rpi/vc4/data/imx708.json\n+++ b/src/ipa/rpi/vc4/data/imx708.json\n@@ -165,6 +165,11 @@\n {\n \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n+ },\n+ \"long\":\n+ {\n+ \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n }\n },\n \"constraint_modes\":\ndiff --git a/src/ipa/rpi/vc4/data/imx708_noir.json b/src/ipa/rpi/vc4/data/imx708_noir.json\nindex 075f70355cec..8d498153833b 100644\n--- a/src/ipa/rpi/vc4/data/imx708_noir.json\n+++ b/src/ipa/rpi/vc4/data/imx708_noir.json\n@@ -165,6 +165,11 @@\n {\n \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n+ },\n+ \"long\":\n+ {\n+ \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n }\n },\n \"constraint_modes\":\ndiff --git a/src/ipa/rpi/vc4/data/imx708_wide.json b/src/ipa/rpi/vc4/data/imx708_wide.json\nindex b772efee3b96..14bc918e7823 100644\n--- a/src/ipa/rpi/vc4/data/imx708_wide.json\n+++ b/src/ipa/rpi/vc4/data/imx708_wide.json\n@@ -155,6 +155,11 @@\n {\n \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n+ },\n+ \"long\":\n+ {\n+ \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n }\n },\n \"constraint_modes\":\ndiff --git a/src/ipa/rpi/vc4/data/imx708_wide_noir.json b/src/ipa/rpi/vc4/data/imx708_wide_noir.json\nindex c5f6b53dca7a..49442c0f9d81 100644\n--- a/src/ipa/rpi/vc4/data/imx708_wide_noir.json\n+++ b/src/ipa/rpi/vc4/data/imx708_wide_noir.json\n@@ -155,6 +155,11 @@\n {\n \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n+ },\n+ \"long\":\n+ {\n+ \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n }\n },\n \"constraint_modes\":\ndiff --git a/src/ipa/rpi/vc4/data/ov9281_mono.json b/src/ipa/rpi/vc4/data/ov9281_mono.json\nindex 37944c63ad92..2b7292ec7e20 100644\n--- a/src/ipa/rpi/vc4/data/ov9281_mono.json\n+++ b/src/ipa/rpi/vc4/data/ov9281_mono.json\n@@ -44,6 +44,16 @@\n {\n \"shutter\": [ 100, 15000, 30000, 60000, 120000 ],\n \"gain\": [ 1.0, 2.0, 3.0, 4.0, 8.0 ]\n+ },\n+ \"short\":\n+ {\n+ \"shutter\": [ 100, 5000, 10000, 20000, 30000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 8.0 ]\n+ },\n+ \"long\":\n+ {\n+ \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n }\n },\n \"constraint_modes\":\ndiff --git a/src/ipa/rpi/vc4/data/se327m12.json b/src/ipa/rpi/vc4/data/se327m12.json\nindex ee69caea50c0..8552ed92bce6 100644\n--- a/src/ipa/rpi/vc4/data/se327m12.json\n+++ b/src/ipa/rpi/vc4/data/se327m12.json\n@@ -155,6 +155,11 @@\n {\n \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n \"gain\": [ 1.0, 2.0, 4.0, 6.0, 8.0 ]\n+ },\n+ \"long\":\n+ {\n+ \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n }\n },\n \"constraint_modes\":\ndiff --git a/src/ipa/rpi/vc4/data/uncalibrated.json b/src/ipa/rpi/vc4/data/uncalibrated.json\nindex 13eb3f177302..7654defa6dfe 100644\n--- a/src/ipa/rpi/vc4/data/uncalibrated.json\n+++ b/src/ipa/rpi/vc4/data/uncalibrated.json\n@@ -31,6 +31,16 @@\n {\n \"shutter\": [ 100, 15000, 30000, 60000, 120000 ],\n \"gain\": [ 1.0, 2.0, 3.0, 4.0, 6.0 ]\n+ },\n+ \"short\":\n+ {\n+ \"shutter\": [ 100, 5000, 10000, 20000, 30000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 8.0 ]\n+ },\n+ \"long\":\n+ {\n+ \"shutter\": [ 1000, 30000, 60000, 90000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 12.0 ]\n }\n },\n \"constraint_modes\":\n", "prefixes": [ "libcamera-devel", "v1", "1/3" ] }