From patchwork Wed Jun 7 10:00:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 18716 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CE732C328F for ; Wed, 7 Jun 2023 10:01:08 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B361362894; Wed, 7 Jun 2023 12:01:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1686132067; bh=MRgLHUxFO8buWPu4AEhUvy/IRKXu8f7unVxNVXBNShg=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=qnvX/P919xCVNssI0SCn966A/v13o7JwW05kVSrxpE5GAIvyBykWwrgL51aVNnww6 /QFFqihLZZmWgv5hdOtpH0N6NPMvWKQaT8v1KUB2ICOqTXRBunQTkkmRUD7yjlzO7Z Ima4fCQJ/Cdoohz3A41wH7h8AdOEDSTMUk3g4zu+OGdPzDPBAZUaM3MPf2NVqdE4Yy 8sx+CaOXRB1poDkA94sNnAXU5e5JzR5xWqpANm6c9WPutvXYAsM0Y0u82/oc5YRU7U wY89cSE75NMqQxHUUpMP4dA/aDqymvEJgrNGfPi/W2NcxEB93d9eWGHFp2sJ+crHgz 2CeHNeHioQYsQ== Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 48CEA60579 for ; Wed, 7 Jun 2023 12:01:06 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="oeaD4RO2"; dkim-atps=neutral Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-3f6da07ff00so71992405e9.3 for ; Wed, 07 Jun 2023 03:01:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1686132065; x=1688724065; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7tnM6woDwDZQwegs4k3OcD6JK0jSuXKj5pk0MqLrt1E=; b=oeaD4RO2Ps314ULDDtR7vJpwbiNXk+HOKj0ZkjjTicw6p84ANE88x7VgAKXY3k9SKM 4U+ijFhjnKEspuaVn/+ew5ONb91rReGdi26geElaA6kkjW8yGxv+HgYP3x/m0mr7N/JX 1mOTZhM1YSay8TN2OXbKAn+fOLY56bIlUKVpQZS4q114GG05iwXWYM1FH49M+pVcvY6d j15v0U2fEFwV1EEE+E7BNXvsPo7SblxOywi0i3pIHVRz5D+yzdaBhxbXk/ksmQxI5oBl TWrSReG/G1jwDAuuA25zPka7wKqc/yY6a7O2K/NcJHt8f+FB3LU22mzgs4GvjXJk1ohC /YyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686132065; x=1688724065; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7tnM6woDwDZQwegs4k3OcD6JK0jSuXKj5pk0MqLrt1E=; b=RIG4q77k+wMa+TSWYeS5AMHjqK13oe5OE7G1pj57tx4aAcOyp57EmHTlRVwnKofSBz QT+QgP60n9T319CJXQfwxT3d2CDxQG3vWGTNpansEBlATYlMf7gfheD2czua1MiIk7co GWlayl6+79G2tdB/PrcORLxT6BI+P0prgdPCLALcRJCXUUV6PxJ8XplloLG8tdewIs/N d86A2l5jEw9M0+vOtJRiUJmQW2Ze2yp0BuTKRj3sHHIZ/RdC08QFDm1Pzk1pS+FzxeKa 16FVA5x2IpEkDudseBZZxAiGtmydXOVSSx8qBOMUPxH5wtBugZ6qpedfTy+KZvf/3Xjj FEqg== X-Gm-Message-State: AC+VfDzkYB4HJrQa/lKk9LGDV0EYuWjU3RrIUak/JDO1x2yeYsm1ECwm 4AduK37i0zglMpxl9i/DzVujmHtb4zv5rIyw0NfxzA== X-Google-Smtp-Source: ACHHUZ4Na2qQmMix6Fez+YOT9Hvkf6k6IunEfGB6yIomE9i1+arX8KgGdvGAYkPQOoUSDKnY/ik6hQ== X-Received: by 2002:a05:600c:2252:b0:3f6:962d:405c with SMTP id a18-20020a05600c225200b003f6962d405cmr5018992wmm.41.1686132065627; Wed, 07 Jun 2023 03:01:05 -0700 (PDT) Received: from localhost.localdomain ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id t7-20020a1c7707000000b003f6cf9afc25sm1556889wmi.40.2023.06.07.03.01.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 03:01:04 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Wed, 7 Jun 2023 11:00:52 +0100 Message-Id: <20230607100054.4576-2-naush@raspberrypi.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230607100054.4576-1-naush@raspberrypi.com> References: <20230607100054.4576-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v1 1/3] ipa: rpi: tunings: Add missing short and long exposure profiles X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Naushir Patuck via libcamera-devel From: Naushir Patuck Reply-To: Naushir Patuck Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Some sensor tuning files were missing the short and/or long exposure mode profiles. Add the missing items to the relevant files. Signed-off-by: Naushir Patuck Reviewed-by: Kieran Bingham --- src/ipa/rpi/vc4/data/imx290.json | 5 +++++ src/ipa/rpi/vc4/data/imx296.json | 5 +++++ src/ipa/rpi/vc4/data/imx296_mono.json | 5 +++++ src/ipa/rpi/vc4/data/imx378.json | 5 +++++ src/ipa/rpi/vc4/data/imx519.json | 5 +++++ src/ipa/rpi/vc4/data/imx708.json | 5 +++++ src/ipa/rpi/vc4/data/imx708_noir.json | 5 +++++ src/ipa/rpi/vc4/data/imx708_wide.json | 5 +++++ src/ipa/rpi/vc4/data/imx708_wide_noir.json | 5 +++++ src/ipa/rpi/vc4/data/ov9281_mono.json | 10 ++++++++++ src/ipa/rpi/vc4/data/se327m12.json | 5 +++++ src/ipa/rpi/vc4/data/uncalibrated.json | 10 ++++++++++ 12 files changed, 70 insertions(+) diff --git a/src/ipa/rpi/vc4/data/imx290.json b/src/ipa/rpi/vc4/data/imx290.json index ace68d0ebf1c..bcf9189b0008 100644 --- a/src/ipa/rpi/vc4/data/imx290.json +++ b/src/ipa/rpi/vc4/data/imx290.json @@ -74,6 +74,11 @@ { "shutter": [ 10, 5000, 10000, 20000, 120000 ], "gain": [ 1.0, 2.0, 4.0, 6.0, 8.0 ] + }, + "long": + { + "shutter": [ 1000, 30000, 60000, 90000, 120000 ], + "gain": [ 1.0, 2.0, 4.0, 6.0, 12.0 ] } }, "constraint_modes": diff --git a/src/ipa/rpi/vc4/data/imx296.json b/src/ipa/rpi/vc4/data/imx296.json index ae8722c46a85..9330d0a9c81f 100644 --- a/src/ipa/rpi/vc4/data/imx296.json +++ b/src/ipa/rpi/vc4/data/imx296.json @@ -157,6 +157,11 @@ { "shutter": [ 100, 5000, 10000, 20000, 30000 ], "gain": [ 1.0, 2.0, 4.0, 8.0, 16.0 ] + }, + "long": + { + "shutter": [ 1000, 30000, 60000, 90000, 120000 ], + "gain": [ 1.0, 2.0, 4.0, 6.0, 12.0 ] } }, "constraint_modes": diff --git a/src/ipa/rpi/vc4/data/imx296_mono.json b/src/ipa/rpi/vc4/data/imx296_mono.json index db020550d70e..955af43cccff 100644 --- a/src/ipa/rpi/vc4/data/imx296_mono.json +++ b/src/ipa/rpi/vc4/data/imx296_mono.json @@ -60,6 +60,11 @@ { "shutter": [ 100, 5000, 10000, 20000, 120000 ], "gain": [ 1.0, 2.0, 4.0, 6.0, 6.0 ] + }, + "long": + { + "shutter": [ 1000, 30000, 60000, 90000, 120000 ], + "gain": [ 1.0, 2.0, 4.0, 6.0, 12.0 ] } }, "constraint_modes": diff --git a/src/ipa/rpi/vc4/data/imx378.json b/src/ipa/rpi/vc4/data/imx378.json index 8b4ed22504b5..f7b68011b634 100644 --- a/src/ipa/rpi/vc4/data/imx378.json +++ b/src/ipa/rpi/vc4/data/imx378.json @@ -155,6 +155,11 @@ { "shutter": [ 100, 5000, 10000, 20000, 120000 ], "gain": [ 1.0, 2.0, 4.0, 6.0, 8.0 ] + }, + "long": + { + "shutter": [ 1000, 30000, 60000, 90000, 120000 ], + "gain": [ 1.0, 2.0, 4.0, 6.0, 12.0 ] } }, "constraint_modes": diff --git a/src/ipa/rpi/vc4/data/imx519.json b/src/ipa/rpi/vc4/data/imx519.json index 8ccfd3a631ff..1b0a77476aab 100644 --- a/src/ipa/rpi/vc4/data/imx519.json +++ b/src/ipa/rpi/vc4/data/imx519.json @@ -155,6 +155,11 @@ { "shutter": [ 100, 5000, 10000, 20000, 120000 ], "gain": [ 1.0, 2.0, 4.0, 6.0, 8.0 ] + }, + "long": + { + "shutter": [ 1000, 30000, 60000, 90000, 120000 ], + "gain": [ 1.0, 2.0, 4.0, 6.0, 12.0 ] } }, "constraint_modes": diff --git a/src/ipa/rpi/vc4/data/imx708.json b/src/ipa/rpi/vc4/data/imx708.json index b9830a3bf692..6b26d0a19609 100644 --- a/src/ipa/rpi/vc4/data/imx708.json +++ b/src/ipa/rpi/vc4/data/imx708.json @@ -165,6 +165,11 @@ { "shutter": [ 100, 5000, 10000, 20000, 120000 ], "gain": [ 1.0, 2.0, 4.0, 6.0, 6.0 ] + }, + "long": + { + "shutter": [ 1000, 30000, 60000, 90000, 120000 ], + "gain": [ 1.0, 2.0, 4.0, 6.0, 12.0 ] } }, "constraint_modes": diff --git a/src/ipa/rpi/vc4/data/imx708_noir.json b/src/ipa/rpi/vc4/data/imx708_noir.json index 075f70355cec..8d498153833b 100644 --- a/src/ipa/rpi/vc4/data/imx708_noir.json +++ b/src/ipa/rpi/vc4/data/imx708_noir.json @@ -165,6 +165,11 @@ { "shutter": [ 100, 5000, 10000, 20000, 120000 ], "gain": [ 1.0, 2.0, 4.0, 6.0, 6.0 ] + }, + "long": + { + "shutter": [ 1000, 30000, 60000, 90000, 120000 ], + "gain": [ 1.0, 2.0, 4.0, 6.0, 12.0 ] } }, "constraint_modes": diff --git a/src/ipa/rpi/vc4/data/imx708_wide.json b/src/ipa/rpi/vc4/data/imx708_wide.json index b772efee3b96..14bc918e7823 100644 --- a/src/ipa/rpi/vc4/data/imx708_wide.json +++ b/src/ipa/rpi/vc4/data/imx708_wide.json @@ -155,6 +155,11 @@ { "shutter": [ 100, 5000, 10000, 20000, 120000 ], "gain": [ 1.0, 2.0, 4.0, 6.0, 6.0 ] + }, + "long": + { + "shutter": [ 1000, 30000, 60000, 90000, 120000 ], + "gain": [ 1.0, 2.0, 4.0, 6.0, 12.0 ] } }, "constraint_modes": diff --git a/src/ipa/rpi/vc4/data/imx708_wide_noir.json b/src/ipa/rpi/vc4/data/imx708_wide_noir.json index c5f6b53dca7a..49442c0f9d81 100644 --- a/src/ipa/rpi/vc4/data/imx708_wide_noir.json +++ b/src/ipa/rpi/vc4/data/imx708_wide_noir.json @@ -155,6 +155,11 @@ { "shutter": [ 100, 5000, 10000, 20000, 120000 ], "gain": [ 1.0, 2.0, 4.0, 6.0, 6.0 ] + }, + "long": + { + "shutter": [ 1000, 30000, 60000, 90000, 120000 ], + "gain": [ 1.0, 2.0, 4.0, 6.0, 12.0 ] } }, "constraint_modes": diff --git a/src/ipa/rpi/vc4/data/ov9281_mono.json b/src/ipa/rpi/vc4/data/ov9281_mono.json index 37944c63ad92..2b7292ec7e20 100644 --- a/src/ipa/rpi/vc4/data/ov9281_mono.json +++ b/src/ipa/rpi/vc4/data/ov9281_mono.json @@ -44,6 +44,16 @@ { "shutter": [ 100, 15000, 30000, 60000, 120000 ], "gain": [ 1.0, 2.0, 3.0, 4.0, 8.0 ] + }, + "short": + { + "shutter": [ 100, 5000, 10000, 20000, 30000 ], + "gain": [ 1.0, 2.0, 4.0, 6.0, 8.0 ] + }, + "long": + { + "shutter": [ 1000, 30000, 60000, 90000, 120000 ], + "gain": [ 1.0, 2.0, 4.0, 6.0, 12.0 ] } }, "constraint_modes": diff --git a/src/ipa/rpi/vc4/data/se327m12.json b/src/ipa/rpi/vc4/data/se327m12.json index ee69caea50c0..8552ed92bce6 100644 --- a/src/ipa/rpi/vc4/data/se327m12.json +++ b/src/ipa/rpi/vc4/data/se327m12.json @@ -155,6 +155,11 @@ { "shutter": [ 100, 5000, 10000, 20000, 120000 ], "gain": [ 1.0, 2.0, 4.0, 6.0, 8.0 ] + }, + "long": + { + "shutter": [ 1000, 30000, 60000, 90000, 120000 ], + "gain": [ 1.0, 2.0, 4.0, 6.0, 12.0 ] } }, "constraint_modes": diff --git a/src/ipa/rpi/vc4/data/uncalibrated.json b/src/ipa/rpi/vc4/data/uncalibrated.json index 13eb3f177302..7654defa6dfe 100644 --- a/src/ipa/rpi/vc4/data/uncalibrated.json +++ b/src/ipa/rpi/vc4/data/uncalibrated.json @@ -31,6 +31,16 @@ { "shutter": [ 100, 15000, 30000, 60000, 120000 ], "gain": [ 1.0, 2.0, 3.0, 4.0, 6.0 ] + }, + "short": + { + "shutter": [ 100, 5000, 10000, 20000, 30000 ], + "gain": [ 1.0, 2.0, 4.0, 6.0, 8.0 ] + }, + "long": + { + "shutter": [ 1000, 30000, 60000, 90000, 120000 ], + "gain": [ 1.0, 2.0, 4.0, 6.0, 12.0 ] } }, "constraint_modes":