Patch Detail
Show a patch.
GET /api/patches/18704/?format=api
{ "id": 18704, "url": "https://patchwork.libcamera.org/api/patches/18704/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18704/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230605091406.31757-2-naush@raspberrypi.com>", "date": "2023-06-05T09:14:04", "name": "[libcamera-devel,v3,1/3] libcamera: controls: Define a default lens position behaviour", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "49babbba0dc08ffa36c156415048d3a7c24a4b7c", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18704/mbox/", "series": [ { "id": 3907, "url": "https://patchwork.libcamera.org/api/series/3907/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3907", "date": "2023-06-05T09:14:03", "name": "Default lens behaviour", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3907/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18704/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18704/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CF5DEC31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 5 Jun 2023 09:14:50 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 956BF61EA2;\n\tMon, 5 Jun 2023 11:14:50 +0200 (CEST)", "from mail-lf1-x136.google.com (mail-lf1-x136.google.com\n\t[IPv6:2a00:1450:4864:20::136])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F33861EA2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 5 Jun 2023 11:14:47 +0200 (CEST)", "by mail-lf1-x136.google.com with SMTP id\n\t2adb3069b0e04-4f4b384c09fso5560404e87.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 05 Jun 2023 02:14:47 -0700 (PDT)", "from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tz16-20020a7bc7d0000000b003f605814850sm13776369wmk.37.2023.06.05.02.14.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 05 Jun 2023 02:14:46 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1685956490;\n\tbh=rAPPRGIK7ergAYTWapdZD2yrLY0T1UiUdGaIuCtw1t4=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=xH7by0Ge0ezzRUdS4hWS5CE1BfkJgJFroR7OElsRDqdNIEJny+VDTa5tSuR8c6/PF\n\t47qKjo6fy3ao4WGGfdQmccfWk8KdiKA6dA8dYt9K0oFTr+Dk9e2hgExhuc7zn3FSXs\n\t6SAIE5Dix8k+yLTyB/bXbHlTZ0oRiCYup+ivU5aT90WakZGjjXv7lNDlyAzT4nwPLm\n\tKuL5GQMEycT6HuwnaVZRS/9BOrkSOgIy8XKpQQ1RbDZbehgcMZEskGm/12iAeGCJZR\n\t1ujsLky+phzhrk7SXW1cqdwzew5jxh7UR1/wGcNJXhNvWAkX+ejIWKwcB46jCPh5e9\n\tjGAKO4YDmPhQw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1685956486; x=1688548486;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=ywJGWkJ6oloWq9znNAk+rwVyBoiU6N9YCFeBpk7/Zk4=;\n\tb=EfBciO9xunCWWZvVZ5hWch9mYTCl6UCDzUTxGhbGgGiRwKBLI3u9E2pHgnDJiYauby\n\tCj8da264e6m67PZaGRz15Jxj4GIufrdW6+e7WVVQQL/x6AuqM4oey7MGn7+fh7S5qWFY\n\tDJ3XdHltpxIIPj4VxuGJWmJ1T5Mf3SaOrkU4MLjLsqlIqqiDujXS+wyYHGMxg9B2LseH\n\tbq7H91IwDmmIdynEbwdrTli3ELjdDTnAdZEdh4/SUV0RQJ7aYCdt/PDYcFcwKQM0ipkT\n\toRWQrKzVpSsyjlJNEtktebyiWpDYBCe9MUphI7Ft9fcQjiBg2kY5LVCtyZ/lJtDaY/IE\n\tqlkA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"EfBciO9x\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1685956486; x=1688548486;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=ywJGWkJ6oloWq9znNAk+rwVyBoiU6N9YCFeBpk7/Zk4=;\n\tb=Fcg8RKDHh6lV/r2tL4kF6UJ8atSZsE2CYPlCsVjsJdKS0dmcsqB5IvMZC5lUkmvKp7\n\tMPJcuNfx8wvKEdhpMjRC9KdSagomBG9EeCwBsHjt1yp88avmY6+w1PRRE9eBTCGWliHB\n\tRQgy37YUFUgwo2tYBp95qkSEfLYAhmgf+vK4dcaiA36LTJ3p5o5icJWa3vO/0QSFLxAI\n\tAI2PsNYGO9VUgxC9kcVhxn7ARPnO+QLvg8PuKFruc6ViWAnHAbA1hmT0qnVSv7BiawPs\n\tQWcYfAnt8nknH6zMLrpX/jnoyfm7ewaMZSRgKrhzZ40egjBT754/LSwcHNNNCrUMT3iD\n\tXsFA==", "X-Gm-Message-State": "AC+VfDxLN1JwjgPKefOuNKNQraRNSGCPiEPCW40uOdxvMjjz/d5cUKK5\n\tjS4W4fsvfOsLlWTVXRln3WwXpdVuFQC3zuBag3oaVQ==", "X-Google-Smtp-Source": "ACHHUZ57rx5YLLGtpziINCbHbjBKvGO01057WjC0Qof9uMdtcW4H1atQ2ToguutuD+KXjqlUbMKgNw==", "X-Received": "by 2002:ac2:5455:0:b0:4f3:a1fe:5b1c with SMTP id\n\td21-20020ac25455000000b004f3a1fe5b1cmr4957148lfn.44.1685956486514; \n\tMon, 05 Jun 2023 02:14:46 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 5 Jun 2023 10:14:04 +0100", "Message-Id": "<20230605091406.31757-2-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230605091406.31757-1-naush@raspberrypi.com>", "References": "<20230605091406.31757-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 1/3] libcamera: controls: Define a\n\tdefault lens position behaviour", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Update the AfMode control description to explicitly define a\nstartup/default behaviour.\n\nOn startup, the camera will move the lens to the position given by the\ndefault value of the LensPosition control if operating in manual focus\nmode. Typically this would be the hyperfocal position of the lens.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/control_ids.yaml | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex adea5f90acc5..765168e539a8 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -408,6 +408,13 @@ controls:\n LensPosition control.\n \n In this mode the AfState will always report AfStateIdle.\n+\n+ If the camera is started in AfModeManual, it will move the focus\n+ lens to the position specified by the LensPosition control.\n+\n+ This mode is the recommended default value for the AfMode control.\n+ External cameras (as reported by the Location property set to\n+ CameraLocationExternal) may use a different default value.\n - name: AfModeAuto\n value: 1\n description: |\n", "prefixes": [ "libcamera-devel", "v3", "1/3" ] }