From patchwork Mon Jun 5 09:14:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 18704 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CF5DEC31E9 for ; Mon, 5 Jun 2023 09:14:50 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 956BF61EA2; Mon, 5 Jun 2023 11:14:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1685956490; bh=rAPPRGIK7ergAYTWapdZD2yrLY0T1UiUdGaIuCtw1t4=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=xH7by0Ge0ezzRUdS4hWS5CE1BfkJgJFroR7OElsRDqdNIEJny+VDTa5tSuR8c6/PF 47qKjo6fy3ao4WGGfdQmccfWk8KdiKA6dA8dYt9K0oFTr+Dk9e2hgExhuc7zn3FSXs 6SAIE5Dix8k+yLTyB/bXbHlTZ0oRiCYup+ivU5aT90WakZGjjXv7lNDlyAzT4nwPLm KuL5GQMEycT6HuwnaVZRS/9BOrkSOgIy8XKpQQ1RbDZbehgcMZEskGm/12iAeGCJZR 1ujsLky+phzhrk7SXW1cqdwzew5jxh7UR1/wGcNJXhNvWAkX+ejIWKwcB46jCPh5e9 jGAKO4YDmPhQw== Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F33861EA2 for ; Mon, 5 Jun 2023 11:14:47 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="EfBciO9x"; dkim-atps=neutral Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-4f4b384c09fso5560404e87.3 for ; Mon, 05 Jun 2023 02:14:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1685956486; x=1688548486; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ywJGWkJ6oloWq9znNAk+rwVyBoiU6N9YCFeBpk7/Zk4=; b=EfBciO9xunCWWZvVZ5hWch9mYTCl6UCDzUTxGhbGgGiRwKBLI3u9E2pHgnDJiYauby Cj8da264e6m67PZaGRz15Jxj4GIufrdW6+e7WVVQQL/x6AuqM4oey7MGn7+fh7S5qWFY DJ3XdHltpxIIPj4VxuGJWmJ1T5Mf3SaOrkU4MLjLsqlIqqiDujXS+wyYHGMxg9B2LseH bq7H91IwDmmIdynEbwdrTli3ELjdDTnAdZEdh4/SUV0RQJ7aYCdt/PDYcFcwKQM0ipkT oRWQrKzVpSsyjlJNEtktebyiWpDYBCe9MUphI7Ft9fcQjiBg2kY5LVCtyZ/lJtDaY/IE qlkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685956486; x=1688548486; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ywJGWkJ6oloWq9znNAk+rwVyBoiU6N9YCFeBpk7/Zk4=; b=Fcg8RKDHh6lV/r2tL4kF6UJ8atSZsE2CYPlCsVjsJdKS0dmcsqB5IvMZC5lUkmvKp7 MPJcuNfx8wvKEdhpMjRC9KdSagomBG9EeCwBsHjt1yp88avmY6+w1PRRE9eBTCGWliHB RQgy37YUFUgwo2tYBp95qkSEfLYAhmgf+vK4dcaiA36LTJ3p5o5icJWa3vO/0QSFLxAI AI2PsNYGO9VUgxC9kcVhxn7ARPnO+QLvg8PuKFruc6ViWAnHAbA1hmT0qnVSv7BiawPs QWcYfAnt8nknH6zMLrpX/jnoyfm7ewaMZSRgKrhzZ40egjBT754/LSwcHNNNCrUMT3iD XsFA== X-Gm-Message-State: AC+VfDxLN1JwjgPKefOuNKNQraRNSGCPiEPCW40uOdxvMjjz/d5cUKK5 jS4W4fsvfOsLlWTVXRln3WwXpdVuFQC3zuBag3oaVQ== X-Google-Smtp-Source: ACHHUZ57rx5YLLGtpziINCbHbjBKvGO01057WjC0Qof9uMdtcW4H1atQ2ToguutuD+KXjqlUbMKgNw== X-Received: by 2002:ac2:5455:0:b0:4f3:a1fe:5b1c with SMTP id d21-20020ac25455000000b004f3a1fe5b1cmr4957148lfn.44.1685956486514; Mon, 05 Jun 2023 02:14:46 -0700 (PDT) Received: from localhost.localdomain ([93.93.133.154]) by smtp.gmail.com with ESMTPSA id z16-20020a7bc7d0000000b003f605814850sm13776369wmk.37.2023.06.05.02.14.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jun 2023 02:14:46 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Mon, 5 Jun 2023 10:14:04 +0100 Message-Id: <20230605091406.31757-2-naush@raspberrypi.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230605091406.31757-1-naush@raspberrypi.com> References: <20230605091406.31757-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 1/3] libcamera: controls: Define a default lens position behaviour X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Naushir Patuck via libcamera-devel From: Naushir Patuck Reply-To: Naushir Patuck Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Update the AfMode control description to explicitly define a startup/default behaviour. On startup, the camera will move the lens to the position given by the default value of the LensPosition control if operating in manual focus mode. Typically this would be the hyperfocal position of the lens. Signed-off-by: Naushir Patuck Reviewed-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- src/libcamera/control_ids.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml index adea5f90acc5..765168e539a8 100644 --- a/src/libcamera/control_ids.yaml +++ b/src/libcamera/control_ids.yaml @@ -408,6 +408,13 @@ controls: LensPosition control. In this mode the AfState will always report AfStateIdle. + + If the camera is started in AfModeManual, it will move the focus + lens to the position specified by the LensPosition control. + + This mode is the recommended default value for the AfMode control. + External cameras (as reported by the Location property set to + CameraLocationExternal) may use a different default value. - name: AfModeAuto value: 1 description: |