Patch Detail
Show a patch.
GET /api/patches/18532/?format=api
{ "id": 18532, "url": "https://patchwork.libcamera.org/api/patches/18532/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18532/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230407102050.17537-2-harveyycyang@gmail.com>", "date": "2023-04-07T10:20:49", "name": "[libcamera-devel,v5,1/2] libcamera: pipeline: Accept a camera having no MediaDevice", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "21419ac980f26a8e940e8c2a0cc6d95c75f5ce23", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18532/mbox/", "series": [ { "id": 3838, "url": "https://patchwork.libcamera.org/api/series/3838/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3838", "date": "2023-04-07T10:20:48", "name": "Virtual Pipeline Handler", "version": 5, "mbox": "https://patchwork.libcamera.org/series/3838/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18532/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18532/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0AE0EC32A3\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 7 Apr 2023 10:20:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 05A52627BD;\n\tFri, 7 Apr 2023 12:20:58 +0200 (CEST)", "from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com\n\t[IPv6:2607:f8b0:4864:20::62b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 770D462763\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 7 Apr 2023 12:20:56 +0200 (CEST)", "by mail-pl1-x62b.google.com with SMTP id iw3so39661988plb.6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 07 Apr 2023 03:20:56 -0700 (PDT)", "from harveyyang.localdomain (1-163-45-206.dynamic-ip.hinet.net.\n\t[1.163.45.206]) by smtp.gmail.com with ESMTPSA id\n\tl11-20020a17090270cb00b0019a997bca5csm2641409plt.121.2023.04.07.03.20.54\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 07 Apr 2023 03:20:54 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1680862858;\n\tbh=l1h/D/vuJ+I1KbXSlpJqaD18Smov91NsxZZy461oUmY=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=TgigI++K/ZZC4jxBrb69R8CmuFyHdGfw76HlNNC/edicDhb3SON7omdbVvNUOvEgU\n\t5gV+pyo1WiGGZ4Q8ZU1aO2MYmPsZSmAowmv7G5nyffsWupJ3Qi3Y8K9yLFj3/U6RVf\n\tiK2Ier25zlZzagiLSqcjjkT822siOxDY8OJrnrVn5LMSsEzDO/KEwEHC8v4cIECoTu\n\tttKL/In4QXxqr3i+Xx8TtYmLSH5rU4HuTPnctGH9h8nyvqZYAPTa01wmslN0xEbAUT\n\toXXb7j1SHpXSFV9I6n3OCnjk1jTGsJZKO4TPKV+BQqsY8hitNosCvecHB6U1AohkIh\n\t74Q0bOlvnNF/w==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1680862855; x=1683454855;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=7gNXBhPXya4Sn5CRlvd8LZGctiDbHgmaWIyWrS+KSwo=;\n\tb=ZWoFkWkN+Oll/9YXmaGFAd7ykVehfxMuU/ZxvK8eWCXNRgWtMnkfda1Sd0hxhcLKyY\n\tuu13jG3QcFK4uCvkeAa8BNp9DpYgWadaHz0dXpcgbR7NjcQsPEmvfNHhBB4JK8OTtYbz\n\tsLyztZZSbbSiq/YdgWQ+4TpZdgEkOE9G1dS8k=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"ZWoFkWkN\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112; t=1680862855; x=1683454855;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=7gNXBhPXya4Sn5CRlvd8LZGctiDbHgmaWIyWrS+KSwo=;\n\tb=fbMBZ4Mb/RTMvjZjhiwAFP24uYl2hftgugu5T3iy2I1yvszVgi0RI+bZnr5fzYd6m8\n\tww1+25erJxadVEp/I0H71AomV5I2poPCA6+frlU7bXaBUQtZBFaQNmKqeSRbD6JMIj0x\n\t95YZTw/Z/zjJ0NQDDNc+qH5PCa1Wn4kIoMLB/UaTZlUkJSGbyNIq3hFtgscVW0ZEbBXP\n\td6bPdqewkvBsXv5YbZoQV6pdoL1uqbrTGBZayEEPlexkB/uMTajy8sLaNyxqQd5zmusY\n\tkzZlqFpN6vWnQUKRqa1mRqvE7wZUgUAiZ9AahOLWBc4LYCs2xj1du/U3WeDMWplc5m7T\n\ta72w==", "X-Gm-Message-State": "AAQBX9fF1uvfkUWvd5/62PV7zZLWg0gB+sxc8dh/2J8mzCjK/P+dSWjb\n\tVKPuiOr4zgbnwttISdcrwJqZmeKCa139WHC/27CFFA==", "X-Google-Smtp-Source": "AKy350b89NoJqRljQRevrjqKmyYhYW46LcErd4kMM5s1f/YYbF66VFL8EqaUfrANIrva4wbYxGRpyg==", "X-Received": "by 2002:a17:903:64c:b0:19f:1e3e:a84d with SMTP id\n\tkh12-20020a170903064c00b0019f1e3ea84dmr1935190plb.64.1680862854856; \n\tFri, 07 Apr 2023 03:20:54 -0700 (PDT)", "X-Google-Original-From": "Harvey Yang <harveyycyang@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 7 Apr 2023 18:20:49 +0800", "Message-Id": "<20230407102050.17537-2-harveyycyang@gmail.com>", "X-Mailer": "git-send-email 2.40.0", "In-Reply-To": "<20230407102050.17537-1-harveyycyang@gmail.com>", "References": "<20230407102050.17537-1-harveyycyang@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 1/2] libcamera: pipeline: Accept a\n\tcamera having no MediaDevice", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Harvey Yang via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Harvey Yang <chenghaoyang@chromium.org>", "Cc": "Harvey Yang <chenghaoyang@chromium.org>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Harvey Yang <chenghaoyang@chromium.org>\n\nThe Fatal check of having at least one MediaDevice was to prevent\npipeline handler implementations searching and owning media devices with\ncustom conventions, instead of using the base function\n|acquireMediaDevice|. It also has the assumption that there's at least\none media device to make a camera work.\n\nNow that the assumption will be broken by the virtual pipeline handler\nadded in the following patches, and developers should be aware of the\navailable functions in the base class to handle media devices, the Fatal\ncheck is no longer needed.\n\nSigned-off-by: Harvey Yang <chenghaoyang@chromium.org>\n---\n src/libcamera/pipeline_handler.cpp | 4 ----\n 1 file changed, 4 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex f72613b8..21979ea5 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -604,10 +604,6 @@ void PipelineHandler::registerCamera(std::shared_ptr<Camera> camera)\n {\n \tcameras_.push_back(camera);\n \n-\tif (mediaDevices_.empty())\n-\t\tLOG(Pipeline, Fatal)\n-\t\t\t<< \"Registering camera with no media devices!\";\n-\n \t/*\n \t * Walk the entity list and map the devnums of all capture video nodes\n \t * to the camera.\n", "prefixes": [ "libcamera-devel", "v5", "1/2" ] }