From patchwork Fri Apr 7 10:20:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cheng-Hao Yang X-Patchwork-Id: 18532 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0AE0EC32A3 for ; Fri, 7 Apr 2023 10:20:59 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 05A52627BD; Fri, 7 Apr 2023 12:20:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1680862858; bh=l1h/D/vuJ+I1KbXSlpJqaD18Smov91NsxZZy461oUmY=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=TgigI++K/ZZC4jxBrb69R8CmuFyHdGfw76HlNNC/edicDhb3SON7omdbVvNUOvEgU 5gV+pyo1WiGGZ4Q8ZU1aO2MYmPsZSmAowmv7G5nyffsWupJ3Qi3Y8K9yLFj3/U6RVf iK2Ier25zlZzagiLSqcjjkT822siOxDY8OJrnrVn5LMSsEzDO/KEwEHC8v4cIECoTu ttKL/In4QXxqr3i+Xx8TtYmLSH5rU4HuTPnctGH9h8nyvqZYAPTa01wmslN0xEbAUT oXXb7j1SHpXSFV9I6n3OCnjk1jTGsJZKO4TPKV+BQqsY8hitNosCvecHB6U1AohkIh 74Q0bOlvnNF/w== Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 770D462763 for ; Fri, 7 Apr 2023 12:20:56 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="ZWoFkWkN"; dkim-atps=neutral Received: by mail-pl1-x62b.google.com with SMTP id iw3so39661988plb.6 for ; Fri, 07 Apr 2023 03:20:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1680862855; x=1683454855; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7gNXBhPXya4Sn5CRlvd8LZGctiDbHgmaWIyWrS+KSwo=; b=ZWoFkWkN+Oll/9YXmaGFAd7ykVehfxMuU/ZxvK8eWCXNRgWtMnkfda1Sd0hxhcLKyY uu13jG3QcFK4uCvkeAa8BNp9DpYgWadaHz0dXpcgbR7NjcQsPEmvfNHhBB4JK8OTtYbz sLyztZZSbbSiq/YdgWQ+4TpZdgEkOE9G1dS8k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680862855; x=1683454855; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7gNXBhPXya4Sn5CRlvd8LZGctiDbHgmaWIyWrS+KSwo=; b=fbMBZ4Mb/RTMvjZjhiwAFP24uYl2hftgugu5T3iy2I1yvszVgi0RI+bZnr5fzYd6m8 ww1+25erJxadVEp/I0H71AomV5I2poPCA6+frlU7bXaBUQtZBFaQNmKqeSRbD6JMIj0x 95YZTw/Z/zjJ0NQDDNc+qH5PCa1Wn4kIoMLB/UaTZlUkJSGbyNIq3hFtgscVW0ZEbBXP d6bPdqewkvBsXv5YbZoQV6pdoL1uqbrTGBZayEEPlexkB/uMTajy8sLaNyxqQd5zmusY kzZlqFpN6vWnQUKRqa1mRqvE7wZUgUAiZ9AahOLWBc4LYCs2xj1du/U3WeDMWplc5m7T a72w== X-Gm-Message-State: AAQBX9fF1uvfkUWvd5/62PV7zZLWg0gB+sxc8dh/2J8mzCjK/P+dSWjb VKPuiOr4zgbnwttISdcrwJqZmeKCa139WHC/27CFFA== X-Google-Smtp-Source: AKy350b89NoJqRljQRevrjqKmyYhYW46LcErd4kMM5s1f/YYbF66VFL8EqaUfrANIrva4wbYxGRpyg== X-Received: by 2002:a17:903:64c:b0:19f:1e3e:a84d with SMTP id kh12-20020a170903064c00b0019f1e3ea84dmr1935190plb.64.1680862854856; Fri, 07 Apr 2023 03:20:54 -0700 (PDT) Received: from harveyyang.localdomain (1-163-45-206.dynamic-ip.hinet.net. [1.163.45.206]) by smtp.gmail.com with ESMTPSA id l11-20020a17090270cb00b0019a997bca5csm2641409plt.121.2023.04.07.03.20.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Apr 2023 03:20:54 -0700 (PDT) X-Google-Original-From: Harvey Yang To: libcamera-devel@lists.libcamera.org Date: Fri, 7 Apr 2023 18:20:49 +0800 Message-Id: <20230407102050.17537-2-harveyycyang@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230407102050.17537-1-harveyycyang@gmail.com> References: <20230407102050.17537-1-harveyycyang@gmail.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v5 1/2] libcamera: pipeline: Accept a camera having no MediaDevice X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Harvey Yang via libcamera-devel From: Cheng-Hao Yang Reply-To: Harvey Yang Cc: Harvey Yang Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Harvey Yang The Fatal check of having at least one MediaDevice was to prevent pipeline handler implementations searching and owning media devices with custom conventions, instead of using the base function |acquireMediaDevice|. It also has the assumption that there's at least one media device to make a camera work. Now that the assumption will be broken by the virtual pipeline handler added in the following patches, and developers should be aware of the available functions in the base class to handle media devices, the Fatal check is no longer needed. Signed-off-by: Harvey Yang --- src/libcamera/pipeline_handler.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp index f72613b8..21979ea5 100644 --- a/src/libcamera/pipeline_handler.cpp +++ b/src/libcamera/pipeline_handler.cpp @@ -604,10 +604,6 @@ void PipelineHandler::registerCamera(std::shared_ptr camera) { cameras_.push_back(camera); - if (mediaDevices_.empty()) - LOG(Pipeline, Fatal) - << "Registering camera with no media devices!"; - /* * Walk the entity list and map the devnums of all capture video nodes * to the camera.