Patch Detail
Show a patch.
GET /api/patches/18419/?format=api
{ "id": 18419, "url": "https://patchwork.libcamera.org/api/patches/18419/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18419/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230318234014.29506-11-dan.scally@ideasonboard.com>", "date": "2023-03-18T23:40:13", "name": "[libcamera-devel,10/11] apps: qcam: Remove restriction on raw-only streams", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "5de3b2001eb150114ae56bb8d1cfef10be875e8f", "submitter": { "id": 156, "url": "https://patchwork.libcamera.org/api/people/156/?format=api", "name": "Dan Scally", "email": "dan.scally@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18419/mbox/", "series": [ { "id": 3807, "url": "https://patchwork.libcamera.org/api/series/3807/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3807", "date": "2023-03-18T23:40:03", "name": "Support OV7251 in IPU3 pipeline and qcam", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3807/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18419/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18419/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 027EBC32A2\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 18 Mar 2023 23:40:42 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A622B626E7;\n\tSun, 19 Mar 2023 00:40:42 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 04F37626F8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 19 Mar 2023 00:40:35 +0100 (CET)", "from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9A8B0DF7;\n\tSun, 19 Mar 2023 00:40:34 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1679182842;\n\tbh=kFdz5wZIRgm0bOgr4WvYOQWdWx74ZZ5b0C/N2dLaiGs=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=BnGRkYC455qm/tcwXi7zHtFKHC/a8J2zouJV79sLuJEoquTJYyBaD7ECf2+hSkWnV\n\tmi71q73OO1NuPEKq7+c5KchOrPJINWOUp6C7KyAS6ilPLkF9rc1NfnYmsK7W9e5YDH\n\tVKGfH0w9BcRO+qoj2gDL7eRGxM5EkoJ0ai4jcp6RrO9YZQed/79ds1KZ7LqeTTMYYv\n\tjottqhcb7g5OMZ88LkQPgyp3GLBbzvbKJfWbO3tsE+5M0sWDLkgdyaiL7RHhiLzjd3\n\t3FL83RwlLggvfahLnkQrIOZY3nb6huf0eL1nCYnqDGE6FMmFKjBh1HCinSzgJtuzQv\n\tl3Vm/G/L90LLA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1679182834;\n\tbh=kFdz5wZIRgm0bOgr4WvYOQWdWx74ZZ5b0C/N2dLaiGs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=r6Ld8JkJ5F35iC0NPf5jadMskKfznIT8+6gFneMYkBoisgaAzjP0wS0Z3j75x8E9B\n\tRHZWYy45EJ7abhWexJJHTUPk7IoG0UgUJfHmQTMKURFI3BbDdEJq9WgWQvfIMYha2E\n\tS9uoDFZ/o3v/TbJ9XTxQEtMOeggpmNtNnN8MMvSI=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"r6Ld8JkJ\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 18 Mar 2023 23:40:13 +0000", "Message-Id": "<20230318234014.29506-11-dan.scally@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230318234014.29506-1-dan.scally@ideasonboard.com>", "References": "<20230318234014.29506-1-dan.scally@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 10/11] apps: qcam: Remove restriction on\n\traw-only streams", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Daniel Scally via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Daniel Scally <dan.scally@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "qcam currently will not allow a single stream with the Raw role. If\nthe format output by a Camera's Raw configuration is supported by\nthe viewfinder there doesn't seem to be a reason not to allow it.\nRemove the restriction.\n\nSigned-off-by: Daniel Scally <dan.scally@ideasonboard.com>\n---\n src/apps/qcam/main_window.cpp | 6 ------\n 1 file changed, 6 deletions(-)", "diff": "diff --git a/src/apps/qcam/main_window.cpp b/src/apps/qcam/main_window.cpp\nindex fb2db4aa..a9bb733e 100644\n--- a/src/apps/qcam/main_window.cpp\n+++ b/src/apps/qcam/main_window.cpp\n@@ -367,12 +367,6 @@ int MainWindow::startCapture()\n \n \t/* Verify roles are supported. */\n \tswitch (roles.size()) {\n-\tcase 1:\n-\t\tif (roles[0] != StreamRole::Viewfinder) {\n-\t\t\tqWarning() << \"Only viewfinder supported for single stream\";\n-\t\t\treturn -EINVAL;\n-\t\t}\n-\t\tbreak;\n \tcase 2:\n \t\tif (roles[0] != StreamRole::Viewfinder ||\n \t\t roles[1] != StreamRole::Raw) {\n", "prefixes": [ "libcamera-devel", "10/11" ] }