From patchwork Sat Mar 18 23:40:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Scally X-Patchwork-Id: 18419 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 027EBC32A2 for ; Sat, 18 Mar 2023 23:40:42 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A622B626E7; Sun, 19 Mar 2023 00:40:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1679182842; bh=kFdz5wZIRgm0bOgr4WvYOQWdWx74ZZ5b0C/N2dLaiGs=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=BnGRkYC455qm/tcwXi7zHtFKHC/a8J2zouJV79sLuJEoquTJYyBaD7ECf2+hSkWnV mi71q73OO1NuPEKq7+c5KchOrPJINWOUp6C7KyAS6ilPLkF9rc1NfnYmsK7W9e5YDH VKGfH0w9BcRO+qoj2gDL7eRGxM5EkoJ0ai4jcp6RrO9YZQed/79ds1KZ7LqeTTMYYv jottqhcb7g5OMZ88LkQPgyp3GLBbzvbKJfWbO3tsE+5M0sWDLkgdyaiL7RHhiLzjd3 3FL83RwlLggvfahLnkQrIOZY3nb6huf0eL1nCYnqDGE6FMmFKjBh1HCinSzgJtuzQv l3Vm/G/L90LLA== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 04F37626F8 for ; Sun, 19 Mar 2023 00:40:35 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="r6Ld8JkJ"; dkim-atps=neutral Received: from mail.ideasonboard.com (cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9A8B0DF7; Sun, 19 Mar 2023 00:40:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1679182834; bh=kFdz5wZIRgm0bOgr4WvYOQWdWx74ZZ5b0C/N2dLaiGs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r6Ld8JkJ5F35iC0NPf5jadMskKfznIT8+6gFneMYkBoisgaAzjP0wS0Z3j75x8E9B RHZWYy45EJ7abhWexJJHTUPk7IoG0UgUJfHmQTMKURFI3BbDdEJq9WgWQvfIMYha2E S9uoDFZ/o3v/TbJ9XTxQEtMOeggpmNtNnN8MMvSI= To: libcamera-devel@lists.libcamera.org Date: Sat, 18 Mar 2023 23:40:13 +0000 Message-Id: <20230318234014.29506-11-dan.scally@ideasonboard.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230318234014.29506-1-dan.scally@ideasonboard.com> References: <20230318234014.29506-1-dan.scally@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 10/11] apps: qcam: Remove restriction on raw-only streams X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Daniel Scally via libcamera-devel From: Daniel Scally Reply-To: Daniel Scally Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" qcam currently will not allow a single stream with the Raw role. If the format output by a Camera's Raw configuration is supported by the viewfinder there doesn't seem to be a reason not to allow it. Remove the restriction. Signed-off-by: Daniel Scally --- src/apps/qcam/main_window.cpp | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/apps/qcam/main_window.cpp b/src/apps/qcam/main_window.cpp index fb2db4aa..a9bb733e 100644 --- a/src/apps/qcam/main_window.cpp +++ b/src/apps/qcam/main_window.cpp @@ -367,12 +367,6 @@ int MainWindow::startCapture() /* Verify roles are supported. */ switch (roles.size()) { - case 1: - if (roles[0] != StreamRole::Viewfinder) { - qWarning() << "Only viewfinder supported for single stream"; - return -EINVAL; - } - break; case 2: if (roles[0] != StreamRole::Viewfinder || roles[1] != StreamRole::Raw) {