Patch Detail
Show a patch.
GET /api/patches/18416/?format=api
{ "id": 18416, "url": "https://patchwork.libcamera.org/api/patches/18416/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18416/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230318234014.29506-8-dan.scally@ideasonboard.com>", "date": "2023-03-18T23:40:10", "name": "[libcamera-devel,07/11] pipeline: ipu3: Allow raw-only streams in IPU3 pipeline", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "ce5a5706eebf677b3976e62ad9fa345d592ca5fb", "submitter": { "id": 156, "url": "https://patchwork.libcamera.org/api/people/156/?format=api", "name": "Dan Scally", "email": "dan.scally@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18416/mbox/", "series": [ { "id": 3807, "url": "https://patchwork.libcamera.org/api/series/3807/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3807", "date": "2023-03-18T23:40:03", "name": "Support OV7251 in IPU3 pipeline and qcam", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3807/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18416/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18416/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E4A28C32A0\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 18 Mar 2023 23:40:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C5EEC62749;\n\tSun, 19 Mar 2023 00:40:39 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0ABE4626F0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 19 Mar 2023 00:40:34 +0100 (CET)", "from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A2241B6C;\n\tSun, 19 Mar 2023 00:40:33 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1679182839;\n\tbh=TOB8NzOJQZVy9wXQwy2irZUghPdzOZyRJ0vbM+Gp+m8=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=PIsKPHzBimUAiqvd0ccbmvYD8FXpZqVeVT/MJNnBKMCr2IRT8hVZxQ2bp6OBOcA1u\n\te3F06QPTBnYUp+wagOrXkMwMMtvKSrJIwcu7iKBqdQxgRGHZLDnxK98dYjJx+dH5mC\n\tk/cM8tbAh1ReegIe2vCy368Lh8Q93e/xvuiU8SanXQbmf4NRaJ+P3GZIRejhUbvST/\n\toVUr2m1EP2sLLri+PqJ/ubO/VkLo8Sx9uNDOOiDjIk6t62jsNkwVIfDe6FI375OwHA\n\tMHCt00STYUYNLU/iyGi8gyeaYdwb1X4Qej//J941JnWNB5NiWfN50bVgbSUIoscaoD\n\tw54Ady6U5rq8A==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1679182833;\n\tbh=TOB8NzOJQZVy9wXQwy2irZUghPdzOZyRJ0vbM+Gp+m8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=m1KoJGm9WI3+Jdqhg8wGu8kc0vtLzmcoOPFOZxm1f0+8W2bA+VNU7aHp67JKGO2yA\n\thd1bC0eAGMsyRZldUNibdDLvVsb5RWN6TJq4Kk7upceoXhtTKk3wJKWhqfRBHeI77y\n\tLFBcEJCOtH8Jr+hMqxZAxJH9veLoD2/AYCKHpYTA=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"m1KoJGm9\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 18 Mar 2023 23:40:10 +0000", "Message-Id": "<20230318234014.29506-8-dan.scally@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230318234014.29506-1-dan.scally@ideasonboard.com>", "References": "<20230318234014.29506-1-dan.scally@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 07/11] pipeline: ipu3: Allow raw-only\n\tstreams in IPU3 pipeline", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Daniel Scally via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Daniel Scally <dan.scally@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Sensors not connected to the Imgu produce raw-only streams. Allow\nthat configuration to proceed in the IPU3 pipeline, but warn about\nthe lack of sensor controls for other sensors.\n\nSigned-off-by: Daniel Scally <dan.scally@ideasonboard.com>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex cc7da299..b9228a59 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -232,18 +232,18 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate()\n \t\treturn Invalid;\n \t} else if (rawCount && !yuvCount) {\n \t\t/*\n-\t\t * Disallow raw-only camera configuration. Currently, ImgU does\n-\t\t * not get configured for raw-only streams and has early return\n-\t\t * in configure(). To support raw-only stream, we do need the IPA\n-\t\t * to get configured since it will setup the sensor controls for\n-\t\t * the capture.\n+\t\t * Currently, ImgU does not get configured for raw-only streams\n+\t\t * and has early return in configure(). To support raw-only stream,\n+\t\t * we do need the IPA to get configured since it will setup the\n+\t\t * sensor controls for the capture. As some sensors _only_ output\n+\t\t * raw streams though we need to allow the configuration to\n+\t\t * continue here.\n \t\t *\n \t\t * \\todo Configure the ImgU with internal buffers which will enable\n \t\t * the IPA to get configured for the raw-only camera configuration.\n \t\t */\n \t\tLOG(IPU3, Debug)\n-\t\t\t<< \"Camera configuration cannot support raw-only streams\";\n-\t\treturn Invalid;\n+\t\t\t<< \"Sensor controls not supported for raw-only stream\";\n \t}\n \n \t/*\n", "prefixes": [ "libcamera-devel", "07/11" ] }