From patchwork Sat Mar 18 23:40:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Scally X-Patchwork-Id: 18416 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E4A28C32A0 for ; Sat, 18 Mar 2023 23:40:40 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C5EEC62749; Sun, 19 Mar 2023 00:40:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1679182839; bh=TOB8NzOJQZVy9wXQwy2irZUghPdzOZyRJ0vbM+Gp+m8=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=PIsKPHzBimUAiqvd0ccbmvYD8FXpZqVeVT/MJNnBKMCr2IRT8hVZxQ2bp6OBOcA1u e3F06QPTBnYUp+wagOrXkMwMMtvKSrJIwcu7iKBqdQxgRGHZLDnxK98dYjJx+dH5mC k/cM8tbAh1ReegIe2vCy368Lh8Q93e/xvuiU8SanXQbmf4NRaJ+P3GZIRejhUbvST/ oVUr2m1EP2sLLri+PqJ/ubO/VkLo8Sx9uNDOOiDjIk6t62jsNkwVIfDe6FI375OwHA MHCt00STYUYNLU/iyGi8gyeaYdwb1X4Qej//J941JnWNB5NiWfN50bVgbSUIoscaoD w54Ady6U5rq8A== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0ABE4626F0 for ; Sun, 19 Mar 2023 00:40:34 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="m1KoJGm9"; dkim-atps=neutral Received: from mail.ideasonboard.com (cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A2241B6C; Sun, 19 Mar 2023 00:40:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1679182833; bh=TOB8NzOJQZVy9wXQwy2irZUghPdzOZyRJ0vbM+Gp+m8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m1KoJGm9WI3+Jdqhg8wGu8kc0vtLzmcoOPFOZxm1f0+8W2bA+VNU7aHp67JKGO2yA hd1bC0eAGMsyRZldUNibdDLvVsb5RWN6TJq4Kk7upceoXhtTKk3wJKWhqfRBHeI77y LFBcEJCOtH8Jr+hMqxZAxJH9veLoD2/AYCKHpYTA= To: libcamera-devel@lists.libcamera.org Date: Sat, 18 Mar 2023 23:40:10 +0000 Message-Id: <20230318234014.29506-8-dan.scally@ideasonboard.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230318234014.29506-1-dan.scally@ideasonboard.com> References: <20230318234014.29506-1-dan.scally@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 07/11] pipeline: ipu3: Allow raw-only streams in IPU3 pipeline X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Daniel Scally via libcamera-devel From: Daniel Scally Reply-To: Daniel Scally Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Sensors not connected to the Imgu produce raw-only streams. Allow that configuration to proceed in the IPU3 pipeline, but warn about the lack of sensor controls for other sensors. Signed-off-by: Daniel Scally --- src/libcamera/pipeline/ipu3/ipu3.cpp | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index cc7da299..b9228a59 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -232,18 +232,18 @@ CameraConfiguration::Status IPU3CameraConfiguration::validate() return Invalid; } else if (rawCount && !yuvCount) { /* - * Disallow raw-only camera configuration. Currently, ImgU does - * not get configured for raw-only streams and has early return - * in configure(). To support raw-only stream, we do need the IPA - * to get configured since it will setup the sensor controls for - * the capture. + * Currently, ImgU does not get configured for raw-only streams + * and has early return in configure(). To support raw-only stream, + * we do need the IPA to get configured since it will setup the + * sensor controls for the capture. As some sensors _only_ output + * raw streams though we need to allow the configuration to + * continue here. * * \todo Configure the ImgU with internal buffers which will enable * the IPA to get configured for the raw-only camera configuration. */ LOG(IPU3, Debug) - << "Camera configuration cannot support raw-only streams"; - return Invalid; + << "Sensor controls not supported for raw-only stream"; } /*