Patch Detail
Show a patch.
GET /api/patches/18233/?format=api
{ "id": 18233, "url": "https://patchwork.libcamera.org/api/patches/18233/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18233/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230202111252.3366729-5-matthias.fend@emfend.at>", "date": "2023-02-02T11:12:49", "name": "[libcamera-devel,RFC,4/7] libcamera: camera_lens: add method to get controls from subdev", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d2bed29c215d8c6a33c36cef356ec001e266cbed", "submitter": { "id": 134, "url": "https://patchwork.libcamera.org/api/people/134/?format=api", "name": "Matthias Fend", "email": "matthias.fend@emfend.at" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18233/mbox/", "series": [ { "id": 3735, "url": "https://patchwork.libcamera.org/api/series/3735/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3735", "date": "2023-02-02T11:12:45", "name": "add support for more complex optics", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3735/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18233/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18233/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 115E1C329D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 2 Feb 2023 11:13:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5A86D625FD;\n\tThu, 2 Feb 2023 12:13:07 +0100 (CET)", "from lx20.hoststar.hosting (lx20.hoststar.hosting [168.119.41.54])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 36E48625DD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 2 Feb 2023 12:13:04 +0100 (CET)", "from 194-208-208-245.tele.net ([194.208.208.245]:51050\n\thelo=localhost.localdomain)\n\tby lx20.hoststar.hosting with esmtpsa (TLS1.3) tls\n\tTLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93)\n\t(envelope-from <matthias.fend@emfend.at>)\n\tid 1pNXWZ-008Uhs-FL; Thu, 02 Feb 2023 12:13:03 +0100" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675336387;\n\tbh=IJM0sPJVoVgRDUhm/ng2uOPTtuuVzILf0Eq8yO5L6BA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=QcB4OFBtVbpvm3WF0KzeaACIN0UihACaamcdxXe7JdXS0EaKQWj3FYDiQ0/L5jZc2\n\to4HDVK2hJKLzkyVhbowY1Zr1SDasgJwsRiW5/DWl/qKNi/GDsnDugg34NmHdX8vLob\n\t8RKrgFlWl4FcK9LSnrBAF8JktgsfVKr7G7d3WPuEdBCbKtH9dUL3fVaFmihVA3Npb0\n\ttTwOTqhxJuFpcXJRgCkTBU0v2hF7nqq00+DcKFEBi4pjIdBHsqh+71qC/g4BooYkdN\n\tcPL2SQhqn+4jtj9rivnIjEf1aNcKM/KAVu3HV8iaFIWjF9fmjdhfhKrvub3au6qfxc\n\tpMIZAz9bP0ZLw==", "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=emfend.at;\n\ts=mail;\n\th=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:\n\tMessage-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=PSlPvh+Xr3XYBmy9nxyVSa0N9gvuSRvG7V6V0q92yGI=;\n\tb=fGPglgdGHfvN2OBf1MVUJ+YQtQ\n\tmZXSD6mc+2R3LocjVJMEa8hXiFE4RVLp2OmZ0RJJILFZ//fKvu2RGmqlaIw2eC9d3Ub64FLZ6NSHA\n\tqTMbTfWxymVneNsNKc6x7NBpWK8IFiLY/yyhBHTtoHsbBFAOI0KB9BSraF7PaMBFier4=;" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=emfend.at header.i=@emfend.at\n\theader.b=\"fGPglgdG\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 2 Feb 2023 12:12:49 +0100", "Message-Id": "<20230202111252.3366729-5-matthias.fend@emfend.at>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230202111252.3366729-1-matthias.fend@emfend.at>", "References": "<20230202111252.3366729-1-matthias.fend@emfend.at>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Score": "-1.0", "X-Spam-Bar": "-", "X-Spam-Report": "Spam detection software,\n\trunning on the system \"lx20.hoststar.hosting\", \n\thas NOT identified this incoming email as spam. The original\n\tmessage has been attached to this so you can view it or label\n\tsimilar future email. If you have any questions, see\n\tthe administrator of that system for details.\n\tContent preview: Instead of parsing the values in the v4l2 controls\n\tfrom the\n\tIPA and passing them to CameraLens (where they are then converted\n\tback to v4l2 controls),\n\tthe IPA v4l2 controls are reused directly. Signed-off-by:\n\tMatthias Fend <matthias.fend@emfend.at> ---\n\tsrc/libcamera/pipeline/rkisp1/rkisp1.cpp\n\t| 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) \n\tContent analysis details: (-1.0 points, 5.0 required)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP\n\t0.0 TVD_RCVD_IP Message was received from an IP address\n\t0.0 KAM_DMARC_STATUS Test Rule for DKIM or SPF Failure with Strict\n\tAlignment", "Subject": "[libcamera-devel] [RFC PATCH 4/7] libcamera: camera_lens: add\n\tmethod to get controls from subdev", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Matthias Fend via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Matthias Fend <matthias.fend@emfend.at>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This method allows v4l2 controls to be read directly from the underlying\nv4l2 subdevice.\n\nSigned-off-by: Matthias Fend <matthias.fend@emfend.at>\n---\n include/libcamera/internal/camera_lens.h | 1 +\n src/libcamera/camera_lens.cpp | 5 +++++\n 2 files changed, 6 insertions(+)", "diff": "diff --git a/include/libcamera/internal/camera_lens.h b/include/libcamera/internal/camera_lens.h\nindex 66c32a46..f5212ea7 100644\n--- a/include/libcamera/internal/camera_lens.h\n+++ b/include/libcamera/internal/camera_lens.h\n@@ -33,6 +33,7 @@ public:\n \n \tconst ControlInfoMap &controls() const;\n \n+\tControlList getControls(const std::vector<uint32_t> &ids);\n protected:\n \tstd::string logPrefix() const override;\n \ndiff --git a/src/libcamera/camera_lens.cpp b/src/libcamera/camera_lens.cpp\nindex c8fadda5..ddcda232 100644\n--- a/src/libcamera/camera_lens.cpp\n+++ b/src/libcamera/camera_lens.cpp\n@@ -160,4 +160,9 @@ const ControlInfoMap &CameraLens::controls() const\n \treturn subdev_->controls();\n }\n \n+ControlList CameraLens::getControls(const std::vector<uint32_t> &ids)\n+{\n+\treturn subdev_->getControls(ids);\n+}\n+\n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "RFC", "4/7" ] }