From patchwork Thu Feb 2 11:12:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Fend X-Patchwork-Id: 18233 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 115E1C329D for ; Thu, 2 Feb 2023 11:13:09 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5A86D625FD; Thu, 2 Feb 2023 12:13:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1675336387; bh=IJM0sPJVoVgRDUhm/ng2uOPTtuuVzILf0Eq8yO5L6BA=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=QcB4OFBtVbpvm3WF0KzeaACIN0UihACaamcdxXe7JdXS0EaKQWj3FYDiQ0/L5jZc2 o4HDVK2hJKLzkyVhbowY1Zr1SDasgJwsRiW5/DWl/qKNi/GDsnDugg34NmHdX8vLob 8RKrgFlWl4FcK9LSnrBAF8JktgsfVKr7G7d3WPuEdBCbKtH9dUL3fVaFmihVA3Npb0 tTwOTqhxJuFpcXJRgCkTBU0v2hF7nqq00+DcKFEBi4pjIdBHsqh+71qC/g4BooYkdN cPL2SQhqn+4jtj9rivnIjEf1aNcKM/KAVu3HV8iaFIWjF9fmjdhfhKrvub3au6qfxc pMIZAz9bP0ZLw== Received: from lx20.hoststar.hosting (lx20.hoststar.hosting [168.119.41.54]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 36E48625DD for ; Thu, 2 Feb 2023 12:13:04 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=emfend.at header.i=@emfend.at header.b="fGPglgdG"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=emfend.at; s=mail; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=PSlPvh+Xr3XYBmy9nxyVSa0N9gvuSRvG7V6V0q92yGI=; b=fGPglgdGHfvN2OBf1MVUJ+YQtQ mZXSD6mc+2R3LocjVJMEa8hXiFE4RVLp2OmZ0RJJILFZ//fKvu2RGmqlaIw2eC9d3Ub64FLZ6NSHA qTMbTfWxymVneNsNKc6x7NBpWK8IFiLY/yyhBHTtoHsbBFAOI0KB9BSraF7PaMBFier4=; Received: from 194-208-208-245.tele.net ([194.208.208.245]:51050 helo=localhost.localdomain) by lx20.hoststar.hosting with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1pNXWZ-008Uhs-FL; Thu, 02 Feb 2023 12:13:03 +0100 To: libcamera-devel@lists.libcamera.org Date: Thu, 2 Feb 2023 12:12:49 +0100 Message-Id: <20230202111252.3366729-5-matthias.fend@emfend.at> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230202111252.3366729-1-matthias.fend@emfend.at> References: <20230202111252.3366729-1-matthias.fend@emfend.at> MIME-Version: 1.0 X-Spam-Score: -1.0 X-Spam-Bar: - X-Spam-Report: Spam detection software, running on the system "lx20.hoststar.hosting", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Instead of parsing the values in the v4l2 controls from the IPA and passing them to CameraLens (where they are then converted back to v4l2 controls), the IPA v4l2 controls are reused directly. Signed-off-by: Matthias Fend --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) Content analysis details: (-1.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 TVD_RCVD_IP Message was received from an IP address 0.0 KAM_DMARC_STATUS Test Rule for DKIM or SPF Failure with Strict Alignment Subject: [libcamera-devel] [RFC PATCH 4/7] libcamera: camera_lens: add method to get controls from subdev X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Matthias Fend via libcamera-devel From: Matthias Fend Reply-To: Matthias Fend Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This method allows v4l2 controls to be read directly from the underlying v4l2 subdevice. Signed-off-by: Matthias Fend --- include/libcamera/internal/camera_lens.h | 1 + src/libcamera/camera_lens.cpp | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/include/libcamera/internal/camera_lens.h b/include/libcamera/internal/camera_lens.h index 66c32a46..f5212ea7 100644 --- a/include/libcamera/internal/camera_lens.h +++ b/include/libcamera/internal/camera_lens.h @@ -33,6 +33,7 @@ public: const ControlInfoMap &controls() const; + ControlList getControls(const std::vector &ids); protected: std::string logPrefix() const override; diff --git a/src/libcamera/camera_lens.cpp b/src/libcamera/camera_lens.cpp index c8fadda5..ddcda232 100644 --- a/src/libcamera/camera_lens.cpp +++ b/src/libcamera/camera_lens.cpp @@ -160,4 +160,9 @@ const ControlInfoMap &CameraLens::controls() const return subdev_->controls(); } +ControlList CameraLens::getControls(const std::vector &ids) +{ + return subdev_->getControls(ids); +} + } /* namespace libcamera */