Patch Detail
Show a patch.
GET /api/patches/18200/?format=api
{ "id": 18200, "url": "https://patchwork.libcamera.org/api/patches/18200/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18200/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230127154322.29019-1-naush@raspberrypi.com>", "date": "2023-01-27T15:43:07", "name": "[libcamera-devel,v6,00/15] Raspberry Pi: Platform configuration and buffer allocation improvements", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "32c1d291173c638c251d9f97843570c357438b93", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18200/mbox/", "series": [], "comments": "https://patchwork.libcamera.org/api/patches/18200/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18200/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CEC78BDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 Jan 2023 15:43:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2D600625EB;\n\tFri, 27 Jan 2023 16:43:38 +0100 (CET)", "from mail-wm1-x333.google.com (mail-wm1-x333.google.com\n\t[IPv6:2a00:1450:4864:20::333])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2E79D61EF9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Jan 2023 16:43:36 +0100 (CET)", "by mail-wm1-x333.google.com with SMTP id l8so3744730wms.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Jan 2023 07:43:36 -0800 (PST)", "from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\th18-20020a05600c30d200b003c21ba7d7d6sm4549566wmn.44.2023.01.27.07.43.34\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 27 Jan 2023 07:43:35 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1674834218;\n\tbh=Tkh94Ib9vK45TxShaWERDKrslRp6VFn6+LxwhRQYtmA=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=BhvxWU3YwIavxI88fX871JPSlyfkFlH4Dx4AT0ex5kPziRwrJlyDYsv74wJVGlXcz\n\tWm1dCOyO8NyCNgIIgnRzvu6DphY5SJTkGX9zi2Ymo2efkoUwDkek4HNjIsybLEEeRq\n\tit6+LQRiS4RZCMH5u5sd0RdcL+vLR45u1II+sMZ+c/zLbY5JEsfqmBeTj+N6WsM0a+\n\tZR+4fTZ9CruQYE/fzpRaWiaTTzyNPo0O78Elvgnikse1ggech+yxHXslBzlxJBLu6P\n\tyKpE2rj+MUp+/3EzCbTNjdy595gF+0O2mpeP27s0iyLmaV8T1zR1dS36vECax659oe\n\tlyNqFYUJSuUkQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=FxV3XxK2tF1+je++shW2ukOENRtp4RoKr7KmSn6vmt4=;\n\tb=FiIsG7YiE4Nw4VQove8I6w8l4fZfZYs9YbSgqkgojKNfDTW456i8tW9l+dZsFBeI4f\n\tgfn1tSPE33d5cjZOcu123nAhLKWyeouq8F6CvjPIWTaNMXzQcCpWfk2JVZ2ko13zV7Ax\n\tC/ZGdVw7fmqdIgUkT7FyGoanONhPwZTFtQ48zHUGGvritfZ9jRmYXOdfVuJJNKN1mekg\n\tQuMcOuqdOPSxcqszN1TttjR6uOSDJkdwfXmvBrm6hUS0LDW/yT/Z5OEp1zQ9bkOMMPiE\n\tPREbkz2j9D6LEExfPHLCNHK0XMiHT4OPWwPAhGK5jTLuNerlwlxDjFasgSrlL1Rj5Ih6\n\tC0/w==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"FiIsG7Yi\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=FxV3XxK2tF1+je++shW2ukOENRtp4RoKr7KmSn6vmt4=;\n\tb=Rb9D7tKeMLbNYUVzTYUQsnOgFNhBH6FcQOlP/A1o4pulRWuNBAlkG9RSZY7ryWmC2g\n\tjiz3+msPsTXOl5GT4wOemfI4RKP6TpbZTDFCTvV0LhbdRbsuXtVJGCOpoCNn9BuSAc0Y\n\tZOqZbgfab1fMq9COzJRhj8tSfw7aWEXmu51AkWZr8ilfrxOxlAIRc2UMpLa1BgOGyzoW\n\ttk1Ou9eGSCI4SM0S907hCrWAPLa2wFm7eZ+9Nh51K6YnWh8tvsrdd5rtS0yhBnOoL+f9\n\tMEgcbt4uuixLNHY31hyPJxm4t2aoKRfBlkRimYfY+i2K8DlVYS08x1hb7qI+kqptGmuw\n\taBrA==", "X-Gm-Message-State": "AFqh2kqUsllnupEiF7HPJYmQox0hlhabApEWkZ2roIyLV5L8TyQAYlQA\n\tUJuuucFA2Mrv8DfPehSi9J19NlClNiTTyExnxWY=", "X-Google-Smtp-Source": "AMrXdXvesHFKYL5cUjHRcVzj5x+kD9Gv1QzbzrOERo9zCuQ6OUNHLf8TKetc91LZV5mlsRZusCLppg==", "X-Received": "by 2002:a05:600c:4256:b0:3da:2a78:d7a3 with SMTP id\n\tr22-20020a05600c425600b003da2a78d7a3mr38574822wmm.33.1674834215356; \n\tFri, 27 Jan 2023 07:43:35 -0800 (PST)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 27 Jan 2023 15:43:07 +0000", "Message-Id": "<20230127154322.29019-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v6 00/15] Raspberry Pi: Platform\n\tconfiguration and buffer allocation improvements", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Naushir Patuck <naush@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi,\n\nVersion 6 of this series addresses the following:\n\n- Switch the sense of the hint back to how it was in v4. This hint is now called MandatorySteam.\n- Move the MandatorySteam hint validation into Camera::queueRequest.\n- Remove the \"return_newest_frames\" config option. As discussed in the discussion for v5, it's a bit redundant.\n- Added a bit more documentation for the Unicam buffer config options.\n- The biggest changes come in patches 12/15 - 15/15 where I've added multi-stream support to lc-compliance. With that, I've added tests for dual stream captures, optional streams, and use of stream hints.\n\nHopefully I've captured all the changes from the feedback, but if I've missed anything, please do let me know.\n\nOne thing to note - lc-compliance does not run correctly on the Raspberry Pi platform. The reason for this is detailed in [1]. In order to test the lc-compliance app you need to make the following change:\n\nThis is something that we do need to address at some point...\n\nRegards,\nNaush\n\n[1] https://lists.libcamera.org/pipermail/libcamera-devel/2022-December/036136.html\n\nNaushir Patuck (15):\n libcamera: stream: Add stream hints to StreamConfiguration\n libcamera: pipeline: Add a platform configuration file helper\n pipeline: raspberrypi: Add a pipeline config structure\n pipeline: raspberrypi: Reorder startup drop frame initialisation\n pipeline: raspberrypi: Handle MandatoryStream hints for Unicam Image\n libcamera: pipeline: build: Add pipeline_data_dir variable\n pipeline: raspberrypi: Read config parameters from a file\n pipeline: raspberrypi: Handle MandatoryStream hints for ISP Output0\n libcamera: camera: Validate MandatoryStream in queueRequest()\n pipeline: raspberrypi: Add a parameter to disable startup drop frames\n pipeline: raspberrypi: Add minimal memory usage config file\n libcamera: apps: lcc: Make rolesMap global\n libcamera: apps: lcc: Add multi-stream capture test framework\n libcamera: apps: lcc: Add optional stream tests\n libcamera: apps: lcc: Add stream hints test\n\n Documentation/environment_variables.rst | 5 +\n include/libcamera/internal/pipeline_handler.h | 3 +\n include/libcamera/stream.h | 8 +\n src/apps/lc-compliance/capture_test.cpp | 136 ++++++++-\n src/apps/lc-compliance/meson.build | 1 +\n src/apps/lc-compliance/multi_capture.cpp | 288 ++++++++++++++++++\n src/apps/lc-compliance/multi_capture.h | 87 ++++++\n src/libcamera/camera.cpp | 12 +\n src/libcamera/pipeline/meson.build | 3 +\n .../pipeline/raspberrypi/data/example.yaml | 37 +++\n .../pipeline/raspberrypi/data/meson.build | 9 +\n .../raspberrypi/data/minimal_mem.yaml | 37 +++\n .../pipeline/raspberrypi/meson.build | 2 +\n .../pipeline/raspberrypi/raspberrypi.cpp | 190 ++++++++++--\n src/libcamera/pipeline_handler.cpp | 57 ++++\n src/libcamera/stream.cpp | 25 ++\n 16 files changed, 862 insertions(+), 38 deletions(-)\n create mode 100644 src/apps/lc-compliance/multi_capture.cpp\n create mode 100644 src/apps/lc-compliance/multi_capture.h\n create mode 100644 src/libcamera/pipeline/raspberrypi/data/example.yaml\n create mode 100644 src/libcamera/pipeline/raspberrypi/data/meson.build\n create mode 100644 src/libcamera/pipeline/raspberrypi/data/minimal_mem.yaml", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 9920f6bb01a7..656e0f623c44 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -1135,6 +1135,8 @@ void PipelineHandlerRPi::stopDevice(Camera *camera)\n data->bayerQueue_ = {};\n data->embeddedQueue_ = {};\n\n+ data->freeBuffers();\n+\n /* Stop the IPA. */\n data->ipa_->stop();\n\n", "prefixes": [ "libcamera-devel", "v6", "00/15" ] }