[{"id":26379,"web_url":"https://patchwork.libcamera.org/comment/26379/","msgid":"<167508748206.42371.15030853041975636739@Monstersaurus>","date":"2023-01-30T14:04:42","subject":"Re: [libcamera-devel] [PATCH v6 00/15] Raspberry Pi: Platform\n\tconfiguration and buffer allocation improvements","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck via libcamera-devel (2023-01-27 15:43:07)\n> Hi,\n> \n> Version 6 of this series addresses the following:\n> \n> - Switch the sense of the hint back to how it was in v4. This hint is now called MandatorySteam.\n> - Move the MandatorySteam hint validation into Camera::queueRequest.\n> - Remove the \"return_newest_frames\" config option. As discussed in the discussion for v5, it's a bit redundant.\n> - Added a bit more documentation for the Unicam buffer config options.\n> - The biggest changes come in patches 12/15 - 15/15 where I've added multi-stream support to lc-compliance. With that, I've added tests for dual stream captures, optional streams, and use of stream hints.\n> \n> Hopefully I've captured all the changes from the feedback, but if I've missed anything, please do let me know.\n\nSeveral of these patches could already apply, but that's breaking the\nseries apart:\n\nAs I'm aiming to make a release tomorrow - would you prefer to keep this\nwhole series together? or cherry-pick suitable commits (which helps\nreduce this series anyway?)\n\nI think already these could be applied:\n\n [v6,02/15] libcamera: pipeline: Add a platform configuration file helper \n [v6,03/15] pipeline: raspberrypi: Add a pipeline config structure \n [v6,04/15] pipeline: raspberrypi: Reorder startup drop frame initialisation \n ...\n [v6,06/15] libcamera: pipeline: build: Add pipeline_data_dir variable \n [v6,07/15] pipeline: raspberrypi: Read config parameters from a file \n ...\n [v6,10/15] pipeline: raspberrypi: Add a parameter to disable startup drop frames\n\n?\n\n> \n> One thing to note - lc-compliance does not run correctly on the Raspberry Pi platform. The reason for this is detailed in [1]. In order to test the lc-compliance app you need to make the following change:\n> \n\nThis certainly needs some more consideration and whatever we do -\nlc-compliance should be updated (or left) to make sure that the correct\nbehaviour is validated.\n\n\n\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 9920f6bb01a7..656e0f623c44 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1135,6 +1135,8 @@ void PipelineHandlerRPi::stopDevice(Camera *camera)\n> data->bayerQueue_ = {};\n> data->embeddedQueue_ = {};\n> \n> + data->freeBuffers();\n> +\n> /* Stop the IPA. */\n> data->ipa_->stop();\n> \n> This is something that we do need to address at some point...\n> \n> Regards,\n> Naush\n> \n> [1] https://lists.libcamera.org/pipermail/libcamera-devel/2022-December/036136.html\n> \n> Naushir Patuck (15):\n> libcamera: stream: Add stream hints to StreamConfiguration\n> libcamera: pipeline: Add a platform configuration file helper\n> pipeline: raspberrypi: Add a pipeline config structure\n> pipeline: raspberrypi: Reorder startup drop frame initialisation\n> pipeline: raspberrypi: Handle MandatoryStream hints for Unicam Image\n> libcamera: pipeline: build: Add pipeline_data_dir variable\n> pipeline: raspberrypi: Read config parameters from a file\n> pipeline: raspberrypi: Handle MandatoryStream hints for ISP Output0\n> libcamera: camera: Validate MandatoryStream in queueRequest()\n> pipeline: raspberrypi: Add a parameter to disable startup drop frames\n> pipeline: raspberrypi: Add minimal memory usage config file\n> libcamera: apps: lcc: Make rolesMap global\n> libcamera: apps: lcc: Add multi-stream capture test framework\n> libcamera: apps: lcc: Add optional stream tests\n> libcamera: apps: lcc: Add stream hints test\n> \n> Documentation/environment_variables.rst | 5 +\n> include/libcamera/internal/pipeline_handler.h | 3 +\n> include/libcamera/stream.h | 8 +\n> src/apps/lc-compliance/capture_test.cpp | 136 ++++++++-\n> src/apps/lc-compliance/meson.build | 1 +\n> src/apps/lc-compliance/multi_capture.cpp | 288 ++++++++++++++++++\n> src/apps/lc-compliance/multi_capture.h | 87 ++++++\n> src/libcamera/camera.cpp | 12 +\n> src/libcamera/pipeline/meson.build | 3 +\n> .../pipeline/raspberrypi/data/example.yaml | 37 +++\n> .../pipeline/raspberrypi/data/meson.build | 9 +\n> .../raspberrypi/data/minimal_mem.yaml | 37 +++\n> .../pipeline/raspberrypi/meson.build | 2 +\n> .../pipeline/raspberrypi/raspberrypi.cpp | 190 ++++++++++--\n> src/libcamera/pipeline_handler.cpp | 57 ++++\n> src/libcamera/stream.cpp | 25 ++\n> 16 files changed, 862 insertions(+), 38 deletions(-)\n> create mode 100644 src/apps/lc-compliance/multi_capture.cpp\n> create mode 100644 src/apps/lc-compliance/multi_capture.h\n> create mode 100644 src/libcamera/pipeline/raspberrypi/data/example.yaml\n> create mode 100644 src/libcamera/pipeline/raspberrypi/data/meson.build\n> create mode 100644 src/libcamera/pipeline/raspberrypi/data/minimal_mem.yaml\n> \n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A422DBDC71\n\tfor ;\n\tMon, 30 Jan 2023 14:04:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6D5F9625E4;\n\tMon, 30 Jan 2023 15:04:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B6F560482\n\tfor ;\n\tMon, 30 Jan 2023 15:04:45 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AC9DD8B8;\n\tMon, 30 Jan 2023 15:04:44 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675087486;\n\tbh=qYuEZzu5xu0FLVblBgqbjPYAPybX5Wn2BT2v4KYrXnA=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=jVr7YrlLLqIaPWgBuoWA1wsmOQqL1iPcSyx36XFszChSRwyQMb/oRT/4551b0jfI7\n\tS3yQihHzBtohKEdMQi5Zo30uAogDuqLuw7WXBxacXDAYPrtlus4trbYJ21a6KbjLes\n\t3WmFXrcV6WRixjHuPh0YgbY5lVUTbI+iciuLNQuZ3MfKfbAfJdeXvih+k8INZtAk9M\n\tcYTypdH7s4N2Z8bxARzaEUnkgZnlJK7ksQyPGQTOCkBqL+koXq0PUxMcZnzbWj5gsM\n\tWrq5lLQRGlWt5kBHyF6EVFNohD9ap8e437Ll4ciapdgL6DMqDd+y9SWywYK33myPUw\n\tZWDwAD0kXDh7g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1675087484;\n\tbh=qYuEZzu5xu0FLVblBgqbjPYAPybX5Wn2BT2v4KYrXnA=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=tv92i0TPOkhk7i091XUr0mPotdl4J3gFVLQqL7BcBLC/Yln02LcEYk9doLQfRgvTh\n\t05BdKQ3dQVMUm/e3YEpFtKAfDaQYLQ+b/KHw4eWIs0eCd/hqDmUJ8hAR0la6yAcl0A\n\tKoLls4a/B8L5bkKzq3vTIf+oT4I8rfgE/aLpzhOQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"tv92i0TP\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230127154322.29019-1-naush@raspberrypi.com>","References":"<20230127154322.29019-1-naush@raspberrypi.com>","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 30 Jan 2023 14:04:42 +0000","Message-ID":"<167508748206.42371.15030853041975636739@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v6 00/15] Raspberry Pi: Platform\n\tconfiguration and buffer allocation improvements","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":26386,"web_url":"https://patchwork.libcamera.org/comment/26386/","msgid":"","date":"2023-01-31T09:05:43","subject":"Re: [libcamera-devel] [PATCH v6 00/15] Raspberry Pi: Platform\n\tconfiguration and buffer allocation improvements","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Kieran,\n\nOn Mon, 30 Jan 2023 at 14:04, Kieran Bingham\n wrote:\n>\n> Quoting Naushir Patuck via libcamera-devel (2023-01-27 15:43:07)\n> > Hi,\n> >\n> > Version 6 of this series addresses the following:\n> >\n> > - Switch the sense of the hint back to how it was in v4. This hint is now called MandatorySteam.\n> > - Move the MandatorySteam hint validation into Camera::queueRequest.\n> > - Remove the \"return_newest_frames\" config option. As discussed in the discussion for v5, it's a bit redundant.\n> > - Added a bit more documentation for the Unicam buffer config options.\n> > - The biggest changes come in patches 12/15 - 15/15 where I've added multi-stream support to lc-compliance. With that, I've added tests for dual stream captures, optional streams, and use of stream hints.\n> >\n> > Hopefully I've captured all the changes from the feedback, but if I've missed anything, please do let me know.\n>\n> Several of these patches could already apply, but that's breaking the\n> series apart:\n>\n> As I'm aiming to make a release tomorrow - would you prefer to keep this\n> whole series together? or cherry-pick suitable commits (which helps\n> reduce this series anyway?)\n\nSorry to not reply earlier, I'm away from the office this week.\n\nIf you have not yet made the release, I am happy to split up the\nseries and get a few things in earlier.\n\n>\n> I think already these could be applied:\n>\n> [v6,02/15] libcamera: pipeline: Add a platform configuration file helper\n> [v6,03/15] pipeline: raspberrypi: Add a pipeline config structure\n> [v6,04/15] pipeline: raspberrypi: Reorder startup drop frame initialisation\n> ...\n> [v6,06/15] libcamera: pipeline: build: Add pipeline_data_dir variable\n> [v6,07/15] pipeline: raspberrypi: Read config parameters from a file\n> ...\n> [v6,10/15] pipeline: raspberrypi: Add a parameter to disable startup drop frames\n>\n> ?\n>\n> >\n> > One thing to note - lc-compliance does not run correctly on the Raspberry Pi platform. The reason for this is detailed in [1]. In order to test the lc-compliance app you need to make the following change:\n> >\n>\n> This certainly needs some more consideration and whatever we do -\n> lc-compliance should be updated (or left) to make sure that the correct\n> behaviour is validated.\n\nIndeed. I have a \"fix\" for lc-compliance to work with the RPi\npipeline handler correctly, but of course this will (likely) break\nipu3 and rkisp so I cannot check it in.\n\nRegards,\nNaush\n\n>\n>\n>\n> > diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > index 9920f6bb01a7..656e0f623c44 100644\n> > --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > @@ -1135,6 +1135,8 @@ void PipelineHandlerRPi::stopDevice(Camera *camera)\n> > data->bayerQueue_ = {};\n> > data->embeddedQueue_ = {};\n> >\n> > + data->freeBuffers();\n> > +\n> > /* Stop the IPA. */\n> > data->ipa_->stop();\n> >\n> > This is something that we do need to address at some point...\n> >\n> > Regards,\n> > Naush\n> >\n> > [1] https://lists.libcamera.org/pipermail/libcamera-devel/2022-December/036136.html\n> >\n> > Naushir Patuck (15):\n> > libcamera: stream: Add stream hints to StreamConfiguration\n> > libcamera: pipeline: Add a platform configuration file helper\n> > pipeline: raspberrypi: Add a pipeline config structure\n> > pipeline: raspberrypi: Reorder startup drop frame initialisation\n> > pipeline: raspberrypi: Handle MandatoryStream hints for Unicam Image\n> > libcamera: pipeline: build: Add pipeline_data_dir variable\n> > pipeline: raspberrypi: Read config parameters from a file\n> > pipeline: raspberrypi: Handle MandatoryStream hints for ISP Output0\n> > libcamera: camera: Validate MandatoryStream in queueRequest()\n> > pipeline: raspberrypi: Add a parameter to disable startup drop frames\n> > pipeline: raspberrypi: Add minimal memory usage config file\n> > libcamera: apps: lcc: Make rolesMap global\n> > libcamera: apps: lcc: Add multi-stream capture test framework\n> > libcamera: apps: lcc: Add optional stream tests\n> > libcamera: apps: lcc: Add stream hints test\n> >\n> > Documentation/environment_variables.rst | 5 +\n> > include/libcamera/internal/pipeline_handler.h | 3 +\n> > include/libcamera/stream.h | 8 +\n> > src/apps/lc-compliance/capture_test.cpp | 136 ++++++++-\n> > src/apps/lc-compliance/meson.build | 1 +\n> > src/apps/lc-compliance/multi_capture.cpp | 288 ++++++++++++++++++\n> > src/apps/lc-compliance/multi_capture.h | 87 ++++++\n> > src/libcamera/camera.cpp | 12 +\n> > src/libcamera/pipeline/meson.build | 3 +\n> > .../pipeline/raspberrypi/data/example.yaml | 37 +++\n> > .../pipeline/raspberrypi/data/meson.build | 9 +\n> > .../raspberrypi/data/minimal_mem.yaml | 37 +++\n> > .../pipeline/raspberrypi/meson.build | 2 +\n> > .../pipeline/raspberrypi/raspberrypi.cpp | 190 ++++++++++--\n> > src/libcamera/pipeline_handler.cpp | 57 ++++\n> > src/libcamera/stream.cpp | 25 ++\n> > 16 files changed, 862 insertions(+), 38 deletions(-)\n> > create mode 100644 src/apps/lc-compliance/multi_capture.cpp\n> > create mode 100644 src/apps/lc-compliance/multi_capture.h\n> > create mode 100644 src/libcamera/pipeline/raspberrypi/data/example.yaml\n> > create mode 100644 src/libcamera/pipeline/raspberrypi/data/meson.build\n> > create mode 100644 src/libcamera/pipeline/raspberrypi/data/minimal_mem.yaml\n> >\n> > --\n> > 2.25.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6A3B1C323E\n\tfor ;\n\tTue, 31 Jan 2023 09:06:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A4682625E4;\n\tTue, 31 Jan 2023 10:06:01 +0100 (CET)","from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com\n\t[IPv6:2607:f8b0:4864:20::112f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C02B3603BF\n\tfor ;\n\tTue, 31 Jan 2023 10:05:59 +0100 (CET)","by mail-yw1-x112f.google.com with SMTP id\n\t00721157ae682-5063029246dso194581407b3.6\n\tfor ;\n\tTue, 31 Jan 2023 01:05:59 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1675155961;\n\tbh=sWiZsylCWXEh0D8s8R8yjvhzoOVf9+6BhekA+xZczyk=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=PSDwxRHK7mNPEaMZLdXLDLW9LtN6v5T00043bvN/kOzBvKlnwl4yIP51m2c0qmY/C\n\tOsB5T7mWxPvLNFpHQFHGF1C/lG4n1+7dwX1u665UB81wn7VWZn+JxH3Vd3LfXSzLvO\n\tDFb1leobOGL7pGIoAXTnr6xTRa/e0Fpt55YmoPoiWAUxO2aPqANYlRmY+XPErE5Za6\n\tODGPGpXT1T95Dr7QBKQJl5HKP88iPRmjzTyfO33xkFUYSl2r2oG8faaiF0EH0W+1GX\n\tPXz8xTMqf8m53FZE8L4Dx0gtJzCz3LoDOKqg7wriEtI7kbB7nvmNoN/XJNk+v9v7xC\n\tEkmnsdxjR7QMg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=QlKewIImJUTucKHzhMrr/XA1lOE7Itd9xpCVot7+i8M=;\n\tb=S+03M76my45eRo9qk7KhNfPplhPfOetPBTSIX6EGCqqEzqnBuqV54KbvjAxoSCjIE/\n\tOl2pPe8BQt8bXHu80vFCFmqU1ptPfObMuCjcXkBS9m2v25VwObDSG0UFEYVpgvKB+iyl\n\t/Yx46rJGf+R5swhueiFVWNU/iehaD7y3YMxrE0FV9bgqWUK3cBPxp8K+zaOEg+lgxNVB\n\tocRwrSNRU6ze5LwcsxY/aAUZofoR6a2n3kjjejvGGqZjY5LrhYwRi1YD/rCCGbgrot1M\n\tpdJWOJet2yCC4PQjktjTipRNlPpk3raZWRstuKqDvXniZ1mn83dlZjE4Vj0uPCMa6N5y\n\te/Sw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"S+03M76m\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=QlKewIImJUTucKHzhMrr/XA1lOE7Itd9xpCVot7+i8M=;\n\tb=PL24YZ0+v/yYZezZvsSVIv6nITyVjD/f9rtfUUqvFx2r93TXRH21ml1CZwbpiNrmKz\n\tls4lhCatelnstlSGon52DeNZ5FyG4O/YNtphqd9QrJx8AJPE1e/ZC9M+HOXbVsOSVZrL\n\tQzytJwTVqwcaXnEAIeUOc0hu0gE4+QFfbxN/OBfYthjuDujs/ydoIiH8wDw2Z+8CmwYA\n\tcmCyH9qH3xUJoTnfJOVi5fECG1SNt+C6YD+N/bq+MR5232fVrKWXTPwAS/YoGzF6SjvT\n\tnwcsDntafjL2oluubR2p7KuJLNerQXTIWtSrzo3IcEa3/WJPFb/zkyrTcNnXqbXruGEz\n\tieZQ==","X-Gm-Message-State":"AO0yUKWvHtf+PVx77UIUFQXVUpPyPzqJ2rlcs0FxhCOoSiwHYgDRfIJi\n\tqnmCbtHd617kIeBcQp+4sWhe+ZDU9/MSStItzvWnm2Bhm5YacaxHcTU=","X-Google-Smtp-Source":"AK7set8f9gHup02GTmITBKEcyHSX3RjUKqnoS/oyWWsKot7a2lbOcQkL/JXVLWFCvV367ZxUW6Hexe0bba+vUjFrQP0=","X-Received":"by 2002:a81:1912:0:b0:50f:6969:abb7 with SMTP id\n\t18-20020a811912000000b0050f6969abb7mr1451594ywz.20.1675155958512;\n\tTue, 31 Jan 2023 01:05:58 -0800 (PST)","MIME-Version":"1.0","References":"<20230127154322.29019-1-naush@raspberrypi.com>\n\t<167508748206.42371.15030853041975636739@Monstersaurus>","In-Reply-To":"<167508748206.42371.15030853041975636739@Monstersaurus>","Date":"Tue, 31 Jan 2023 09:05:43 +0000","Message-ID":"","To":"Kieran Bingham ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v6 00/15] Raspberry Pi: Platform\n\tconfiguration and buffer allocation improvements","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]