Patch Detail
Show a patch.
GET /api/patches/18041/?format=api
{ "id": 18041, "url": "https://patchwork.libcamera.org/api/patches/18041/?format=api", "web_url": "https://patchwork.libcamera.org/patch/18041/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<Y6Iw+5Brkzx5WFBf@duo.ucw.cz>", "date": "2022-12-20T22:02:35", "name": "[libcamera-devel,PATCHv2] Simple typo fixes", "commit_ref": "21a82ed8a5153e11a0f6eab724c8819599b4e758", "pull_url": null, "state": "accepted", "archived": false, "hash": "a4e99203684f199ec84e9e46c1d9fb2353760d0d", "submitter": { "id": 49, "url": "https://patchwork.libcamera.org/api/people/49/?format=api", "name": "Pavel Machek", "email": "pavel@ucw.cz" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/18041/mbox/", "series": [ { "id": 3680, "url": "https://patchwork.libcamera.org/api/series/3680/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3680", "date": "2022-12-20T22:02:35", "name": "[libcamera-devel,PATCHv2] Simple typo fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3680/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/18041/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/18041/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8BCF4C3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Dec 2022 22:02:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 06B2E633A7;\n\tTue, 20 Dec 2022 23:02:39 +0100 (CET)", "from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BDF8C63398\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Dec 2022 23:02:36 +0100 (CET)", "by jabberwock.ucw.cz (Postfix, from userid 1017)\n\tid 368C81C09F9; Tue, 20 Dec 2022 23:02:36 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1671573759;\n\tbh=rv32RlORotFOlQ5pKMbq62fJQ0G9vAyRf4AbxJXHx1U=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=YrWkfQLfsXXyshoXAI3fTYfmwX1NzDPtg0Wmb7WluvJuyNkzclhtsURvIwLnyPXRu\n\tkLE6H4MrGav6VJN/zYmoq9sGjxyhorvIu6i06DjGgqA3vR96Erw4bhBuI/4bn4sbon\n\t7UvB8zrxxa60eTMd2M3/sGa7KkVWDoU/Cv5G4nxoDHzocvwPOnJrID+0Xx68SbCECO\n\tpKyQDUHjLYYjReAi8k2R7SL/zbmzrqoeqafCojq/NXp2JJsQO6THHcwGJr8kjmxf+C\n\tslb0pCtvhR5+f4xauJn2nTg8IsVm819V65T14bnQTi0W99Z55zrEXJ7qFlP0KUuX9Y\n\ta/vHJ7ALvCiFA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1;\n\tt=1671573756;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=90G3rt4cJR1CRNEPnwXSmwpyJ4BaALgOBcufxvQlMlw=;\n\tb=MJNC4xmxTu4WfDVTq1yqfQeTzmUy1cs+XfMjD2XyhhmHd2NGErfIMxsioTPrA4npQUET0O\n\txtK9YF/KtHl/6m4E8sQ3J4zk46PKZi3w7y/hsj7IktEbr5Zuo5NgnTwpVoxeA3Akm/Kehn\n\tnYSWutMz0XhOXBO8ESxif8kool9jCmo=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ucw.cz header.i=@ucw.cz\n\theader.b=\"MJNC4xmx\"; dkim-atps=neutral", "Date": "Tue, 20 Dec 2022 23:02:35 +0100", "To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Message-ID": "<Y6Iw+5Brkzx5WFBf@duo.ucw.cz>", "References": "<Y5TzDeXoEPerowXI@duo.ucw.cz>\n\t<Y5T0UBGDjn09BUDI@pendragon.ideasonboard.com>\n\t<Y5T5Npc745uMeFAK@pendragon.ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"Wm45HXAP6gEAlQuZ\"", "Content-Disposition": "inline", "In-Reply-To": "<Y5T5Npc745uMeFAK@pendragon.ideasonboard.com>", "Subject": "[libcamera-devel] [PATCHv2] Simple typo fixes", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Pavel Machek via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Pavel Machek <pavel@ucw.cz>", "Cc": "libcamera-devel@lists.libcamera.org", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi!\n\nDuring reading the code, I found some typos that could be fixed.\n\nSigned-off-by: Pavel Machek <pavel@ucw.cz>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n--\nv2: rebased to today's tree.\n\ncommit f214f8fe259b485af926bb6299d07fc17f1272fc\nAuthor: Pavel Machek <pavel@ucw.cz>\nDate: Fri Dec 9 18:43:20 2022 +0000\n\n cleanup: Fix typos.", "diff": "diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\nindex 9256bbba..d5fabaf1 100644\n--- a/src/ipa/vimc/vimc.cpp\n+++ b/src/ipa/vimc/vimc.cpp\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2019, Google Inc.\n *\n- * ipa_vimc.cpp - Vimc Image Processing Algorithm module\n+ * vimc.cpp - Vimc Image Processing Algorithm module\n */\n #include <libcamera/ipa/vimc_ipa_interface.h>\n \ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex eb9ad65c..c27b3ef9 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -220,7 +220,7 @@ RkISP1FrameInfo *RkISP1Frames::create(const RkISP1CameraData *data, Request *req\n \t\t}\n \n \t\tif (pipe_->availableStatBuffers_.empty()) {\n-\t\t\tLOG(RkISP1, Error) << \"Statisitc buffer underrun\";\n+\t\t\tLOG(RkISP1, Error) << \"Statistic buffer underrun\";\n \t\t\treturn nullptr;\n \t\t}\n \n@@ -340,7 +340,7 @@ int RkISP1CameraData::loadIPA(unsigned int hwRevision)\n \n \t/*\n \t * The API tuning file is made from the sensor name unless the\n-\t * environment variable overrides it. If\n+\t * environment variable overrides it.\n \t */\n \tstd::string ipaTuningFile;\n \tchar const *configFromEnv = utils::secure_getenv(\"LIBCAMERA_RKISP1_TUNING_FILE\");\n", "prefixes": [ "libcamera-devel", "PATCHv2" ] }