| Message ID | Y6Iw+5Brkzx5WFBf@duo.ucw.cz |
|---|---|
| State | Accepted |
| Commit | 21a82ed8a5153e11a0f6eab724c8819599b4e758 |
| Headers | show |
| Series |
|
| Related | show |
Hi Pavel, How are you sending the patch to the list? It's malformed so it isn't being picked up as a patch by the patchwork tools. https://patchwork.libcamera.org/patch/18041/ Are you using git-send-email ? https://git-send-email.io/ helps with the configuration of that if you are not. -- Kieran Quoting Pavel Machek via libcamera-devel (2022-12-20 22:02:35) > Hi! > > During reading the code, I found some typos that could be fixed. > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > -- > v2: rebased to today's tree. > > commit f214f8fe259b485af926bb6299d07fc17f1272fc > Author: Pavel Machek <pavel@ucw.cz> > Date: Fri Dec 9 18:43:20 2022 +0000 > > cleanup: Fix typos. > > diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp > index 9256bbba..d5fabaf1 100644 > --- a/src/ipa/vimc/vimc.cpp > +++ b/src/ipa/vimc/vimc.cpp > @@ -2,7 +2,7 @@ > /* > * Copyright (C) 2019, Google Inc. > * > - * ipa_vimc.cpp - Vimc Image Processing Algorithm module > + * vimc.cpp - Vimc Image Processing Algorithm module > */ > #include <libcamera/ipa/vimc_ipa_interface.h> > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > index eb9ad65c..c27b3ef9 100644 > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > @@ -220,7 +220,7 @@ RkISP1FrameInfo *RkISP1Frames::create(const RkISP1CameraData *data, Request *req > } > > if (pipe_->availableStatBuffers_.empty()) { > - LOG(RkISP1, Error) << "Statisitc buffer underrun"; > + LOG(RkISP1, Error) << "Statistic buffer underrun"; > return nullptr; > } > > @@ -340,7 +340,7 @@ int RkISP1CameraData::loadIPA(unsigned int hwRevision) > > /* > * The API tuning file is made from the sensor name unless the > - * environment variable overrides it. If > + * environment variable overrides it. > */ > std::string ipaTuningFile; > char const *configFromEnv = utils::secure_getenv("LIBCAMERA_RKISP1_TUNING_FILE"); > > -- > People of Russia, stop Putin before his war on Ukraine escalates.
Quoting Kieran Bingham (2022-12-21 13:03:45) > Hi Pavel, > > How are you sending the patch to the list? It's malformed so it isn't > being picked up as a patch by the patchwork tools. Or rather - it isn't being correctly picked up as a patch - because it's mixed between E-Mail content and patch content. Note how when applied, it has this 'email' content in the patch that shouldn't be there. - https://git.uk.ideasonboard.com/kbingham/libcamera/commit/40bb9471e39362591f9e57318f5f7bb63d7fa37c -- Kieran > > https://patchwork.libcamera.org/patch/18041/ > > Are you using git-send-email ? https://git-send-email.io/ helps with the > configuration of that if you are not. > > -- > Kieran > > Quoting Pavel Machek via libcamera-devel (2022-12-20 22:02:35) > > Hi! > > > > During reading the code, I found some typos that could be fixed. > > > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > -- > > v2: rebased to today's tree. > > > > commit f214f8fe259b485af926bb6299d07fc17f1272fc > > Author: Pavel Machek <pavel@ucw.cz> > > Date: Fri Dec 9 18:43:20 2022 +0000 > > > > cleanup: Fix typos. > > > > diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp > > index 9256bbba..d5fabaf1 100644 > > --- a/src/ipa/vimc/vimc.cpp > > +++ b/src/ipa/vimc/vimc.cpp > > @@ -2,7 +2,7 @@ > > /* > > * Copyright (C) 2019, Google Inc. > > * > > - * ipa_vimc.cpp - Vimc Image Processing Algorithm module > > + * vimc.cpp - Vimc Image Processing Algorithm module > > */ > > #include <libcamera/ipa/vimc_ipa_interface.h> > > > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > > index eb9ad65c..c27b3ef9 100644 > > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp > > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > > @@ -220,7 +220,7 @@ RkISP1FrameInfo *RkISP1Frames::create(const RkISP1CameraData *data, Request *req > > } > > > > if (pipe_->availableStatBuffers_.empty()) { > > - LOG(RkISP1, Error) << "Statisitc buffer underrun"; > > + LOG(RkISP1, Error) << "Statistic buffer underrun"; > > return nullptr; > > } > > > > @@ -340,7 +340,7 @@ int RkISP1CameraData::loadIPA(unsigned int hwRevision) > > > > /* > > * The API tuning file is made from the sensor name unless the > > - * environment variable overrides it. If > > + * environment variable overrides it. > > */ > > std::string ipaTuningFile; > > char const *configFromEnv = utils::secure_getenv("LIBCAMERA_RKISP1_TUNING_FILE"); > > > > -- > > People of Russia, stop Putin before his war on Ukraine escalates.
On Wed 2022-12-21 13:07:29, Kieran Bingham wrote: > Quoting Kieran Bingham (2022-12-21 13:03:45) > > Hi Pavel, > > > > How are you sending the patch to the list? It's malformed so it isn't > > being picked up as a patch by the patchwork tools. > > Or rather - it isn't being correctly picked up as a patch - because it's > mixed between E-Mail content and patch content. > > Note how when applied, it has this 'email' content in the patch that > shouldn't be there. > > - https://git.uk.ideasonboard.com/kbingham/libcamera/commit/40bb9471e39362591f9e57318f5f7bb63d7fa37c Can you fix it with git commit --amend, please. And I'll try to do better next time. Thanks, Pavel
Hi Pavel, On Wed, Dec 21, 2022 at 02:24:58PM +0100, Pavel Machek wrote: > On Wed 2022-12-21 13:07:29, Kieran Bingham wrote: > > Quoting Kieran Bingham (2022-12-21 13:03:45) > > > Hi Pavel, > > > > > > How are you sending the patch to the list? It's malformed so it isn't > > > being picked up as a patch by the patchwork tools. > > > > Or rather - it isn't being correctly picked up as a patch - because it's > > mixed between E-Mail content and patch content. > > > > Note how when applied, it has this 'email' content in the patch that > > shouldn't be there. > > > > - > https://git.uk.ideasonboard.com/kbingham/libcamera/commit/40bb9471e39362591f9e57318f5f7bb63d7fa37c > > Can you fix it with git commit --amend, please. And I'll try to do > better next time. I've replaced the commit message with libcamera: Simple typo fixes Fix various typos in the code base. Signed-off-by: Pavel Machek <pavel@ucw.cz> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> I will push the patch.
diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp index 9256bbba..d5fabaf1 100644 --- a/src/ipa/vimc/vimc.cpp +++ b/src/ipa/vimc/vimc.cpp @@ -2,7 +2,7 @@ /* * Copyright (C) 2019, Google Inc. * - * ipa_vimc.cpp - Vimc Image Processing Algorithm module + * vimc.cpp - Vimc Image Processing Algorithm module */ #include <libcamera/ipa/vimc_ipa_interface.h> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index eb9ad65c..c27b3ef9 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -220,7 +220,7 @@ RkISP1FrameInfo *RkISP1Frames::create(const RkISP1CameraData *data, Request *req } if (pipe_->availableStatBuffers_.empty()) { - LOG(RkISP1, Error) << "Statisitc buffer underrun"; + LOG(RkISP1, Error) << "Statistic buffer underrun"; return nullptr; } @@ -340,7 +340,7 @@ int RkISP1CameraData::loadIPA(unsigned int hwRevision) /* * The API tuning file is made from the sensor name unless the - * environment variable overrides it. If + * environment variable overrides it. */ std::string ipaTuningFile; char const *configFromEnv = utils::secure_getenv("LIBCAMERA_RKISP1_TUNING_FILE");