Patch Detail
Show a patch.
GET /api/patches/17987/?format=api
{ "id": 17987, "url": "https://patchwork.libcamera.org/api/patches/17987/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17987/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221213091558.621950-5-paul.elder@ideasonboard.com>", "date": "2022-12-13T09:15:55", "name": "[libcamera-devel,v2,4/7] tracepoints: request: Add flags to request_reuse tracepoint", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2f76bcad64eb3547446b721bcdc8af783a1417b3", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17987/mbox/", "series": [ { "id": 3668, "url": "https://patchwork.libcamera.org/api/series/3668/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3668", "date": "2022-12-13T09:15:51", "name": "tracepoints: request: Improve request tracepoints", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3668/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17987/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17987/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 86060BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Dec 2022 09:16:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2FAF563370;\n\tTue, 13 Dec 2022 10:16:21 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C87946336B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Dec 2022 10:16:17 +0100 (CET)", "from pyrite.tail37cf.ts.net (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 621637C5;\n\tTue, 13 Dec 2022 10:16:16 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670922981;\n\tbh=9HxgRXXTRU6iVRfwvCV88S566SAWuWSskXAEAD5+FM0=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=gbxkmra/ITR9m+mjv9D60OTSww2Ir/338v3c39GXrzMzTMNeZW9Bu/i+sblbeO9O+\n\tFV/KndrElzBb7a9BB/JVKsbAWy5kr1yNo1AIN+7Sdobi0ROFU1g+b6J1vrCMFcU2I8\n\tfeXaOZM2FvmzzvD5hl5UsvbYM2So1x/K5VGFn2nuOPV+JWiAJ+YwbJ7O6lAkJuC2V+\n\tr/bK2qsQsdgcbByb5KABLWQgciNCPphklQygGyTpNA2j0161xXiznNbJnBjR3qKgka\n\tSyUn0g+EoTEOLD73ttqtWPhapBHKYvzvUkXE2MyXAfcE4oi7DG0GxWQEfXCyHiOPrb\n\t6ALdKUNiFXs3A==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1670922977;\n\tbh=9HxgRXXTRU6iVRfwvCV88S566SAWuWSskXAEAD5+FM0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=mLQ4E4v2PawjfibhD/sNiiVX5Goe9u27dIO1EZ8D3lerbR8VS5mbyU5re5shNQF3M\n\tsxhDY9TBNv94fbTaeVcWma6futYqN9Hjp/pxoM/0+SKrswunPOhQZs+9qHXSJjmpRI\n\tHiPApkEcBhoHckCUVihWPTuw6fF8sloO9QnOeylw=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"mLQ4E4v2\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 13 Dec 2022 18:15:55 +0900", "Message-Id": "<20221213091558.621950-5-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20221213091558.621950-1-paul.elder@ideasonboard.com>", "References": "<20221213091558.621950-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 4/7] tracepoints: request: Add flags to\n\trequest_reuse tracepoint", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Paul Elder <paul.elder@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add flags to the fields of the tracepoint event request_reuse. This\ncauses it to be no longer able to use the event class, which is why it\nhas to list the fields again.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nNew in v2\n---\n .../libcamera/internal/tracepoints/request.tp | 24 ++++++++++++-------\n src/libcamera/request.cpp | 2 +-\n 2 files changed, 16 insertions(+), 10 deletions(-)", "diff": "diff --git a/include/libcamera/internal/tracepoints/request.tp b/include/libcamera/internal/tracepoints/request.tp\nindex e0ac45ac..c1623586 100644\n--- a/include/libcamera/internal/tracepoints/request.tp\n+++ b/include/libcamera/internal/tracepoints/request.tp\n@@ -55,15 +55,6 @@ TRACEPOINT_EVENT_INSTANCE(\n \t)\n )\n \n-TRACEPOINT_EVENT_INSTANCE(\n-\tlibcamera,\n-\trequest,\n-\trequest_reuse,\n-\tTP_ARGS(\n-\t\tlibcamera::Request *, req\n-\t)\n-)\n-\n TRACEPOINT_EVENT_INSTANCE(\n \tlibcamera,\n \trequest,\n@@ -119,3 +110,18 @@ TRACEPOINT_EVENT_INSTANCE(\n \t\tlibcamera::FrameBuffer *, buf\n \t)\n )\n+\n+TRACEPOINT_EVENT(\n+\tlibcamera,\n+\trequest_reuse,\n+\tTP_ARGS(\n+\t\tlibcamera::Request *, req,\n+\t\tenum libcamera::Request::ReuseFlag, flags\n+\t),\n+\tTP_FIELDS(\n+\t\tctf_integer_hex(uintptr_t, request, reinterpret_cast<uintptr_t>(req))\n+\t\tctf_integer(uint64_t, cookie, req->cookie())\n+\t\tctf_enum(libcamera, request_status, uint32_t, status, req->status())\n+\t\tctf_integer_hex(uint32_t, flags, static_cast<uint32_t>(flags))\n+\t)\n+)\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 226c26b7..5a127f06 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -382,7 +382,7 @@ Request::~Request()\n */\n void Request::reuse(ReuseFlag flags)\n {\n-\tLIBCAMERA_TRACEPOINT(request_reuse, this);\n+\tLIBCAMERA_TRACEPOINT(request_reuse, this, flags);\n \n \t_d()->reset();\n \n", "prefixes": [ "libcamera-devel", "v2", "4/7" ] }