Patch Detail
Show a patch.
GET /api/patches/17961/?format=api
{ "id": 17961, "url": "https://patchwork.libcamera.org/api/patches/17961/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17961/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221209081937.598303-3-paul.elder@ideasonboard.com>", "date": "2022-12-09T08:19:35", "name": "[libcamera-devel,2/4] tracepoints: request: Add event class for request and buffer", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3d81ae2aae39c7baef5f44a7e3684c720e62334e", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17961/mbox/", "series": [ { "id": 3662, "url": "https://patchwork.libcamera.org/api/series/3662/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3662", "date": "2022-12-09T08:19:33", "name": "tracepoints: request: Improve request tracepoints", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3662/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17961/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17961/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 75658C3284\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 9 Dec 2022 08:20:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CDB816334A;\n\tFri, 9 Dec 2022 09:20:01 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7848D6334B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 9 Dec 2022 09:19:59 +0100 (CET)", "from pyrite.tail37cf.ts.net (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1DE80480;\n\tFri, 9 Dec 2022 09:19:57 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670574001;\n\tbh=4sZpb9JY4wUafyIosdD0krk2mfwlOGMSoX7LZqoahP8=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=mJ/x+AjF0dv++CHfSgKAcdVHW/3M+5xsU2K/X73+ThKFKExejk57RkuhqHh+Cs6PA\n\tcqPFlZV6xhK/tLZ/QpM/+/4LJWv26Vzt4Zqb2uwJKYKvHXp366M+ECb1k/Du+hkNAN\n\t2VUFebDCXT1obKtAlrNVuuolKfQSdMI45C8PilYY50KO5iUP9+96xDlGF/XkHzo792\n\tT+si+nVqt38QMyS2t3tgd2IeJqcAmLaiTGZY3YK4zmNArmtlcvJrDy2XzO6TpQS76+\n\t8MXMGsy8S452tXpuBPjMHtV1ff2CiimSFhG1LfUMye3L6YZ7bqem+bPb2DFaFTs2kp\n\tFbr2QB8w2BOeQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1670573999;\n\tbh=4sZpb9JY4wUafyIosdD0krk2mfwlOGMSoX7LZqoahP8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=q8EBBlZt8OGzEdi6LqL4AAhmiqfI4T/khO6hxwYNBOw2k3+vY8nZM4qWqvJuD8pPq\n\t+azddJjFfBBM9EhKujfIq8MwHQRjHUEX5+MiJh+pRgmtEKEkPCwdjiG8VzASEoL0bq\n\tpGYyD+Keou2skJSUo952Q2ylrANGsbm7DR+m0UDo=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"q8EBBlZt\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 9 Dec 2022 17:19:35 +0900", "Message-Id": "<20221209081937.598303-3-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20221209081937.598303-1-paul.elder@ideasonboard.com>", "References": "<20221209081937.598303-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/4] tracepoints: request: Add event class\n\tfor request and buffer", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Paul Elder <paul.elder@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Currently there is one tracepoint event request_complete_buffer that\noutputs information on both the request and its buffer. We want to add\nanother event for add_buffer. Add an event class to cover this.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n .../libcamera/internal/tracepoints/request.tp | 26 +++++++++++++------\n 1 file changed, 18 insertions(+), 8 deletions(-)", "diff": "diff --git a/include/libcamera/internal/tracepoints/request.tp b/include/libcamera/internal/tracepoints/request.tp\nindex 491c7705..8e7cab5e 100644\n--- a/include/libcamera/internal/tracepoints/request.tp\n+++ b/include/libcamera/internal/tracepoints/request.tp\n@@ -23,6 +23,22 @@ TRACEPOINT_EVENT_CLASS(\n \t)\n )\n \n+TRACEPOINT_EVENT_CLASS(\n+\tlibcamera,\n+\trequest_with_buffer,\n+\tTP_ARGS(\n+\t\tlibcamera::Request::Private *, req,\n+\t\tlibcamera::FrameBuffer *, buf\n+\t),\n+\tTP_FIELDS(\n+\t\tctf_integer_hex(uintptr_t, request, reinterpret_cast<uintptr_t>(req))\n+\t\tctf_integer(uint64_t, cookie, req->_o<libcamera::Request>()->cookie())\n+\t\tctf_integer(int, status, req->_o<libcamera::Request>()->status())\n+\t\tctf_integer_hex(uintptr_t, buffer, reinterpret_cast<uintptr_t>(buf))\n+\t\tctf_enum(libcamera, buffer_status, uint32_t, buf_status, buf->metadata().status)\n+\t)\n+)\n+\n TRACEPOINT_EVENT(\n \tlibcamera,\n \trequest_construct,\n@@ -92,18 +108,12 @@ TRACEPOINT_EVENT_INSTANCE(\n \t)\n )\n \n-TRACEPOINT_EVENT(\n+TRACEPOINT_EVENT_INSTANCE(\n \tlibcamera,\n+\trequest_with_buffer,\n \trequest_complete_buffer,\n \tTP_ARGS(\n \t\tlibcamera::Request::Private *, req,\n \t\tlibcamera::FrameBuffer *, buf\n-\t),\n-\tTP_FIELDS(\n-\t\tctf_integer_hex(uintptr_t, request, reinterpret_cast<uintptr_t>(req))\n-\t\tctf_integer(uint64_t, cookie, req->_o<libcamera::Request>()->cookie())\n-\t\tctf_integer(int, status, req->_o<libcamera::Request>()->status())\n-\t\tctf_integer_hex(uintptr_t, buffer, reinterpret_cast<uintptr_t>(buf))\n-\t\tctf_enum(libcamera, buffer_status, uint32_t, buf_status, buf->metadata().status)\n \t)\n )\n", "prefixes": [ "libcamera-devel", "2/4" ] }