Patch Detail
Show a patch.
GET /api/patches/17884/?format=api
{ "id": 17884, "url": "https://patchwork.libcamera.org/api/patches/17884/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17884/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221124113849.2193579-6-paul.elder@ideasonboard.com>", "date": "2022-11-24T11:38:48", "name": "[libcamera-devel,5/6] utils: libtuning: parsers: raspberrypi: Ignore the plot config parameter", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b920c1aab1a7469b3aefec9013eb7ea0b347a31d", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17884/mbox/", "series": [ { "id": 3637, "url": "https://patchwork.libcamera.org/api/series/3637/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3637", "date": "2022-11-24T11:38:43", "name": "utils: tuning: Add per-module debugging", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3637/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17884/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17884/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BC984BE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 24 Nov 2022 11:39:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8BF586331C;\n\tThu, 24 Nov 2022 12:39:10 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B263632EA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 24 Nov 2022 12:39:08 +0100 (CET)", "from pyrite.tail37cf.ts.net (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 42B95496;\n\tThu, 24 Nov 2022 12:39:07 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669289950;\n\tbh=CRnj4q1I+7B67SEymdsRPb4hXQSqWhGPzt14ZSsaONc=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=bpKQkRQtagIV66VmYgvliFcr2EL1lXhjb+5A2QJ2gehHgF6VzEHfbYofh5ElYIy8/\n\t7cP65HIeHNzXtvmGFNSHMqJtAb4BNcfvhTXw3fzTDuXQR9m+n81Wk64H5YGscAXZ61\n\tP2AlyN67tI2BAUwHROdp17lUdxE5jFpinHT5POP14u3AdINFNWg+zM5LoSaadEEB7a\n\tNp+Cs42/gXO8ofSTejxEhC9a1bvYNYdLG+ed9UxAeYO0+lxpmDCTXsdvafjXPhtFrE\n\toHV1DlDcX/jD35GO4mqxbxO0wvSXGT6JuTI5sqYF5huxoKwOtwWeeTTCe1/6efd0bn\n\tRWvLE6Wd6JoqQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1669289948;\n\tbh=CRnj4q1I+7B67SEymdsRPb4hXQSqWhGPzt14ZSsaONc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=uDkm64Gt7Ge9P0V46vpoLjkZbBGgQwjSJoT0wAqamX6KF5WztrC4LBQJTfCElRX3d\n\tJzQ/E3Dt1YD6Xscf14zwrEz7bfNnnhV/5SUwOuJ6KOKpGcnROhOS9rwlAI4TLEYoCW\n\tioXC4k2tKrMvaI1tt2n1D6Jo7JJOnu5LWgHEO0Lk=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"uDkm64Gt\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 24 Nov 2022 20:38:48 +0900", "Message-Id": "<20221124113849.2193579-6-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20221124113849.2193579-1-paul.elder@ideasonboard.com>", "References": "<20221124113849.2193579-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 5/6] utils: libtuning: parsers:\n\traspberrypi: Ignore the plot config parameter", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Paul Elder <paul.elder@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Ignore the plot config parameter that is used in the Raspberry Pi CTT\ntuning configuration file, as it conflicts with the debug parameter that\nwill be provided in the command line arguments.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n utils/tuning/libtuning/parsers/raspberrypi_parser.py | 10 +++-------\n 1 file changed, 3 insertions(+), 7 deletions(-)", "diff": "diff --git a/utils/tuning/libtuning/parsers/raspberrypi_parser.py b/utils/tuning/libtuning/parsers/raspberrypi_parser.py\nindex d26586ba..dab50440 100644\n--- a/utils/tuning/libtuning/parsers/raspberrypi_parser.py\n+++ b/utils/tuning/libtuning/parsers/raspberrypi_parser.py\n@@ -54,13 +54,9 @@ class RaspberryPiParser(Parser):\n config.pop('disable')\n \n # The raspberrypi config format has 'plot' map to a list of module\n- # names which should be plotted. libtuning has each module contain the\n- # plot information in itself so do this conversion.\n-\n- for module in self._enumerate_rpi_modules(config['plot'], config, modules):\n- # It's fine to set the value of a potentially disabled module, as\n- # the object still exists at this point\n- module.appendValue('debug', 'plot')\n+ # names which should be plotted. In libtuning, this information is\n+ # passed by command line arguments, so simply drop this piece of\n+ # information.\n config.pop('plot')\n \n # Convert the keys from module name to module instance\n", "prefixes": [ "libcamera-devel", "5/6" ] }