From patchwork Thu Nov 24 11:38:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 17884 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BC984BE08B for ; Thu, 24 Nov 2022 11:39:10 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8BF586331C; Thu, 24 Nov 2022 12:39:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1669289950; bh=CRnj4q1I+7B67SEymdsRPb4hXQSqWhGPzt14ZSsaONc=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=bpKQkRQtagIV66VmYgvliFcr2EL1lXhjb+5A2QJ2gehHgF6VzEHfbYofh5ElYIy8/ 7cP65HIeHNzXtvmGFNSHMqJtAb4BNcfvhTXw3fzTDuXQR9m+n81Wk64H5YGscAXZ61 P2AlyN67tI2BAUwHROdp17lUdxE5jFpinHT5POP14u3AdINFNWg+zM5LoSaadEEB7a Np+Cs42/gXO8ofSTejxEhC9a1bvYNYdLG+ed9UxAeYO0+lxpmDCTXsdvafjXPhtFrE oHV1DlDcX/jD35GO4mqxbxO0wvSXGT6JuTI5sqYF5huxoKwOtwWeeTTCe1/6efd0bn RWvLE6Wd6JoqQ== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B263632EA for ; Thu, 24 Nov 2022 12:39:08 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="uDkm64Gt"; dkim-atps=neutral Received: from pyrite.tail37cf.ts.net (h175-177-042-159.catv02.itscom.jp [175.177.42.159]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 42B95496; Thu, 24 Nov 2022 12:39:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1669289948; bh=CRnj4q1I+7B67SEymdsRPb4hXQSqWhGPzt14ZSsaONc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uDkm64Gt7Ge9P0V46vpoLjkZbBGgQwjSJoT0wAqamX6KF5WztrC4LBQJTfCElRX3d JzQ/E3Dt1YD6Xscf14zwrEz7bfNnnhV/5SUwOuJ6KOKpGcnROhOS9rwlAI4TLEYoCW ioXC4k2tKrMvaI1tt2n1D6Jo7JJOnu5LWgHEO0Lk= To: libcamera-devel@lists.libcamera.org Date: Thu, 24 Nov 2022 20:38:48 +0900 Message-Id: <20221124113849.2193579-6-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221124113849.2193579-1-paul.elder@ideasonboard.com> References: <20221124113849.2193579-1-paul.elder@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 5/6] utils: libtuning: parsers: raspberrypi: Ignore the plot config parameter X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Paul Elder via libcamera-devel From: Paul Elder Reply-To: Paul Elder Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Ignore the plot config parameter that is used in the Raspberry Pi CTT tuning configuration file, as it conflicts with the debug parameter that will be provided in the command line arguments. Signed-off-by: Paul Elder --- utils/tuning/libtuning/parsers/raspberrypi_parser.py | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/utils/tuning/libtuning/parsers/raspberrypi_parser.py b/utils/tuning/libtuning/parsers/raspberrypi_parser.py index d26586ba..dab50440 100644 --- a/utils/tuning/libtuning/parsers/raspberrypi_parser.py +++ b/utils/tuning/libtuning/parsers/raspberrypi_parser.py @@ -54,13 +54,9 @@ class RaspberryPiParser(Parser): config.pop('disable') # The raspberrypi config format has 'plot' map to a list of module - # names which should be plotted. libtuning has each module contain the - # plot information in itself so do this conversion. - - for module in self._enumerate_rpi_modules(config['plot'], config, modules): - # It's fine to set the value of a potentially disabled module, as - # the object still exists at this point - module.appendValue('debug', 'plot') + # names which should be plotted. In libtuning, this information is + # passed by command line arguments, so simply drop this piece of + # information. config.pop('plot') # Convert the keys from module name to module instance