Patch Detail
Show a patch.
GET /api/patches/17611/?format=api
{ "id": 17611, "url": "https://patchwork.libcamera.org/api/patches/17611/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17611/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221017083612.810332-1-kieran.bingham@ideasonboard.com>", "date": "2022-10-17T08:36:12", "name": "[libcamera-devel] libcamera: v4l2_videodevice: Reduce zero sequence warning log level", "commit_ref": "bf7226f4c46de0bbadff63eb531dbd3dd4c900a0", "pull_url": null, "state": "accepted", "archived": false, "hash": "2099982fac423d5f3c4d59da1198777bbd278352", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17611/mbox/", "series": [ { "id": 3558, "url": "https://patchwork.libcamera.org/api/series/3558/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3558", "date": "2022-10-17T08:36:12", "name": "[libcamera-devel] libcamera: v4l2_videodevice: Reduce zero sequence warning log level", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3558/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17611/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17611/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E14CEBD16B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 17 Oct 2022 08:36:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 01BA062DEA;\n\tMon, 17 Oct 2022 10:36:19 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B376603D1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 17 Oct 2022 10:36:17 +0200 (CEST)", "from Monstersaurus.ksquared.org.uk.beta.tailscale.net\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B63A6E70;\n\tMon, 17 Oct 2022 10:36:16 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1665995779;\n\tbh=sbpf+cEy5lMIPFk2abIGqklLRClSVlpRymna2Ql2XJg=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=gTs4BsmN3U8ewK3OQAokDfbYP8ulW1qdGhe0JsjyOUZp7HdNKMLpZoJRgcJQKlp+l\n\t/GszqwqhAZle+w415oa9TTSmOvzwUh5dWkAPGn+p4wMkB92o99h9jDeejJmJOeKONy\n\tB/SKb0AwLi04kkcMPmFHKVQCn4um2do7DsB5S3s3DYtWaf9bYyEKUExPhqYnuUhAId\n\t7gdY3oKKBz4Vnvzsgngz4PsSuiRq+9gSzbaAiw1knuOr5uog8HKKLoOrCMVfqKUHEV\n\t9EDrht+yG9Lj7p39qN/48IQLlJ7V8Fpis6VV5DvfOZWyUZHLn62r+Lsij0PwjeUl52\n\tDaoG3c/W4S9/Q==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1665995776;\n\tbh=sbpf+cEy5lMIPFk2abIGqklLRClSVlpRymna2Ql2XJg=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Z0/qQ4KoAO4ryRwQWr86os15wm5cBYgF0e+q9IC8d7IEZL3u/+n3zTFO/rUlNgTgd\n\tYaSDKrsXD9fRsglfRmYnPdJdENzxRbgVIfXISBDxEGZTEfyvwBMKkrmvbuaSe+fF8O\n\taD8D4rGHZr0m/weJ9fCNqOV/0scWfDhlSqkCKm30=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Z0/qQ4Ko\"; dkim-atps=neutral", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Mon, 17 Oct 2022 09:36:12 +0100", "Message-Id": "<20221017083612.810332-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Reduce zero\n\tsequence warning log level", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The V4L2VideoDevice ensures that all sequence numbers for applications\ncommence at zero from the libcamera perspective. This should be the\nbehaviour expected by kernel drivers, but this is not always the case.\n\nThis is handled internally to ensure consistency, and a warning is\nprinted if the device does not start from zero. It was expected that the\nWarning would help highlight where kernel drivers should be fixed, but\nthis has led to several false positive reports of failures where people\nhave been concerned that this warning is a cause for unrelated issues.\n\nLower the log level print to 'Info', to reduce the apparent severity of\nthis warning. Info is likely more appropriate that Debug to continue to\nfacilitate awareness of kernel drivers that could be improved, while not\nappearing to be a fault.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/v4l2_videodevice.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex e30858c9fa02..c2cb9dbfe09c 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -1814,7 +1814,7 @@ FrameBuffer *V4L2VideoDevice::dequeueBuffer()\n \t */\n \tif (!firstFrame_) {\n \t\tif (buf.sequence)\n-\t\t\tLOG(V4L2, Warning)\n+\t\t\tLOG(V4L2, Info)\n \t\t\t\t<< \"Zero sequence expected for first frame (got \"\n \t\t\t\t<< buf.sequence << \")\";\n \t\tfirstFrame_ = buf.sequence;\n", "prefixes": [ "libcamera-devel" ] }