From patchwork Mon Oct 17 08:36:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 17611 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E14CEBD16B for ; Mon, 17 Oct 2022 08:36:19 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 01BA062DEA; Mon, 17 Oct 2022 10:36:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1665995779; bh=sbpf+cEy5lMIPFk2abIGqklLRClSVlpRymna2Ql2XJg=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=gTs4BsmN3U8ewK3OQAokDfbYP8ulW1qdGhe0JsjyOUZp7HdNKMLpZoJRgcJQKlp+l /GszqwqhAZle+w415oa9TTSmOvzwUh5dWkAPGn+p4wMkB92o99h9jDeejJmJOeKONy B/SKb0AwLi04kkcMPmFHKVQCn4um2do7DsB5S3s3DYtWaf9bYyEKUExPhqYnuUhAId 7gdY3oKKBz4Vnvzsgngz4PsSuiRq+9gSzbaAiw1knuOr5uog8HKKLoOrCMVfqKUHEV 9EDrht+yG9Lj7p39qN/48IQLlJ7V8Fpis6VV5DvfOZWyUZHLn62r+Lsij0PwjeUl52 DaoG3c/W4S9/Q== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B376603D1 for ; Mon, 17 Oct 2022 10:36:17 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Z0/qQ4Ko"; dkim-atps=neutral Received: from Monstersaurus.ksquared.org.uk.beta.tailscale.net (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B63A6E70; Mon, 17 Oct 2022 10:36:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1665995776; bh=sbpf+cEy5lMIPFk2abIGqklLRClSVlpRymna2Ql2XJg=; h=From:To:Cc:Subject:Date:From; b=Z0/qQ4KoAO4ryRwQWr86os15wm5cBYgF0e+q9IC8d7IEZL3u/+n3zTFO/rUlNgTgd YaSDKrsXD9fRsglfRmYnPdJdENzxRbgVIfXISBDxEGZTEfyvwBMKkrmvbuaSe+fF8O aD8D4rGHZr0m/weJ9fCNqOV/0scWfDhlSqkCKm30= To: libcamera devel Date: Mon, 17 Oct 2022 09:36:12 +0100 Message-Id: <20221017083612.810332-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] libcamera: v4l2_videodevice: Reduce zero sequence warning log level X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Kieran Bingham via libcamera-devel From: Kieran Bingham Reply-To: Kieran Bingham Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The V4L2VideoDevice ensures that all sequence numbers for applications commence at zero from the libcamera perspective. This should be the behaviour expected by kernel drivers, but this is not always the case. This is handled internally to ensure consistency, and a warning is printed if the device does not start from zero. It was expected that the Warning would help highlight where kernel drivers should be fixed, but this has led to several false positive reports of failures where people have been concerned that this warning is a cause for unrelated issues. Lower the log level print to 'Info', to reduce the apparent severity of this warning. Info is likely more appropriate that Debug to continue to facilitate awareness of kernel drivers that could be improved, while not appearing to be a fault. Signed-off-by: Kieran Bingham Reviewed-by: Paul Elder Reviewed-by: Umang Jain --- src/libcamera/v4l2_videodevice.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp index e30858c9fa02..c2cb9dbfe09c 100644 --- a/src/libcamera/v4l2_videodevice.cpp +++ b/src/libcamera/v4l2_videodevice.cpp @@ -1814,7 +1814,7 @@ FrameBuffer *V4L2VideoDevice::dequeueBuffer() */ if (!firstFrame_) { if (buf.sequence) - LOG(V4L2, Warning) + LOG(V4L2, Info) << "Zero sequence expected for first frame (got " << buf.sequence << ")"; firstFrame_ = buf.sequence;