Patch Detail
Show a patch.
GET /api/patches/17429/?format=api
{ "id": 17429, "url": "https://patchwork.libcamera.org/api/patches/17429/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17429/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220927023642.12341-19-laurent.pinchart@ideasonboard.com>", "date": "2022-09-27T02:36:27", "name": "[libcamera-devel,v5,18/33] ipa: Disable copy-construction of IPAContext", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9dd21cb64bfef0e8aede4606b64efde8792026fa", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17429/mbox/", "series": [ { "id": 3506, "url": "https://patchwork.libcamera.org/api/series/3506/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3506", "date": "2022-09-27T02:36:09", "name": "ipa: Frame context queue, IPU3 & RkISP consolidation, and RkISP1 improvements", "version": 5, "mbox": "https://patchwork.libcamera.org/series/3506/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17429/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17429/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 07219C327E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 27 Sep 2022 02:37:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B0445622B2;\n\tTue, 27 Sep 2022 04:37:28 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D78D4622A9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 27 Sep 2022 04:37:25 +0200 (CEST)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5B67E47C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 27 Sep 2022 04:37:25 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664246248;\n\tbh=rDrjId091+fWhPqSCtqNP1jK/fH3P/JmPOUiuveln84=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=YC/Qsie4OYK+DQ2CY97cppoFYqq07t4X8DDPcrE/5Edx9iMm1/HRJ16cO9LiPnPjG\n\tzAyCYuL827+Dx9usVJfK+Y0fJproLuj0G7Y8X5EruD1fn+o4WTB5EFsY15vzewRiGW\n\tV9GlX2sg1fXYFhowrRuS/bAR1ylx+16A3z6G+ChNcrhtULNnAuWXAdgtawWV8YB6QX\n\tfblYKgje1NCzHqV6VJ5+k/SxrP8fMiGqQjTwQ2gHC6Nuzz/xXDcCF1UncK+YQPGEtF\n\tjp5LdnPzBNDSyTiJeOthEC9F0FKz2s1ENHv69m2Dcfl7euNm5RLe4iRaygpm6giPQn\n\tOsIqMG0yqQFXg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664246245;\n\tbh=rDrjId091+fWhPqSCtqNP1jK/fH3P/JmPOUiuveln84=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Ost+qxllt68RDE3bK7vIYSKdylpVPWl6XL+2z4k7wnThQznq5xb3avUEFYKArM4Qh\n\t0/9usctMYkkDytoM3Nd/Xm8oa3qgoBH/Zw0m2J5vNILvVhnMf4/rV2z4P29L+eaGUJ\n\ty91IarnFnuF+Z+Lc1+kEAx5Ofw0e/iyV+2PxKvSA=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Ost+qxll\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 27 Sep 2022 05:36:27 +0300", "Message-Id": "<20220927023642.12341-19-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220927023642.12341-1-laurent.pinchart@ideasonboard.com>", "References": "<20220927023642.12341-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 18/33] ipa: Disable copy-construction\n\tof IPAContext", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The IPAContext is not meant to be copied. Prevent unintentional\npass-by-value by disabling its copy constructor.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/ipu3/ipa_context.h | 4 ++++\n src/ipa/rkisp1/ipa_context.h | 4 ++++\n 2 files changed, 8 insertions(+)", "diff": "diff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h\nindex bdba3d07d13a..9766330f2f39 100644\n--- a/src/ipa/ipu3/ipa_context.h\n+++ b/src/ipa/ipu3/ipa_context.h\n@@ -10,6 +10,7 @@\n \n #include <linux/intel-ipu3.h>\n \n+#include <libcamera/base/class.h>\n #include <libcamera/base/utils.h>\n \n #include <libcamera/geometry.h>\n@@ -87,6 +88,9 @@ struct IPAContext {\n \tIPAActiveState activeState;\n \n \tFCQueue<IPAFrameContext, kMaxFrameContexts> frameContexts;\n+\n+private:\n+\tLIBCAMERA_DISABLE_COPY(IPAContext)\n };\n \n } /* namespace ipa::ipu3 */\ndiff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\nindex 4481bd2acde6..9a84b7adda45 100644\n--- a/src/ipa/rkisp1/ipa_context.h\n+++ b/src/ipa/rkisp1/ipa_context.h\n@@ -10,6 +10,7 @@\n \n #include <linux/rkisp1-config.h>\n \n+#include <libcamera/base/class.h>\n #include <libcamera/base/utils.h>\n \n #include <libcamera/geometry.h>\n@@ -101,6 +102,9 @@ struct IPAContext {\n \tIPAActiveState activeState;\n \n \tFCQueue<IPAFrameContext, kMaxFrameContexts> frameContexts;\n+\n+private:\n+\tLIBCAMERA_DISABLE_COPY(IPAContext)\n };\n \n } /* namespace ipa::rkisp1 */\n", "prefixes": [ "libcamera-devel", "v5", "18/33" ] }