From patchwork Tue Sep 27 02:36:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 17429 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 07219C327E for ; Tue, 27 Sep 2022 02:37:29 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B0445622B2; Tue, 27 Sep 2022 04:37:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1664246248; bh=rDrjId091+fWhPqSCtqNP1jK/fH3P/JmPOUiuveln84=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=YC/Qsie4OYK+DQ2CY97cppoFYqq07t4X8DDPcrE/5Edx9iMm1/HRJ16cO9LiPnPjG zAyCYuL827+Dx9usVJfK+Y0fJproLuj0G7Y8X5EruD1fn+o4WTB5EFsY15vzewRiGW V9GlX2sg1fXYFhowrRuS/bAR1ylx+16A3z6G+ChNcrhtULNnAuWXAdgtawWV8YB6QX fblYKgje1NCzHqV6VJ5+k/SxrP8fMiGqQjTwQ2gHC6Nuzz/xXDcCF1UncK+YQPGEtF jp5LdnPzBNDSyTiJeOthEC9F0FKz2s1ENHv69m2Dcfl7euNm5RLe4iRaygpm6giPQn OsIqMG0yqQFXg== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D78D4622A9 for ; Tue, 27 Sep 2022 04:37:25 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Ost+qxll"; dkim-atps=neutral Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5B67E47C for ; Tue, 27 Sep 2022 04:37:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1664246245; bh=rDrjId091+fWhPqSCtqNP1jK/fH3P/JmPOUiuveln84=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Ost+qxllt68RDE3bK7vIYSKdylpVPWl6XL+2z4k7wnThQznq5xb3avUEFYKArM4Qh 0/9usctMYkkDytoM3Nd/Xm8oa3qgoBH/Zw0m2J5vNILvVhnMf4/rV2z4P29L+eaGUJ y91IarnFnuF+Z+Lc1+kEAx5Ofw0e/iyV+2PxKvSA= To: libcamera-devel@lists.libcamera.org Date: Tue, 27 Sep 2022 05:36:27 +0300 Message-Id: <20220927023642.12341-19-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220927023642.12341-1-laurent.pinchart@ideasonboard.com> References: <20220927023642.12341-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v5 18/33] ipa: Disable copy-construction of IPAContext X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The IPAContext is not meant to be copied. Prevent unintentional pass-by-value by disabling its copy constructor. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham Reviewed-by: Jacopo Mondi --- src/ipa/ipu3/ipa_context.h | 4 ++++ src/ipa/rkisp1/ipa_context.h | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h index bdba3d07d13a..9766330f2f39 100644 --- a/src/ipa/ipu3/ipa_context.h +++ b/src/ipa/ipu3/ipa_context.h @@ -10,6 +10,7 @@ #include +#include #include #include @@ -87,6 +88,9 @@ struct IPAContext { IPAActiveState activeState; FCQueue frameContexts; + +private: + LIBCAMERA_DISABLE_COPY(IPAContext) }; } /* namespace ipa::ipu3 */ diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h index 4481bd2acde6..9a84b7adda45 100644 --- a/src/ipa/rkisp1/ipa_context.h +++ b/src/ipa/rkisp1/ipa_context.h @@ -10,6 +10,7 @@ #include +#include #include #include @@ -101,6 +102,9 @@ struct IPAContext { IPAActiveState activeState; FCQueue frameContexts; + +private: + LIBCAMERA_DISABLE_COPY(IPAContext) }; } /* namespace ipa::rkisp1 */