Patch Detail
Show a patch.
GET /api/patches/17321/?format=api
{ "id": 17321, "url": "https://patchwork.libcamera.org/api/patches/17321/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17321/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220908014200.28728-13-laurent.pinchart@ideasonboard.com>", "date": "2022-09-08T01:41:40", "name": "[libcamera-devel,v4,12/32] ipa: rkisp1: Remove unused class member", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1f94afbb2da0ac399820dae4385d59a5cd23fe0e", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17321/mbox/", "series": [ { "id": 3476, "url": "https://patchwork.libcamera.org/api/series/3476/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3476", "date": "2022-09-08T01:41:28", "name": "ipa: Frame context queue, IPU3 & RkISP consolidation, and RkISP1 improvements", "version": 4, "mbox": "https://patchwork.libcamera.org/series/3476/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17321/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17321/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7AB6AC3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 8 Sep 2022 01:42:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 32F18620C5;\n\tThu, 8 Sep 2022 03:42:36 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AEEE2620BE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 8 Sep 2022 03:42:34 +0200 (CEST)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 344BD6CC;\n\tThu, 8 Sep 2022 03:42:34 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1662601356;\n\tbh=LbHoDg6Ka3CHlxAv9U+Xv8AKdMpJk+ndXS3/VWsa1oo=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=zRa1ZHpe5vPIuMasO2bcVil8dsqA6XDG8A283GJGFcDjIGLhBIQsZ09n27v2byaGe\n\tOlhEOBFzYAWqmCq2XUkfAaFNJ/eyiklOLibmB5GXZzXFB5hSFM66BYxf3/GjZLYWrk\n\twrZfKEA+2z2NawEEKn5QAR8CmfuV2ACkKLjZ/A6FXxtB/Vgl16J2zGn98RxrUpF55d\n\tcexwBVTBxIvEsoX0XZJDG3n/jewjFXfL86zYPt+BsT/KdkLdVETqP7NF5QEAEYmm9J\n\tayOhpDd4nvSFtKMXcBXRBkHUGEd8pgdyZxmBS/MjqW6PRvxHUe2SYLUSGphJCRl8Fc\n\tEfjsfh5Y7LY4g==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1662601354;\n\tbh=LbHoDg6Ka3CHlxAv9U+Xv8AKdMpJk+ndXS3/VWsa1oo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ujEAOXo+4PpvsAIT0+6BJUtqyudJrspJj7ynSlCTY5WGK5y4P2lKN1UQVyhnz2gZ/\n\tC66SkydBIhP0YjXGq6AuVlpIe1fZCSrXk2+psSbbFhWJzFWNnQ4S6p2eNa+iTY4MXE\n\tyYuaI5SoHTUUzwMjZKXPHEBMCuMweQKI1hDeU3zY=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ujEAOXo+\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 8 Sep 2022 04:41:40 +0300", "Message-Id": "<20220908014200.28728-13-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220908014200.28728-1-laurent.pinchart@ideasonboard.com>", "References": "<20220908014200.28728-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 12/32] ipa: rkisp1: Remove unused class\n\tmember", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Jacopo Mondi <jacopo@jmondi.org>\n\nThe \"autoExposure\" class member is not used.\n\nRemove it.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/ipa/rkisp1/rkisp1.cpp | 5 -----\n 1 file changed, 5 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 07210d16b5b5..f7a17459b6c3 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -71,9 +71,6 @@ private:\n \n \tControlInfoMap ctrls_;\n \n-\t/* Camera sensor controls. */\n-\tbool autoExposure_;\n-\n \t/* revision-specific data */\n \trkisp1_cif_isp_version hwRevision_;\n \tunsigned int hwHistBinNMax_;\n@@ -216,8 +213,6 @@ int IPARkISP1::configure([[maybe_unused]] const IPACameraSensorInfo &info,\n \t\treturn -EINVAL;\n \t}\n \n-\tautoExposure_ = true;\n-\n \tint32_t minExposure = itExp->second.min().get<int32_t>();\n \tint32_t maxExposure = itExp->second.max().get<int32_t>();\n \n", "prefixes": [ "libcamera-devel", "v4", "12/32" ] }