Patch Detail
Show a patch.
GET /api/patches/17114/?format=api
{ "id": 17114, "url": "https://patchwork.libcamera.org/api/patches/17114/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17114/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220814095241.137108-2-Rauch.Christian@gmx.de>", "date": "2022-08-14T09:52:40", "name": "[libcamera-devel,2/3] libcamera: use const reference for range loops", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "208e8da43d67fa2f56fe61cbd50c8a20f5e2b90b", "submitter": { "id": 111, "url": "https://patchwork.libcamera.org/api/people/111/?format=api", "name": "Christian Rauch", "email": "Rauch.Christian@gmx.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17114/mbox/", "series": [ { "id": 3413, "url": "https://patchwork.libcamera.org/api/series/3413/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3413", "date": "2022-08-14T09:52:39", "name": "[libcamera-devel,1/3] libcamera: remove unused header", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3413/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17114/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17114/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C30F5BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 14 Aug 2022 09:52:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BA4F861FC0;\n\tSun, 14 Aug 2022 11:52:47 +0200 (CEST)", "from mout.gmx.net (mout.gmx.net [212.227.17.20])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 531C461FBC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 14 Aug 2022 11:52:45 +0200 (CEST)", "from voyager ([88.152.184.103]) by mail.gmx.net (mrgmx105\n\t[212.227.17.168]) with ESMTPSA (Nemesis) id 1MTiPl-1nvuUr3JgD-00U2cW;\n\tSun, 14 Aug 2022 11:52:44 +0200" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660470767;\n\tbh=pWdY2dowanLkW2bDf+ucf0b0pk9+ac7LeGPx1pbp6ec=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=GYoKlHCNbmaT/I972mbnDqXMFfZo6bBl21aH3HpzH0ct331YXeqCYKkuNZdCa3bPj\n\tmr2JP0C8sJHUJqf6aog98jbGMYrPmiSTdK4oUDlnvw1B/8JoBa6OgB9vUBRS4lSYDt\n\tC3CDTMpQv2w7fz3+AMvt5mtkN4hHM6lVpSqiFTLaJCPgh1jG4H4RzWlvhDd0ka+UG7\n\tYlMeXmJK+nW64z89JwFXTzgV2DXGUvHdJnGdRo2ycrJou3bzg4VxaiK0NjAxeK3jbQ\n\txPdWeUzsrCXcs3s4cFj6dwvblPd9HhGSD8hCyaKjej9ers9JYIEBR0Ga2bb3osCPjK\n\tU9iRdXVYvZzhg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1660470764;\n\tbh=pWdY2dowanLkW2bDf+ucf0b0pk9+ac7LeGPx1pbp6ec=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References;\n\tb=KowgvpBFV6GhVnQM6COHpm0wRHhn6t0OGFRNSIRt+0OB3FrQSOTpUW1HXU6LpavcC\n\tECZuRaBakciezO4LeVXNvz3rVH7VRytBvhya9qvzwsv/Wo0mNtz5IhUeO6FIcvZ5rb\n\tuvK5MeLf9+l8YsCyWL6+qWDNJCWbPBLXfnYwc82c=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"KowgvpBF\"; dkim-atps=neutral", "X-UI-Sender-Class": "01bb95c1-4bf8-414a-932a-4f6e2808ef9c", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 14 Aug 2022 11:52:40 +0200", "Message-Id": "<20220814095241.137108-2-Rauch.Christian@gmx.de>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220814095241.137108-1-Rauch.Christian@gmx.de>", "References": "<20220814095241.137108-1-Rauch.Christian@gmx.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "X-Provags-ID": "V03:K1:fbbDokoiDVIT1w5A8x2PsuTeA6fx23frg30W1Pu0GFkk7xRfFo4\n\tIIoe2f7/OcCaz+yjoA6CdsX3ShszkzbwaKNsUm/XgqsHuBEWTSTnIFghiPpYdf+oXcROkaR\n\t5WK/sPudVjL6yBS0ngLlPEcY0kcENXxd5V9nuIZ9PyfcKNhDNLaknkGelkNO8kvPmYH0XKJ\n\tUgWy0wAUKVEabXeoyP3SA==", "X-Spam-Flag": "NO", "X-UI-Out-Filterresults": "notjunk:1; V03:K0:leZXziZQp7k=:G263lVL7dvy8omkt2DOobt\n\t0jfB3BtR4dQ7sD4hkLig2qJgq6GqFEP9xGAaesUodt4eXr2tk617bgqMF7SXK0mHztSEeJiqi\n\tpuaKFh40nUcQiuf3X5qcLrelzdWBnAcSB/2qVrNDxunL6fjyxfu1GTSlBz6XWlN0vqLELryPv\n\te/D7Q5GXo4We8d/n/1erCaxZeulIFsb8fVfaMTmnJzq97f2AcYn0iafJSrsqyjm8LkB3V3Oyp\n\tCe8GMM7bEEKMzrqhDuBpsM/7JOE/htcLBkdRndOsfvOCg0+ma2SfXuiXr6VzgwKqU3+E6fPAF\n\twDU5NG5bA1X3xE4uXJWHywAK6lIEVGdCawVZiB+HrQ/4Q87Qtj2jWwMK4W/lq1Wq7Q/2feE2g\n\tmj3mSOJAPUQACO/rb3OnB8xjp/rC3gUgWCuHdZAD2lpZ2Y9uvavo6HSULCvXrjx9HX7xVn2Ae\n\tVzxhu0zlG8RyjKJLDQX99PareajR6MCRn5cwki+409J5r7MQAGLBbU8DIs4a2QAdqwyzT37Yw\n\t6EJL+CIke/uLxaGQO7abcv4Rt0PgcmPxlaHKQ/DliBfDoHVm5EWkT/xjZSvwCBx+xmwFiBz1A\n\t3kWyWE82heNrXeWWM66KUbcBq1Qm0Ih8ctFDSFAx2UxXmTXZIPJFSJjg7+A0EU30bwoAUL5OI\n\t1YS7Vkt5tjY299BMyOrIVFktrZWkGRjRWoV558I2jm+GuRoomNEI4eaLId7K5fQb5N3MFPvwn\n\tpjhwkbD6uRwxLn9oxwGJZcw8xVgtIzLEvouKdUXxHFnN7fRAkqEXdyEaEpOC0n0WKPhCMWTEA\n\t8q5g0Ruw3z49tv9u2jFnAoVYZU47oS/oOM8IN9hwpHkTBgVE9bdVUHCwldGVYSHyMSlyviRSl\n\tn/Dt/MySksQd2oqSnoHdN6vtH8OQ7q0bEgYMNOrX6JZtgjllvRGhWX/MFMi5R3muROa3b6LnN\n\tJPYo+tlu0FjTXdkS+hwsiPTBP+a8P1oC7l3/5VReVJR9K0TM8rOKeGFqEjwjJqgW7TrfTSYWL\n\th8zq7UZJy/kMdAzD7XfIprteWaZv9nWS8rnVAryrUeS//ilzx7I59vTovPEfAAbkpgO/Pkub1\n\tvAzOZMJHmL/FoG4YphtLxipXV+R9ADoGOl5lpBsQkfFbGznan3LiEQdmg==", "Subject": "[libcamera-devel] [PATCH 2/3] libcamera: use const reference for\n\trange loops", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Christian Rauch via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Christian Rauch <Rauch.Christian@gmx.de>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de>\n---\n src/libcamera/camera_manager.cpp | 2 +-\n src/libcamera/device_enumerator.cpp | 2 +-\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 5 +----\n src/libcamera/pipeline/vimc/vimc.cpp | 2 +-\n src/libcamera/pipeline_handler.cpp | 2 +-\n 5 files changed, 5 insertions(+), 8 deletions(-)\n\n--\n2.34.1", "diff": "diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex 70d73822..7ff4bc6f 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -189,7 +189,7 @@ void CameraManager::Private::addCamera(std::shared_ptr<Camera> camera,\n {\n \tMutexLocker locker(mutex_);\n\n-\tfor (std::shared_ptr<Camera> c : cameras_) {\n+\tfor (const std::shared_ptr<Camera> &c : cameras_) {\n \t\tif (c->id() == camera->id()) {\n \t\t\tLOG(Camera, Fatal)\n \t\t\t\t<< \"Trying to register a camera with a duplicated ID '\"\ndiff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\nindex d1258050..f2e055de 100644\n--- a/src/libcamera/device_enumerator.cpp\n+++ b/src/libcamera/device_enumerator.cpp\n@@ -161,7 +161,7 @@ std::unique_ptr<DeviceEnumerator> DeviceEnumerator::create()\n\n DeviceEnumerator::~DeviceEnumerator()\n {\n-\tfor (std::shared_ptr<MediaDevice> media : devices_) {\n+\tfor (const std::shared_ptr<MediaDevice> &media : devices_) {\n \t\tif (media->busy())\n \t\t\tLOG(DeviceEnumerator, Error)\n \t\t\t\t<< \"Removing media device \" << media->deviceNode()\ndiff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nindex fbe02cdc..0306f56c 100644\n--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n@@ -340,10 +340,7 @@ int PipelineHandlerUVC::processControls(UVCCameraData *data, Request *request)\n {\n \tControlList controls(data->video_->controls());\n\n-\tfor (auto it : request->controls()) {\n-\t\tunsigned int id = it.first;\n-\t\tControlValue &value = it.second;\n-\n+\tfor (const auto &[id, value] : request->controls()) {\n \t\tprocessControl(&controls, id, value);\n \t}\n\ndiff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\nindex 153cf849..d2f2e460 100644\n--- a/src/libcamera/pipeline/vimc/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc/vimc.cpp\n@@ -378,7 +378,7 @@ int PipelineHandlerVimc::processControls(VimcCameraData *data, Request *request)\n {\n \tControlList controls(data->sensor_->controls());\n\n-\tfor (auto it : request->controls()) {\n+\tfor (const auto &it : request->controls()) {\n \t\tunsigned int id = it.first;\n \t\tunsigned int offset;\n \t\tuint32_t cid;\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 7d2d00ef..e5cb751c 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -616,7 +616,7 @@ void PipelineHandler::disconnect()\n \t */\n \tstd::vector<std::weak_ptr<Camera>> cameras{ std::move(cameras_) };\n\n-\tfor (std::weak_ptr<Camera> ptr : cameras) {\n+\tfor (const std::weak_ptr<Camera> &ptr : cameras) {\n \t\tstd::shared_ptr<Camera> camera = ptr.lock();\n \t\tif (!camera)\n \t\t\tcontinue;\n", "prefixes": [ "libcamera-devel", "2/3" ] }