From patchwork Sun Aug 14 09:52:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Rauch X-Patchwork-Id: 17114 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C30F5BE173 for ; Sun, 14 Aug 2022 09:52:48 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id BA4F861FC0; Sun, 14 Aug 2022 11:52:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1660470767; bh=pWdY2dowanLkW2bDf+ucf0b0pk9+ac7LeGPx1pbp6ec=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=GYoKlHCNbmaT/I972mbnDqXMFfZo6bBl21aH3HpzH0ct331YXeqCYKkuNZdCa3bPj mr2JP0C8sJHUJqf6aog98jbGMYrPmiSTdK4oUDlnvw1B/8JoBa6OgB9vUBRS4lSYDt C3CDTMpQv2w7fz3+AMvt5mtkN4hHM6lVpSqiFTLaJCPgh1jG4H4RzWlvhDd0ka+UG7 YlMeXmJK+nW64z89JwFXTzgV2DXGUvHdJnGdRo2ycrJou3bzg4VxaiK0NjAxeK3jbQ xPdWeUzsrCXcs3s4cFj6dwvblPd9HhGSD8hCyaKjej9ers9JYIEBR0Ga2bb3osCPjK U9iRdXVYvZzhg== Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 531C461FBC for ; Sun, 14 Aug 2022 11:52:45 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=gmx.net header.i=@gmx.net header.b="KowgvpBF"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1660470764; bh=pWdY2dowanLkW2bDf+ucf0b0pk9+ac7LeGPx1pbp6ec=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=KowgvpBFV6GhVnQM6COHpm0wRHhn6t0OGFRNSIRt+0OB3FrQSOTpUW1HXU6LpavcC ECZuRaBakciezO4LeVXNvz3rVH7VRytBvhya9qvzwsv/Wo0mNtz5IhUeO6FIcvZ5rb uvK5MeLf9+l8YsCyWL6+qWDNJCWbPBLXfnYwc82c= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from voyager ([88.152.184.103]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MTiPl-1nvuUr3JgD-00U2cW; Sun, 14 Aug 2022 11:52:44 +0200 To: libcamera-devel@lists.libcamera.org Date: Sun, 14 Aug 2022 11:52:40 +0200 Message-Id: <20220814095241.137108-2-Rauch.Christian@gmx.de> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220814095241.137108-1-Rauch.Christian@gmx.de> References: <20220814095241.137108-1-Rauch.Christian@gmx.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:fbbDokoiDVIT1w5A8x2PsuTeA6fx23frg30W1Pu0GFkk7xRfFo4 IIoe2f7/OcCaz+yjoA6CdsX3ShszkzbwaKNsUm/XgqsHuBEWTSTnIFghiPpYdf+oXcROkaR 5WK/sPudVjL6yBS0ngLlPEcY0kcENXxd5V9nuIZ9PyfcKNhDNLaknkGelkNO8kvPmYH0XKJ UgWy0wAUKVEabXeoyP3SA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:leZXziZQp7k=:G263lVL7dvy8omkt2DOobt 0jfB3BtR4dQ7sD4hkLig2qJgq6GqFEP9xGAaesUodt4eXr2tk617bgqMF7SXK0mHztSEeJiqi puaKFh40nUcQiuf3X5qcLrelzdWBnAcSB/2qVrNDxunL6fjyxfu1GTSlBz6XWlN0vqLELryPv e/D7Q5GXo4We8d/n/1erCaxZeulIFsb8fVfaMTmnJzq97f2AcYn0iafJSrsqyjm8LkB3V3Oyp Ce8GMM7bEEKMzrqhDuBpsM/7JOE/htcLBkdRndOsfvOCg0+ma2SfXuiXr6VzgwKqU3+E6fPAF wDU5NG5bA1X3xE4uXJWHywAK6lIEVGdCawVZiB+HrQ/4Q87Qtj2jWwMK4W/lq1Wq7Q/2feE2g mj3mSOJAPUQACO/rb3OnB8xjp/rC3gUgWCuHdZAD2lpZ2Y9uvavo6HSULCvXrjx9HX7xVn2Ae Vzxhu0zlG8RyjKJLDQX99PareajR6MCRn5cwki+409J5r7MQAGLBbU8DIs4a2QAdqwyzT37Yw 6EJL+CIke/uLxaGQO7abcv4Rt0PgcmPxlaHKQ/DliBfDoHVm5EWkT/xjZSvwCBx+xmwFiBz1A 3kWyWE82heNrXeWWM66KUbcBq1Qm0Ih8ctFDSFAx2UxXmTXZIPJFSJjg7+A0EU30bwoAUL5OI 1YS7Vkt5tjY299BMyOrIVFktrZWkGRjRWoV558I2jm+GuRoomNEI4eaLId7K5fQb5N3MFPvwn pjhwkbD6uRwxLn9oxwGJZcw8xVgtIzLEvouKdUXxHFnN7fRAkqEXdyEaEpOC0n0WKPhCMWTEA 8q5g0Ruw3z49tv9u2jFnAoVYZU47oS/oOM8IN9hwpHkTBgVE9bdVUHCwldGVYSHyMSlyviRSl n/Dt/MySksQd2oqSnoHdN6vtH8OQ7q0bEgYMNOrX6JZtgjllvRGhWX/MFMi5R3muROa3b6LnN JPYo+tlu0FjTXdkS+hwsiPTBP+a8P1oC7l3/5VReVJR9K0TM8rOKeGFqEjwjJqgW7TrfTSYWL h8zq7UZJy/kMdAzD7XfIprteWaZv9nWS8rnVAryrUeS//ilzx7I59vTovPEfAAbkpgO/Pkub1 vAzOZMJHmL/FoG4YphtLxipXV+R9ADoGOl5lpBsQkfFbGznan3LiEQdmg== Subject: [libcamera-devel] [PATCH 2/3] libcamera: use const reference for range loops X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christian Rauch via libcamera-devel From: Christian Rauch Reply-To: Christian Rauch Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Signed-off-by: Christian Rauch --- src/libcamera/camera_manager.cpp | 2 +- src/libcamera/device_enumerator.cpp | 2 +- src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 5 +---- src/libcamera/pipeline/vimc/vimc.cpp | 2 +- src/libcamera/pipeline_handler.cpp | 2 +- 5 files changed, 5 insertions(+), 8 deletions(-) -- 2.34.1 diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp index 70d73822..7ff4bc6f 100644 --- a/src/libcamera/camera_manager.cpp +++ b/src/libcamera/camera_manager.cpp @@ -189,7 +189,7 @@ void CameraManager::Private::addCamera(std::shared_ptr camera, { MutexLocker locker(mutex_); - for (std::shared_ptr c : cameras_) { + for (const std::shared_ptr &c : cameras_) { if (c->id() == camera->id()) { LOG(Camera, Fatal) << "Trying to register a camera with a duplicated ID '" diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp index d1258050..f2e055de 100644 --- a/src/libcamera/device_enumerator.cpp +++ b/src/libcamera/device_enumerator.cpp @@ -161,7 +161,7 @@ std::unique_ptr DeviceEnumerator::create() DeviceEnumerator::~DeviceEnumerator() { - for (std::shared_ptr media : devices_) { + for (const std::shared_ptr &media : devices_) { if (media->busy()) LOG(DeviceEnumerator, Error) << "Removing media device " << media->deviceNode() diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp index fbe02cdc..0306f56c 100644 --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp @@ -340,10 +340,7 @@ int PipelineHandlerUVC::processControls(UVCCameraData *data, Request *request) { ControlList controls(data->video_->controls()); - for (auto it : request->controls()) { - unsigned int id = it.first; - ControlValue &value = it.second; - + for (const auto &[id, value] : request->controls()) { processControl(&controls, id, value); } diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp index 153cf849..d2f2e460 100644 --- a/src/libcamera/pipeline/vimc/vimc.cpp +++ b/src/libcamera/pipeline/vimc/vimc.cpp @@ -378,7 +378,7 @@ int PipelineHandlerVimc::processControls(VimcCameraData *data, Request *request) { ControlList controls(data->sensor_->controls()); - for (auto it : request->controls()) { + for (const auto &it : request->controls()) { unsigned int id = it.first; unsigned int offset; uint32_t cid; diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp index 7d2d00ef..e5cb751c 100644 --- a/src/libcamera/pipeline_handler.cpp +++ b/src/libcamera/pipeline_handler.cpp @@ -616,7 +616,7 @@ void PipelineHandler::disconnect() */ std::vector> cameras{ std::move(cameras_) }; - for (std::weak_ptr ptr : cameras) { + for (const std::weak_ptr &ptr : cameras) { std::shared_ptr camera = ptr.lock(); if (!camera) continue;