Patch Detail
Show a patch.
GET /api/patches/16866/?format=api
{ "id": 16866, "url": "https://patchwork.libcamera.org/api/patches/16866/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16866/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220729095625.5831-1-ecurtin@redhat.com>", "date": "2022-07-29T09:56:26", "name": "[libcamera-devel] ipa: raspberrypi: Fix compiler error, add functional include", "commit_ref": "2d2196ca0d06f25ea0a392b863310feb22a7549c", "pull_url": null, "state": "accepted", "archived": false, "hash": "52df367f2f0bc5d0184e6b919e386186d1b9003c", "submitter": { "id": 101, "url": "https://patchwork.libcamera.org/api/people/101/?format=api", "name": "Eric Curtin", "email": "ecurtin@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16866/mbox/", "series": [ { "id": 3347, "url": "https://patchwork.libcamera.org/api/series/3347/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3347", "date": "2022-07-29T09:56:26", "name": "[libcamera-devel] ipa: raspberrypi: Fix compiler error, add functional include", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3347/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16866/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16866/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E6D46C3275\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 29 Jul 2022 09:57:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3E12F63312;\n\tFri, 29 Jul 2022 11:57:45 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3415460486\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 29 Jul 2022 11:57:43 +0200 (CEST)", "from mail-wr1-f72.google.com (mail-wr1-f72.google.com\n\t[209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-160-cNU9Fn_ROimVgKkX4HMQqw-1; Fri, 29 Jul 2022 05:57:40 -0400", "by mail-wr1-f72.google.com with SMTP id\n\te14-20020adfa44e000000b0021f15a9f984so67242wra.20\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 29 Jul 2022 02:57:40 -0700 (PDT)", "from p1.. ([83.240.228.130]) by smtp.gmail.com with ESMTPSA id\n\tp4-20020a7bcc84000000b003a325bd8517sm4313958wma.5.2022.07.29.02.57.38\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 29 Jul 2022 02:57:38 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659088665;\n\tbh=aWGiJyIXiRacPamEf/+e1K0P25qHr4OVZmwEhEetZXc=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=wTGUyFqzOZwbPoPgtU0KQ/v68vp9wSnWQhadFtZe5aJeFCRap8sAXDTg9j5NMDGc0\n\tb4TMCkFf4a42V1MnqSxNiM2OQbuu9jCpKmhD7UdcBgzgig9rG0fAxHVRKrH02LXajv\n\teRROFOhthFuf79yQ7x0xfULyOC7YdujRgWHR0uRnvwZ3h0tBoNDDONrHVQhtfJ2ZP9\n\tA5yOaqvvAFoN45jodYj+auc3wIMmDlbe5H5WEuDx5xlqKttiThMO41Ekt+Zv3U9rmL\n\tjXSZuKqkVMw37/PNdonNdxThybkXPYfrvX9G7gU8kFQ3nGJpW4Cyx70gS/oZBwx1Fx\n\tgeBtcRYBZPs6g==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1659088662;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=pJzoiqNEUa+A6GgLVe5VEiujEZ3lX2Aq5HaXzwJA8LM=;\n\tb=VgQsAUeGTuUzkmCdsaU2O0ar6EIff79+FbEv5u1Wc4Bn/5nllj+iPPT9zkPenZZ/X5J4Rk\n\tCYljIK7NwlePHghezviO0ZSOiKmcF2M4VgePK43jhw7Vn+8wN3goKXsAxcp0XXxTEcGiid\n\tblv/ftAc5yD9iK3F2RVlZTFaXXdiBH4=" ], "Authentication-Results": [ "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"VgQsAUeG\"; \n\tdkim-atps=neutral", "relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ecurtin@redhat.com" ], "X-MC-Unique": "cNU9Fn_ROimVgKkX4HMQqw-1", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=pJzoiqNEUa+A6GgLVe5VEiujEZ3lX2Aq5HaXzwJA8LM=;\n\tb=5yFjGeq/BcCO3v22K0x954N4hhjKwEm6jFXRr9qXCfL/TAH57CkFgg13+1MMLohD7+\n\tuHavdSLjkYqplD1dO/FovFBBftuoz7DvtwKgyRtnmqQsVGyd/ASS1cY42T+weNXBjFbO\n\tD4esK5RXALx0dPbH7QD4K7UceHk9a8/Stj0Oa2OSjDcjCyXgYRkz/5vZEwMdseExCdVG\n\tJ9Ld2QdJ6DyKBNUfA91XVyYmPWRr3tMZotDIm1jsEAE9cOE+my9nHrOlP7tqG64dTcTw\n\tsF25RMxNGxDDWIefXRT5Gp4AV6/pTL5L4yhj2YglMy+UMgdDQ7Igx1GB728pBqzBZbTx\n\tbceQ==", "X-Gm-Message-State": "ACgBeo3unnmtW3MCSXvpqRKgBX61BsRAIQvGqJyLvKJAnFDW4Oc1gnrc\n\trTzuv22gt+cUIMRzBbQY2Dmzf4B+nBySVDm0mUeTWdgojUR6/Cf2YQJ7JCzxdbd5Nf9oxeSbUlq\n\tPZsnCEheFyd18JemaMUTfZGJlJxOBxphyNQeZdSFzeaajLbIWn0jimKvrqWj6JUuaNkatRBZ9pB\n\tys59LAvSJx", "X-Received": [ "by 2002:a5d:4ad2:0:b0:21f:af5:8dc7 with SMTP id\n\ty18-20020a5d4ad2000000b0021f0af58dc7mr1887369wrs.575.1659088659329; \n\tFri, 29 Jul 2022 02:57:39 -0700 (PDT)", "by 2002:a5d:4ad2:0:b0:21f:af5:8dc7 with SMTP id\n\ty18-20020a5d4ad2000000b0021f0af58dc7mr1887355wrs.575.1659088659033; \n\tFri, 29 Jul 2022 02:57:39 -0700 (PDT)" ], "X-Google-Smtp-Source": "AA6agR71WCfPcvpiWt9b+Q+1MRSakAD8kls5bC6FYxnPhHILSOjd0r2lCHvoulnR4wSvuPROVqCtRQ==", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 29 Jul 2022 10:56:26 +0100", "Message-Id": "<20220729095625.5831-1-ecurtin@redhat.com>", "X-Mailer": "git-send-email 2.37.1", "MIME-Version": "1.0", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] ipa: raspberrypi: Fix compiler error,\n\tadd functional include", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Eric Curtin via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Eric Curtin <ecurtin@redhat.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "gcc version '12.1.1 20220507 (Red Hat 12.1.1-1)' fails with the\nfollowing error on Fedora 36. This file should include the functional\nheader as it uses std::function.\n\nIn file included from ../src/ipa/raspberrypi/controller/rpi/ccm.h:12,\n from ../src/ipa/raspberrypi/controller/rpi/ccm.cpp:15:\n../src/ipa/raspberrypi/controller/rpi/../pwl.h:97:18: error: ‘std::function’ has not been declared\n 97 | void map(std::function<void(double x, double y)> f) const;\n\nSigned-off-by: Eric Curtin <ecurtin@redhat.com>\n---\n src/ipa/raspberrypi/controller/pwl.h | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/src/ipa/raspberrypi/controller/pwl.h b/src/ipa/raspberrypi/controller/pwl.h\nindex 546482cd..aacf6039 100644\n--- a/src/ipa/raspberrypi/controller/pwl.h\n+++ b/src/ipa/raspberrypi/controller/pwl.h\n@@ -6,6 +6,7 @@\n */\n #pragma once\n \n+#include <functional>\n #include <math.h>\n #include <vector>\n \n", "prefixes": [ "libcamera-devel" ] }