[libcamera-devel] ipa: raspberrypi: Fix compiler error, add functional include
diff mbox series

Message ID 20220729095625.5831-1-ecurtin@redhat.com
State Accepted
Commit 2d2196ca0d06f25ea0a392b863310feb22a7549c
Headers show
Series
  • [libcamera-devel] ipa: raspberrypi: Fix compiler error, add functional include
Related show

Commit Message

Eric Curtin July 29, 2022, 9:56 a.m. UTC
gcc version '12.1.1 20220507 (Red Hat 12.1.1-1)' fails with the
following error on Fedora 36. This file should include the functional
header as it uses std::function.

In file included from ../src/ipa/raspberrypi/controller/rpi/ccm.h:12,
                 from ../src/ipa/raspberrypi/controller/rpi/ccm.cpp:15:
../src/ipa/raspberrypi/controller/rpi/../pwl.h:97:18: error: ‘std::function’ has not been declared
   97 |         void map(std::function<void(double x, double y)> f) const;

Signed-off-by: Eric Curtin <ecurtin@redhat.com>
---
 src/ipa/raspberrypi/controller/pwl.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Laurent Pinchart July 29, 2022, 12:02 p.m. UTC | #1
Hi Eric,

On Fri, Jul 29, 2022 at 10:56:26AM +0100, Eric Curtin wrote:
> gcc version '12.1.1 20220507 (Red Hat 12.1.1-1)' fails with the
> following error on Fedora 36. This file should include the functional
> header as it uses std::function.
> 
> In file included from ../src/ipa/raspberrypi/controller/rpi/ccm.h:12,
>                  from ../src/ipa/raspberrypi/controller/rpi/ccm.cpp:15:
> ../src/ipa/raspberrypi/controller/rpi/../pwl.h:97:18: error: ‘std::function’ has not been declared
>    97 |         void map(std::function<void(double x, double y)> f) const;
> 
> Signed-off-by: Eric Curtin <ecurtin@redhat.com>

I've merged the previous version of the fix already, with an updated
commit message.

> ---
>  src/ipa/raspberrypi/controller/pwl.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/ipa/raspberrypi/controller/pwl.h b/src/ipa/raspberrypi/controller/pwl.h
> index 546482cd..aacf6039 100644
> --- a/src/ipa/raspberrypi/controller/pwl.h
> +++ b/src/ipa/raspberrypi/controller/pwl.h
> @@ -6,6 +6,7 @@
>   */
>  #pragma once
>  
> +#include <functional>
>  #include <math.h>
>  #include <vector>
>

Patch
diff mbox series

diff --git a/src/ipa/raspberrypi/controller/pwl.h b/src/ipa/raspberrypi/controller/pwl.h
index 546482cd..aacf6039 100644
--- a/src/ipa/raspberrypi/controller/pwl.h
+++ b/src/ipa/raspberrypi/controller/pwl.h
@@ -6,6 +6,7 @@ 
  */
 #pragma once
 
+#include <functional>
 #include <math.h>
 #include <vector>