Patch Detail
Show a patch.
GET /api/patches/16863/?format=api
{ "id": 16863, "url": "https://patchwork.libcamera.org/api/patches/16863/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16863/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220728155433.11579-1-jacopo@jmondi.org>", "date": "2022-07-28T15:54:33", "name": "[libcamera-devel] rpi: controller: awb: Include <functional>", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "3095431775bb8834b3812cfb3e412ffaa7b37263", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16863/mbox/", "series": [ { "id": 3344, "url": "https://patchwork.libcamera.org/api/series/3344/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3344", "date": "2022-07-28T15:54:33", "name": "[libcamera-devel] rpi: controller: awb: Include <functional>", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3344/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16863/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16863/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 103BDC3275\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 28 Jul 2022 15:54:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7EBA263312;\n\tThu, 28 Jul 2022 17:54:42 +0200 (CEST)", "from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B7586330D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 28 Jul 2022 17:54:41 +0200 (CEST)", "(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id DA8D2200012;\n\tThu, 28 Jul 2022 15:54:40 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659023682;\n\tbh=xnAEzzyWIlS+ip/rH0pjwC9XZBjYnYG0VW+wgCmBdfk=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=IeG4T3j/I/je32wjw0pT5tGsV+x365zituougK2sPvekRdUgl931A0oNZ4aC2Jnty\n\tT4F4QiErpp7mvu+pwAkZukQDU2glUa9WQy/ca7Mfe8TaTox8m3pDOg45N7S2T9RETh\n\tN63YPrPfP51RDwMil7YWAzXvZdUi8LxDzaf4V/7bEzC5SniXxDx5U1QIdX4Su5l7NO\n\tdSCggMQBx+UWoZZYRtQZ8JGr0LRBHKUtVu4I6zjoLALU7PrGidiZQhdBTzKfeni2Qz\n\t+YXuZU0Ys6oswtliMPkXcwvWNI2HGWviOuw75wDnMk1JcNPQaw7rgscninzYZyzf1M\n\tBE9ehR0uPBhuw==", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 28 Jul 2022 17:54:33 +0200", "Message-Id": "<20220728155433.11579-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.37.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] rpi: controller: awb: Include <functional>", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo@jmondi.org>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Building on gcc8 on Debian 10 fails with:\n\n asyncThread_ = std::thread(std::bind(&Awb::asyncFunc, this));\n../src/ipa/raspberrypi/controller/rpi/awb.cpp:177:34: note: ‘std::bind’\nis defined in header ‘<functional>’; did you forget to ‘#include\n<functional>’?\n\nFix that by including <functional> in awb.cpp.\n\nReported-by: https://buildbot.libcamera.org/#/builders/6/builds/414\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n\n---\nI diff-ed to check if std::bind() was introduced in the last great refactor,\nbut it seems to be there since 0db2c8dc75e466e7648dc1b95380495c6a126349 from\nMay 2020. Can't tell why it didn't fail so far, nor why it only fails on gcc8.\n\nBut it does anyway fix the build:\nhttps://buildbot.libcamera.org/#/builders/6/builds/421\n---\n src/ipa/raspberrypi/controller/rpi/awb.cpp | 2 ++\n 1 file changed, 2 insertions(+)\n\n--\n2.37.1", "diff": "diff --git a/src/ipa/raspberrypi/controller/rpi/awb.cpp b/src/ipa/raspberrypi/controller/rpi/awb.cpp\nindex 6c2b627d234b..94629b121eb0 100644\n--- a/src/ipa/raspberrypi/controller/rpi/awb.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n@@ -5,6 +5,8 @@\n * awb.cpp - AWB control algorithm\n */\n\n+#include <functional>\n+\n #include <libcamera/base/log.h>\n\n #include \"../lux_status.h\"\n", "prefixes": [ "libcamera-devel" ] }