From patchwork Thu Jul 28 15:54:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 16863 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 103BDC3275 for ; Thu, 28 Jul 2022 15:54:43 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7EBA263312; Thu, 28 Jul 2022 17:54:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1659023682; bh=xnAEzzyWIlS+ip/rH0pjwC9XZBjYnYG0VW+wgCmBdfk=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=IeG4T3j/I/je32wjw0pT5tGsV+x365zituougK2sPvekRdUgl931A0oNZ4aC2Jnty T4F4QiErpp7mvu+pwAkZukQDU2glUa9WQy/ca7Mfe8TaTox8m3pDOg45N7S2T9RETh N63YPrPfP51RDwMil7YWAzXvZdUi8LxDzaf4V/7bEzC5SniXxDx5U1QIdX4Su5l7NO dSCggMQBx+UWoZZYRtQZ8JGr0LRBHKUtVu4I6zjoLALU7PrGidiZQhdBTzKfeni2Qz +YXuZU0Ys6oswtliMPkXcwvWNI2HGWviOuw75wDnMk1JcNPQaw7rgscninzYZyzf1M BE9ehR0uPBhuw== Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [IPv6:2001:4b98:dc4:8::232]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B7586330D for ; Thu, 28 Jul 2022 17:54:41 +0200 (CEST) Received: (Authenticated sender: jacopo@jmondi.org) by mail.gandi.net (Postfix) with ESMTPSA id DA8D2200012; Thu, 28 Jul 2022 15:54:40 +0000 (UTC) To: libcamera-devel@lists.libcamera.org Date: Thu, 28 Jul 2022 17:54:33 +0200 Message-Id: <20220728155433.11579-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] rpi: controller: awb: Include X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jacopo Mondi via libcamera-devel From: Jacopo Mondi Reply-To: Jacopo Mondi Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Building on gcc8 on Debian 10 fails with: asyncThread_ = std::thread(std::bind(&Awb::asyncFunc, this)); ../src/ipa/raspberrypi/controller/rpi/awb.cpp:177:34: note: ‘std::bind’ is defined in header ‘’; did you forget to ‘#include ’? Fix that by including in awb.cpp. Reported-by: https://buildbot.libcamera.org/#/builders/6/builds/414 Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- I diff-ed to check if std::bind() was introduced in the last great refactor, but it seems to be there since 0db2c8dc75e466e7648dc1b95380495c6a126349 from May 2020. Can't tell why it didn't fail so far, nor why it only fails on gcc8. But it does anyway fix the build: https://buildbot.libcamera.org/#/builders/6/builds/421 --- src/ipa/raspberrypi/controller/rpi/awb.cpp | 2 ++ 1 file changed, 2 insertions(+) -- 2.37.1 diff --git a/src/ipa/raspberrypi/controller/rpi/awb.cpp b/src/ipa/raspberrypi/controller/rpi/awb.cpp index 6c2b627d234b..94629b121eb0 100644 --- a/src/ipa/raspberrypi/controller/rpi/awb.cpp +++ b/src/ipa/raspberrypi/controller/rpi/awb.cpp @@ -5,6 +5,8 @@ * awb.cpp - AWB control algorithm */ +#include + #include #include "../lux_status.h"