Patch Detail
Show a patch.
GET /api/patches/16191/?format=api
{ "id": 16191, "url": "https://patchwork.libcamera.org/api/patches/16191/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16191/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220610120338.96883-3-Rauch.Christian@gmx.de>", "date": "2022-06-10T12:03:36", "name": "[libcamera-devel,v8,2/4] libcamera: controls: Define size of array controls as a shape vector", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3b18e268fd1237c12c7964bf59403f3158744e57", "submitter": { "id": 111, "url": "https://patchwork.libcamera.org/api/people/111/?format=api", "name": "Christian Rauch", "email": "Rauch.Christian@gmx.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16191/mbox/", "series": [ { "id": 3168, "url": "https://patchwork.libcamera.org/api/series/3168/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3168", "date": "2022-06-10T12:03:34", "name": "generate and use fixed-sized Span Control types", "version": 8, "mbox": "https://patchwork.libcamera.org/series/3168/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16191/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16191/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 54F4CC326B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 10 Jun 2022 12:03:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2BE276563B;\n\tFri, 10 Jun 2022 14:03:46 +0200 (CEST)", "from mout.gmx.net (mout.gmx.net [212.227.17.20])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DBFCB65632\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 10 Jun 2022 14:03:41 +0200 (CEST)", "from localhost.localdomain ([92.18.80.244]) by mail.gmx.net\n\t(mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id\n\t1Mt79F-1nkAsO1xrF-00tTl5; Fri, 10 Jun 2022 14:03:41 +0200" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1654862626;\n\tbh=zcOLN4jTQsCp6vUKu3Yx2tGvQEPJLyoWBisxOznYHvg=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=nmC9e4PLAmJiyuniKZ2ZT8kncwiWH7ecqLjrJLF7gAkmNiZWsgiFcLam2BCufh9Da\n\tjR0lnjZvrO//bxRgmySmcL/pGJR2q7cwqwstsFfYfl6yZ276TrAbtkXgFkOFIgsGqd\n\tnhdmGNcjcRuSfOxQ+Nmcntew4qz1rqFvuEg2rkwJ2tgi594houqER+9PdsStqY/8Uf\n\tDKLLFzYqpf4B6utPg6z1ghhHx7uAz8W5sng5FPWLCcRmkTDrooFfT0cdcEoudvLsFo\n\t4SCTjXo64Bde/vfJjLKIErCWkjzBgqg4m0p9rXAJhbXlaGLtNf8MZLDsweipjfZ+0Y\n\tmHQ6zfyAQI5Vw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1654862621;\n\tbh=zcOLN4jTQsCp6vUKu3Yx2tGvQEPJLyoWBisxOznYHvg=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References;\n\tb=atWD5NvbidgeUtwzQai6saR/TvhrWHOhrm0Xf7XJFRh7HZ9gO9iklsUCyyhtAx0Mj\n\tasBIVbL+ZHrX6eUYlI6sIr05qaUe7CvlXl6ldI4+9aI5wHY+TF77EBbnjrXAiCAuLK\n\t5HzKuq3Zop/TY4NRy0Xu3aqgVmkhhr6R84srql9U=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"atWD5Nvb\"; dkim-atps=neutral", "X-UI-Sender-Class": "01bb95c1-4bf8-414a-932a-4f6e2808ef9c", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 10 Jun 2022 13:03:36 +0100", "Message-Id": "<20220610120338.96883-3-Rauch.Christian@gmx.de>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220610120338.96883-1-Rauch.Christian@gmx.de>", "References": "<20220610120338.96883-1-Rauch.Christian@gmx.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "X-Provags-ID": "V03:K1:5Q9EiJMeovbCTLOllPCNYlEJP2qYODZv5BbidjX7d6nFxlhu80c\n\t0hak95PcJuW//3kiNjpndyIs5V+4e/LIBPbSS3eSGstQvyIEyskACi2PCsrc+TwnlHxtIDH\n\txgh8lwamWvUaruoFgg3fb6KP3VZFK6GZpm96KCGr5UJpn2zI5rMn8CuYDGgH7f8X8s5kVjt\n\tV7/4PV7BsBT8VJ2BZsrXQ==", "X-Spam-Flag": "NO", "X-UI-Out-Filterresults": "notjunk:1; V03:K0:DA4uVbS0S+U=:tkrhXG9uhAPrU9sWis66Vu\n\tKoGEkoSQx7u/rCAGwlt15DNhqfW/ZnHqHyE9qLMSLW1z0wprhgYcxsC6icAHvhYbLIhGr7ob1\n\tyqN461A7S714P1/mYZ/zLpdoFfwtII44NaucZVmPWZI0kubXet9C8AkyPIEJj8EmxdVJPyJjp\n\t1E7Oj9Vu84R9wxrDvREijuBtKr/xzuahNgO+3OC6gIlaKrwcKOASG60E1ClN6EtnMelXqcJcQ\n\tWt4vqVlhgjxo+0IMARdsmhCfT901o9byjOZ9Xaqx4Yqsyor6SYIf6tX9w9dRUASD4NINQMver\n\tQXzq4BJEFhBRHEyxc9vfS46WZYcY/ReiueGpV0f6chl6DYuKeNcIDogk8WiLCuQfacEUyuvlp\n\tHVconrmYOfhKBS1LRjsmef4QoWMMXICQpqS1i7BXrDrr1clc0wRcvtuZKJ17rVD8RNOXlgZGc\n\tT4RspYtVcSxIPA7MuECXil2jjqfjwQqHkUWX4e4fO2hlwmd78KdF8szMJHSK6GpcyYedmSSK8\n\tsjimrbHvUYabpm4yfa/laCeCp7oZUZTxYM9nZS0g/nhVH+odfCu9USnbpAXAdBKSBv9FqYA6j\n\tOv/31nSPjyjyp16ZONmPH3MDt3eKnyEQRAlbI25rsALCMMuSB9gtZApQqxMADQdO3N1WiUgoC\n\tD4cal1PSZmfDk3O9j9MU5ttvVUtkU6MKiJdd+Sow+EtZZ30lhUntL2jQNxxX2JymSlMzJvYKM\n\tSJPYqcuBxrpRQJMQwuSlC5eTjQFWJ+QoFhuQQLj8nKqjrFdCYYrKUufWHP2tv/B5vwH+Mvaak\n\tImIn9di0KRJr9SzP7SHovWT3mOlQqifN48nPXR9MW/ONm4+FYpaX3zQ8virAs2t0TVdWd9W5z\n\t3PekbXEyHcNPSKQmNLpdNvIoPb0rpAcpDUbnTXu1naZ0lBx+3m1l1+HccWe/ySy+olo/5Y0Sh\n\ti521rTq+cPTuBp5rlC/8bXkjDEh6We+VNgQgPJVVjmW0VXR7zf2rJVGBktRexxqJta5K1UH0J\n\tGBeu+mztphbTeznymEwFPtiZetojPRTwyoGYjmKF8w9eis8+nUvsH2xGxIn1ejmTFi08eaDfo\n\t0UlwVaNPG3+3fmMoqBBTCCGsP27rQUYD19un1j7dDp+8gCoqF0HjKHqRQ==", "Subject": "[libcamera-devel] [PATCH v8 2/4] libcamera: controls: Define size\n\tof array controls as a shape vector", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Christian Rauch via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Christian Rauch <Rauch.Christian@gmx.de>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This follows the convention in other Tensor APIs. Since all tensors are\nrepresented as a Span with a single dimension, values provided in 'size'\nare interpreted as fixed-size Spans, while an empty array (\"[]\") will be\ninterpreted as variable-sized Span.\n\nSigned-off-by: Christian Rauch <Rauch.Christian@gmx.de>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/control_ids.yaml | 4 ++--\n src/libcamera/property_ids.yaml | 4 ++--\n 2 files changed, 4 insertions(+), 4 deletions(-)\n\n--\n2.34.1", "diff": "diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex cd1d4512..f707c1f5 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -291,7 +291,7 @@ controls:\n transformation. The 3x3 matrix is stored in conventional reading\n order in an array of 9 floating point values.\n\n- size: [3x3]\n+ size: [3,3]\n\n - ScalerCrop:\n type: Rectangle\n@@ -515,7 +515,7 @@ controls:\n the window where the focal distance for the objects shown in that part\n of the image are closest to the camera.\n\n- size: [n]\n+ size: []\n\n - AfTrigger:\n type: int32_t\ndiff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\nindex 11b7ebdc..a87485d7 100644\n--- a/src/libcamera/property_ids.yaml\n+++ b/src/libcamera/property_ids.yaml\n@@ -497,7 +497,7 @@ controls:\n\n - PixelArrayOpticalBlackRectangles:\n type: Rectangle\n- size: [n]\n+ size: []\n description: |\n The pixel array region(s) which contain optical black pixels\n considered valid for calibration purposes.\n@@ -592,7 +592,7 @@ controls:\n\n - PixelArrayActiveAreas:\n type: Rectangle\n- size: [n]\n+ size: []\n description: |\n The PixelArrayActiveAreas property defines the (possibly multiple and\n overlapping) portions of the camera sensor readable pixel matrix\n", "prefixes": [ "libcamera-devel", "v8", "2/4" ] }