From patchwork Fri Jun 10 12:03:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Rauch X-Patchwork-Id: 16191 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 54F4CC326B for ; Fri, 10 Jun 2022 12:03:48 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2BE276563B; Fri, 10 Jun 2022 14:03:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1654862626; bh=zcOLN4jTQsCp6vUKu3Yx2tGvQEPJLyoWBisxOznYHvg=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=nmC9e4PLAmJiyuniKZ2ZT8kncwiWH7ecqLjrJLF7gAkmNiZWsgiFcLam2BCufh9Da jR0lnjZvrO//bxRgmySmcL/pGJR2q7cwqwstsFfYfl6yZ276TrAbtkXgFkOFIgsGqd nhdmGNcjcRuSfOxQ+Nmcntew4qz1rqFvuEg2rkwJ2tgi594houqER+9PdsStqY/8Uf DKLLFzYqpf4B6utPg6z1ghhHx7uAz8W5sng5FPWLCcRmkTDrooFfT0cdcEoudvLsFo 4SCTjXo64Bde/vfJjLKIErCWkjzBgqg4m0p9rXAJhbXlaGLtNf8MZLDsweipjfZ+0Y mHQ6zfyAQI5Vw== Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DBFCB65632 for ; Fri, 10 Jun 2022 14:03:41 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=gmx.net header.i=@gmx.net header.b="atWD5Nvb"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1654862621; bh=zcOLN4jTQsCp6vUKu3Yx2tGvQEPJLyoWBisxOznYHvg=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=atWD5NvbidgeUtwzQai6saR/TvhrWHOhrm0Xf7XJFRh7HZ9gO9iklsUCyyhtAx0Mj asBIVbL+ZHrX6eUYlI6sIr05qaUe7CvlXl6ldI4+9aI5wHY+TF77EBbnjrXAiCAuLK 5HzKuq3Zop/TY4NRy0Xu3aqgVmkhhr6R84srql9U= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.localdomain ([92.18.80.244]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mt79F-1nkAsO1xrF-00tTl5; Fri, 10 Jun 2022 14:03:41 +0200 To: libcamera-devel@lists.libcamera.org Date: Fri, 10 Jun 2022 13:03:36 +0100 Message-Id: <20220610120338.96883-3-Rauch.Christian@gmx.de> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220610120338.96883-1-Rauch.Christian@gmx.de> References: <20220610120338.96883-1-Rauch.Christian@gmx.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:5Q9EiJMeovbCTLOllPCNYlEJP2qYODZv5BbidjX7d6nFxlhu80c 0hak95PcJuW//3kiNjpndyIs5V+4e/LIBPbSS3eSGstQvyIEyskACi2PCsrc+TwnlHxtIDH xgh8lwamWvUaruoFgg3fb6KP3VZFK6GZpm96KCGr5UJpn2zI5rMn8CuYDGgH7f8X8s5kVjt V7/4PV7BsBT8VJ2BZsrXQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:DA4uVbS0S+U=:tkrhXG9uhAPrU9sWis66Vu KoGEkoSQx7u/rCAGwlt15DNhqfW/ZnHqHyE9qLMSLW1z0wprhgYcxsC6icAHvhYbLIhGr7ob1 yqN461A7S714P1/mYZ/zLpdoFfwtII44NaucZVmPWZI0kubXet9C8AkyPIEJj8EmxdVJPyJjp 1E7Oj9Vu84R9wxrDvREijuBtKr/xzuahNgO+3OC6gIlaKrwcKOASG60E1ClN6EtnMelXqcJcQ Wt4vqVlhgjxo+0IMARdsmhCfT901o9byjOZ9Xaqx4Yqsyor6SYIf6tX9w9dRUASD4NINQMver QXzq4BJEFhBRHEyxc9vfS46WZYcY/ReiueGpV0f6chl6DYuKeNcIDogk8WiLCuQfacEUyuvlp HVconrmYOfhKBS1LRjsmef4QoWMMXICQpqS1i7BXrDrr1clc0wRcvtuZKJ17rVD8RNOXlgZGc T4RspYtVcSxIPA7MuECXil2jjqfjwQqHkUWX4e4fO2hlwmd78KdF8szMJHSK6GpcyYedmSSK8 sjimrbHvUYabpm4yfa/laCeCp7oZUZTxYM9nZS0g/nhVH+odfCu9USnbpAXAdBKSBv9FqYA6j Ov/31nSPjyjyp16ZONmPH3MDt3eKnyEQRAlbI25rsALCMMuSB9gtZApQqxMADQdO3N1WiUgoC D4cal1PSZmfDk3O9j9MU5ttvVUtkU6MKiJdd+Sow+EtZZ30lhUntL2jQNxxX2JymSlMzJvYKM SJPYqcuBxrpRQJMQwuSlC5eTjQFWJ+QoFhuQQLj8nKqjrFdCYYrKUufWHP2tv/B5vwH+Mvaak ImIn9di0KRJr9SzP7SHovWT3mOlQqifN48nPXR9MW/ONm4+FYpaX3zQ8virAs2t0TVdWd9W5z 3PekbXEyHcNPSKQmNLpdNvIoPb0rpAcpDUbnTXu1naZ0lBx+3m1l1+HccWe/ySy+olo/5Y0Sh i521rTq+cPTuBp5rlC/8bXkjDEh6We+VNgQgPJVVjmW0VXR7zf2rJVGBktRexxqJta5K1UH0J GBeu+mztphbTeznymEwFPtiZetojPRTwyoGYjmKF8w9eis8+nUvsH2xGxIn1ejmTFi08eaDfo 0UlwVaNPG3+3fmMoqBBTCCGsP27rQUYD19un1j7dDp+8gCoqF0HjKHqRQ== Subject: [libcamera-devel] [PATCH v8 2/4] libcamera: controls: Define size of array controls as a shape vector X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christian Rauch via libcamera-devel From: Christian Rauch Reply-To: Christian Rauch Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This follows the convention in other Tensor APIs. Since all tensors are represented as a Span with a single dimension, values provided in 'size' are interpreted as fixed-size Spans, while an empty array ("[]") will be interpreted as variable-sized Span. Signed-off-by: Christian Rauch Reviewed-by: Jacopo Mondi --- src/libcamera/control_ids.yaml | 4 ++-- src/libcamera/property_ids.yaml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) -- 2.34.1 diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml index cd1d4512..f707c1f5 100644 --- a/src/libcamera/control_ids.yaml +++ b/src/libcamera/control_ids.yaml @@ -291,7 +291,7 @@ controls: transformation. The 3x3 matrix is stored in conventional reading order in an array of 9 floating point values. - size: [3x3] + size: [3,3] - ScalerCrop: type: Rectangle @@ -515,7 +515,7 @@ controls: the window where the focal distance for the objects shown in that part of the image are closest to the camera. - size: [n] + size: [] - AfTrigger: type: int32_t diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml index 11b7ebdc..a87485d7 100644 --- a/src/libcamera/property_ids.yaml +++ b/src/libcamera/property_ids.yaml @@ -497,7 +497,7 @@ controls: - PixelArrayOpticalBlackRectangles: type: Rectangle - size: [n] + size: [] description: | The pixel array region(s) which contain optical black pixels considered valid for calibration purposes. @@ -592,7 +592,7 @@ controls: - PixelArrayActiveAreas: type: Rectangle - size: [n] + size: [] description: | The PixelArrayActiveAreas property defines the (possibly multiple and overlapping) portions of the camera sensor readable pixel matrix