Patch Detail
Show a patch.
GET /api/patches/16173/?format=api
{ "id": 16173, "url": "https://patchwork.libcamera.org/api/patches/16173/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16173/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220604211148.188421-4-Rauch.Christian@gmx.de>", "date": "2022-06-04T21:11:46", "name": "[libcamera-devel,v7,3/5] libcamera: controls: Define size of array controls as a shape vector", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3b18e268fd1237c12c7964bf59403f3158744e57", "submitter": { "id": 111, "url": "https://patchwork.libcamera.org/api/people/111/?format=api", "name": "Christian Rauch", "email": "Rauch.Christian@gmx.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16173/mbox/", "series": [ { "id": 3162, "url": "https://patchwork.libcamera.org/api/series/3162/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3162", "date": "2022-06-04T21:11:43", "name": "generate and use fixed-sized Span Control types", "version": 7, "mbox": "https://patchwork.libcamera.org/series/3162/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16173/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16173/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 067FDC3274\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 4 Jun 2022 21:11:57 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ACE376563A;\n\tSat, 4 Jun 2022 23:11:55 +0200 (CEST)", "from mout.gmx.net (mout.gmx.net [212.227.15.15])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6C0D4633A6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 4 Jun 2022 23:11:52 +0200 (CEST)", "from localhost.localdomain ([92.18.80.244]) by mail.gmx.net\n\t(mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id\n\t1MhlKs-1nJsWN426q-00doYN; Sat, 04 Jun 2022 23:11:52 +0200" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1654377115;\n\tbh=zcOLN4jTQsCp6vUKu3Yx2tGvQEPJLyoWBisxOznYHvg=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=b/n0gd/eBhq9felMkV9TFhj3qA+YvalCPKYei/s6HGRET5IXYIMGJvPKwnHXzYEPP\n\tEM2eNaB94mHLlN3HNfb1d1cL+VPrcNszRgSsMyOC2Ej4mTf1QBh0ORX31Yk1/7N/q7\n\tMdGkaNkurBXz3UABC976dan+V+azzODmAxWuoqO2OGQ+KllvWpM3jfSxajYa4vkq0Z\n\tWD6GDBV6mOWBgCjRCi2YRfrmaAXj3lmNf0HEmNFfc24BMK3hGBouzVmVwF7r8mfQWb\n\tGgfLUx2AFKka31/F7IHsQkKPWUabxYOdOcfRGGYTyAkvABFXkbzuSUYr5Ke7/yX2HW\n\tmwN3A25RJLsWQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1654377112;\n\tbh=zcOLN4jTQsCp6vUKu3Yx2tGvQEPJLyoWBisxOznYHvg=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References;\n\tb=a2/bd6pLv4sMOs74STD83SB8up7WDZHFLWQwNZd3gmW8C3F+9vqKSRVgo4cibLWW/\n\tpCcrlp6e9PCrHgIDrwC1QuzfNt8FHI7OVYWA9pDZC09ahcTYJni5vcKODIhS9wLSW2\n\tch02WjBKS2E4ta1kpycXG6k+jzlyxqGQp/8TIsKM=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"a2/bd6pL\"; dkim-atps=neutral", "X-UI-Sender-Class": "01bb95c1-4bf8-414a-932a-4f6e2808ef9c", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 4 Jun 2022 22:11:46 +0100", "Message-Id": "<20220604211148.188421-4-Rauch.Christian@gmx.de>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220604211148.188421-1-Rauch.Christian@gmx.de>", "References": "<20220604211148.188421-1-Rauch.Christian@gmx.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "X-Provags-ID": "V03:K1:JUjqzNEYpwJaAMoZ2BqEog188DeC+uvnuyvrhJ14zBFcXtvjWDk\n\tMF9GNI4ZS/34eqsIpnXMGXSASZtzpQzH5xxDs0/ExSXWT4ro7BP7y+3bw/KOU93f+Xv87aX\n\trE2i/kMaeOs19UlSNeie65J1n3slENJE6BWVcH+9ytMTiDnt8SBF3YGvBwp2QbhDrD+N/hi\n\tWGfbeYEmkZaOYnvkE7iJQ==", "X-Spam-Flag": "NO", "X-UI-Out-Filterresults": "notjunk:1; V03:K0:iRTLmQsnZ5I=:aHnMQRbAwoflId19bBYxcc\n\tDdtjLCs3UHlPTBaIOH+wb92JbvESxCvxiQYJl1RAnTpiRuMW0J5rWnBTEWUqRICLYWcgP3/hA\n\tnGmTmWab7WfZaAEf1twylboFpJrsghKfwgIEI29YWLqmBnI6EXXJ8HGvQk7MW9Xj2R7ws09sH\n\tJPIVugtsggFsOLObOX3rnOz8lnXdQfwankbIDazW+popLfT/IHq8Cu+dUvzBOj704Xf1QFKBI\n\t/sVHkvQ96qYkvKPYGaPjQQv9N3OlCMeenQyUr+6mB/Cf5r00AH4fbMx5+vamW3VKyFvNzcC8Z\n\tytgF1iPHlE260iz0y0jt6k/N0LOdQ4zhVaFb5USlHLD4knU7kIYn9FGFS+me6oEnT5teUuaGE\n\t3HY8dCaUSZWSe3b+Hr9XGgUkpWst92lRufVYXamMbK/vj0qI1I8bn6S8Z1IOOaT9Hv9vUX+0F\n\taU2HHoOrTcyus6rGD4o90oxB60iltzmjOrjczoy/c+Biz8IcsN7hOiQlZLLamfovxqrFXaQNw\n\tKl8DLJGBSSOkRoghI7U6GyC4xA8tSzvfvWArXuKBh6IQ1r1ao0jHFcrS3zgPH8kd3a86OMQI/\n\tlonGlQL/QM0Gh/W06qbSoI4hQxTVaSd5XeVZOrkqXZb84gJVGRl421idxqoXdC/G3RhZxudsi\n\tI3HSLvW+HEyZHXwcGXJwwLS595rOBUW6akuWkL5tgeQD0KQcxz70G9VLJkOogNagG+bVLo9Ga\n\t+qtSzJ1+Rc29WfDq03O/2RyZYsxExbyAvn+QVesV0k/KPGI6crcFbB2R4HGwAXtqv8eG0Y0wn\n\tyNfEwgunn6fyAjeQmt5QGqj8eCF8v/jbZwXJV99NPz0xkGgaKnjZKZclbIB8kBDvriLymN7jm\n\t3Ntr5UfzQsjbgsZhT4oyawz/w7FDQBxE/NaopDFIopVMMQPXnGXpFofiG7/HjHOrFWQ4a9jTH\n\tu8eKT7MZXqIX2s2f7hZQejmajt4BgKbVMtBlv76ptSXZ8u7eXEzv7lBOWtxP/+yT+egXSZvj7\n\tFn43/b4tIRpDWKI5x5YKQqJR1WSqTzpaflSjPXCmLrZIbVm/Qio4XzB+Lp6vW2KYZHFd8yQyt\n\tRbLo+TDSAxbj2KoQMrH9ckNEpS52w0QVPUcw/Ob7TS6QDG6dvO8Ej0ePg==", "Subject": "[libcamera-devel] [PATCH v7 3/5] libcamera: controls: Define size\n\tof array controls as a shape vector", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Christian Rauch via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Christian Rauch <Rauch.Christian@gmx.de>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This follows the convention in other Tensor APIs. Since all tensors are\nrepresented as a Span with a single dimension, values provided in 'size'\nare interpreted as fixed-size Spans, while an empty array (\"[]\") will be\ninterpreted as variable-sized Span.\n\nSigned-off-by: Christian Rauch <Rauch.Christian@gmx.de>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/control_ids.yaml | 4 ++--\n src/libcamera/property_ids.yaml | 4 ++--\n 2 files changed, 4 insertions(+), 4 deletions(-)\n\n--\n2.34.1", "diff": "diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex cd1d4512..f707c1f5 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -291,7 +291,7 @@ controls:\n transformation. The 3x3 matrix is stored in conventional reading\n order in an array of 9 floating point values.\n\n- size: [3x3]\n+ size: [3,3]\n\n - ScalerCrop:\n type: Rectangle\n@@ -515,7 +515,7 @@ controls:\n the window where the focal distance for the objects shown in that part\n of the image are closest to the camera.\n\n- size: [n]\n+ size: []\n\n - AfTrigger:\n type: int32_t\ndiff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\nindex 11b7ebdc..a87485d7 100644\n--- a/src/libcamera/property_ids.yaml\n+++ b/src/libcamera/property_ids.yaml\n@@ -497,7 +497,7 @@ controls:\n\n - PixelArrayOpticalBlackRectangles:\n type: Rectangle\n- size: [n]\n+ size: []\n description: |\n The pixel array region(s) which contain optical black pixels\n considered valid for calibration purposes.\n@@ -592,7 +592,7 @@ controls:\n\n - PixelArrayActiveAreas:\n type: Rectangle\n- size: [n]\n+ size: []\n description: |\n The PixelArrayActiveAreas property defines the (possibly multiple and\n overlapping) portions of the camera sensor readable pixel matrix\n", "prefixes": [ "libcamera-devel", "v7", "3/5" ] }