From patchwork Sat Jun 4 21:11:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Rauch X-Patchwork-Id: 16173 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 067FDC3274 for ; Sat, 4 Jun 2022 21:11:57 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id ACE376563A; Sat, 4 Jun 2022 23:11:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1654377115; bh=zcOLN4jTQsCp6vUKu3Yx2tGvQEPJLyoWBisxOznYHvg=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=b/n0gd/eBhq9felMkV9TFhj3qA+YvalCPKYei/s6HGRET5IXYIMGJvPKwnHXzYEPP EM2eNaB94mHLlN3HNfb1d1cL+VPrcNszRgSsMyOC2Ej4mTf1QBh0ORX31Yk1/7N/q7 MdGkaNkurBXz3UABC976dan+V+azzODmAxWuoqO2OGQ+KllvWpM3jfSxajYa4vkq0Z WD6GDBV6mOWBgCjRCi2YRfrmaAXj3lmNf0HEmNFfc24BMK3hGBouzVmVwF7r8mfQWb GgfLUx2AFKka31/F7IHsQkKPWUabxYOdOcfRGGYTyAkvABFXkbzuSUYr5Ke7/yX2HW mwN3A25RJLsWQ== Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6C0D4633A6 for ; Sat, 4 Jun 2022 23:11:52 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=gmx.net header.i=@gmx.net header.b="a2/bd6pL"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1654377112; bh=zcOLN4jTQsCp6vUKu3Yx2tGvQEPJLyoWBisxOznYHvg=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=a2/bd6pLv4sMOs74STD83SB8up7WDZHFLWQwNZd3gmW8C3F+9vqKSRVgo4cibLWW/ pCcrlp6e9PCrHgIDrwC1QuzfNt8FHI7OVYWA9pDZC09ahcTYJni5vcKODIhS9wLSW2 ch02WjBKS2E4ta1kpycXG6k+jzlyxqGQp/8TIsKM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.localdomain ([92.18.80.244]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MhlKs-1nJsWN426q-00doYN; Sat, 04 Jun 2022 23:11:52 +0200 To: libcamera-devel@lists.libcamera.org Date: Sat, 4 Jun 2022 22:11:46 +0100 Message-Id: <20220604211148.188421-4-Rauch.Christian@gmx.de> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220604211148.188421-1-Rauch.Christian@gmx.de> References: <20220604211148.188421-1-Rauch.Christian@gmx.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:JUjqzNEYpwJaAMoZ2BqEog188DeC+uvnuyvrhJ14zBFcXtvjWDk MF9GNI4ZS/34eqsIpnXMGXSASZtzpQzH5xxDs0/ExSXWT4ro7BP7y+3bw/KOU93f+Xv87aX rE2i/kMaeOs19UlSNeie65J1n3slENJE6BWVcH+9ytMTiDnt8SBF3YGvBwp2QbhDrD+N/hi WGfbeYEmkZaOYnvkE7iJQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:iRTLmQsnZ5I=:aHnMQRbAwoflId19bBYxcc DdtjLCs3UHlPTBaIOH+wb92JbvESxCvxiQYJl1RAnTpiRuMW0J5rWnBTEWUqRICLYWcgP3/hA nGmTmWab7WfZaAEf1twylboFpJrsghKfwgIEI29YWLqmBnI6EXXJ8HGvQk7MW9Xj2R7ws09sH JPIVugtsggFsOLObOX3rnOz8lnXdQfwankbIDazW+popLfT/IHq8Cu+dUvzBOj704Xf1QFKBI /sVHkvQ96qYkvKPYGaPjQQv9N3OlCMeenQyUr+6mB/Cf5r00AH4fbMx5+vamW3VKyFvNzcC8Z ytgF1iPHlE260iz0y0jt6k/N0LOdQ4zhVaFb5USlHLD4knU7kIYn9FGFS+me6oEnT5teUuaGE 3HY8dCaUSZWSe3b+Hr9XGgUkpWst92lRufVYXamMbK/vj0qI1I8bn6S8Z1IOOaT9Hv9vUX+0F aU2HHoOrTcyus6rGD4o90oxB60iltzmjOrjczoy/c+Biz8IcsN7hOiQlZLLamfovxqrFXaQNw Kl8DLJGBSSOkRoghI7U6GyC4xA8tSzvfvWArXuKBh6IQ1r1ao0jHFcrS3zgPH8kd3a86OMQI/ lonGlQL/QM0Gh/W06qbSoI4hQxTVaSd5XeVZOrkqXZb84gJVGRl421idxqoXdC/G3RhZxudsi I3HSLvW+HEyZHXwcGXJwwLS595rOBUW6akuWkL5tgeQD0KQcxz70G9VLJkOogNagG+bVLo9Ga +qtSzJ1+Rc29WfDq03O/2RyZYsxExbyAvn+QVesV0k/KPGI6crcFbB2R4HGwAXtqv8eG0Y0wn yNfEwgunn6fyAjeQmt5QGqj8eCF8v/jbZwXJV99NPz0xkGgaKnjZKZclbIB8kBDvriLymN7jm 3Ntr5UfzQsjbgsZhT4oyawz/w7FDQBxE/NaopDFIopVMMQPXnGXpFofiG7/HjHOrFWQ4a9jTH u8eKT7MZXqIX2s2f7hZQejmajt4BgKbVMtBlv76ptSXZ8u7eXEzv7lBOWtxP/+yT+egXSZvj7 Fn43/b4tIRpDWKI5x5YKQqJR1WSqTzpaflSjPXCmLrZIbVm/Qio4XzB+Lp6vW2KYZHFd8yQyt RbLo+TDSAxbj2KoQMrH9ckNEpS52w0QVPUcw/Ob7TS6QDG6dvO8Ej0ePg== Subject: [libcamera-devel] [PATCH v7 3/5] libcamera: controls: Define size of array controls as a shape vector X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christian Rauch via libcamera-devel From: Christian Rauch Reply-To: Christian Rauch Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This follows the convention in other Tensor APIs. Since all tensors are represented as a Span with a single dimension, values provided in 'size' are interpreted as fixed-size Spans, while an empty array ("[]") will be interpreted as variable-sized Span. Signed-off-by: Christian Rauch Reviewed-by: Jacopo Mondi --- src/libcamera/control_ids.yaml | 4 ++-- src/libcamera/property_ids.yaml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) -- 2.34.1 diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml index cd1d4512..f707c1f5 100644 --- a/src/libcamera/control_ids.yaml +++ b/src/libcamera/control_ids.yaml @@ -291,7 +291,7 @@ controls: transformation. The 3x3 matrix is stored in conventional reading order in an array of 9 floating point values. - size: [3x3] + size: [3,3] - ScalerCrop: type: Rectangle @@ -515,7 +515,7 @@ controls: the window where the focal distance for the objects shown in that part of the image are closest to the camera. - size: [n] + size: [] - AfTrigger: type: int32_t diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml index 11b7ebdc..a87485d7 100644 --- a/src/libcamera/property_ids.yaml +++ b/src/libcamera/property_ids.yaml @@ -497,7 +497,7 @@ controls: - PixelArrayOpticalBlackRectangles: type: Rectangle - size: [n] + size: [] description: | The pixel array region(s) which contain optical black pixels considered valid for calibration purposes. @@ -592,7 +592,7 @@ controls: - PixelArrayActiveAreas: type: Rectangle - size: [n] + size: [] description: | The PixelArrayActiveAreas property defines the (possibly multiple and overlapping) portions of the camera sensor readable pixel matrix