Patch Detail
Show a patch.
GET /api/patches/16128/?format=api
{ "id": 16128, "url": "https://patchwork.libcamera.org/api/patches/16128/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16128/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220601231802.16735-3-Rauch.Christian@gmx.de>", "date": "2022-06-01T23:18:00", "name": "[libcamera-devel,v5,2/4] libcamera: controls: Define size of array controls as a shape vector", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3b18e268fd1237c12c7964bf59403f3158744e57", "submitter": { "id": 111, "url": "https://patchwork.libcamera.org/api/people/111/?format=api", "name": "Christian Rauch", "email": "Rauch.Christian@gmx.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16128/mbox/", "series": [ { "id": 3152, "url": "https://patchwork.libcamera.org/api/series/3152/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3152", "date": "2022-06-01T23:17:58", "name": "generate and use fixed-sized Span Control types", "version": 5, "mbox": "https://patchwork.libcamera.org/series/3152/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16128/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16128/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 232D9C326D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 1 Jun 2022 23:18:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6D16C65640;\n\tThu, 2 Jun 2022 01:18:19 +0200 (CEST)", "from mout.gmx.net (mout.gmx.net [212.227.17.20])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 187A66559A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 2 Jun 2022 01:18:16 +0200 (CEST)", "from localhost.localdomain ([92.18.80.244]) by mail.gmx.net\n\t(mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id\n\t1MoO6C-1nTlHj2Bq4-00okjI; Thu, 02 Jun 2022 01:18:15 +0200" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1654125499;\n\tbh=zcOLN4jTQsCp6vUKu3Yx2tGvQEPJLyoWBisxOznYHvg=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=iSy+lAF9VzIfrIRYBHNcmNhIHA4Rv/AwzETtFfSQTGLP6Y4URD9ABI64DbIurK2O7\n\tSh+93v9sRiWmuZRIW9aKB/Zto5sXDTpqIxdzg9SfXQe9OfaOw6Xmv2lkvsvF+nFFlo\n\tnvb5CuQq62+NwXjlBcvmzsBcEkK+Ysd3T2QIj0LiD71nZ7Qsvkd24tIxXT5YGbsJ9J\n\tdUk77jvrJj2CIDP9oNVEElQx2Yi8hJ47Tt0f4ojlEaXvXyEJdcZ0Pz71UFi6Ad5ETL\n\tCtVx/YAC7/tF+4w5/v9ZKncpcN3gQvVW+W+CCRoav5JJPikkHxh8JeBvBa+AsW/Ohr\n\tezf4p8mYB2srw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1654125495;\n\tbh=zcOLN4jTQsCp6vUKu3Yx2tGvQEPJLyoWBisxOznYHvg=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References;\n\tb=YLxOH5fDz4Z10FPYiv8W2vDTwMvvLFLx7GbuD+GsjMGkx3bBiPRtS4g1NzhNO163y\n\tMEFNaWjXtBLuqh7BVv310AHlqKjh9kR7j5EE5pmMRvpDBmLuV7tBQnzPUDVDBC9fal\n\tytzG3j1Qbr3J3768yEYymn/t+/3o6XtOtQ4iDRmM=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"YLxOH5fD\"; dkim-atps=neutral", "X-UI-Sender-Class": "01bb95c1-4bf8-414a-932a-4f6e2808ef9c", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 2 Jun 2022 00:18:00 +0100", "Message-Id": "<20220601231802.16735-3-Rauch.Christian@gmx.de>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220601231802.16735-1-Rauch.Christian@gmx.de>", "References": "<20220601231802.16735-1-Rauch.Christian@gmx.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "X-Provags-ID": "V03:K1:s2PcrFHzj+/gVUnAfhiHzzN9LtlpsroVzFKbRGY0oGxyovhBtNj\n\troD7rn6nB0qxN+Xfh803XRLDFSc64Up8Q0PIrLTsrBdO+NN4IBfqRs5ZiToT4Oo6wjEb7e4\n\t8mSSiZg8qhkj/9D+RG41+u5VL4545Ftcs4fFpk22wrHvlpRB9CMOwsNyDZuz6LyHkHVea+q\n\t+ccOf64mFQ0DbGdj2U3EA==", "X-Spam-Flag": "NO", "X-UI-Out-Filterresults": "notjunk:1; V03:K0:j45yyDPePNw=:qtF+7REW1ZXl8ai9DMyMrI\n\t/4ydVDLj0E9a8iorIsA7a3LmGTGOud9Q0ZOphxdHfu4cz/4W9cnDH6jNK3BmDWu1eak4pXQMt\n\tLH2NcYx/RN2WHxMwlnD6InAS6ycKji0hOoJM9dgqUagduEaev2F78iz5XtzzX27ACfR+1SEEY\n\tk6l4Qt+dZWHptsnbniU9CB9Ha07rYVA/dPj6tLzNYPJ8zNM9SXzBjBgZjeCM5YTALsty7XS9U\n\tUJfWlK+TmHegLFR6Mt5hU2AhaVEzQ1lpLWz+jFvWu2h+WdkwVJQcsn6B+/VOIZwSYP/sl0FTv\n\tGJiN71JCUYxOvYiqrF6CzLdoF3YagwHDorAaaxZQF4yUqn47GFKqZrpnKZBqK6JTza1EL0dFN\n\tbF4PO86WY/wwuNN6nq77riJfk6RVq2L01wXFrvcGQs1m4rJLkoMJ4yJrsDX/JQgwnfVwukhn3\n\tho7bJauZLP35hSs7SDgjVPeawyqciSWYg/2U/bRfm4MC9vi8iwUS+5WmaBWpJpTP6ow4n6oOh\n\tdEQpR3mNVvpT0hbnl/RYqwo8sgFAd1VmEGZOArpSFObK09ss+etzDmjOiEjjldhdunpds6VY9\n\tMwdwCu3gEkDN1ezk2zTB6118j1/fbkVd/xJWenNqGoUT/pReNtnBdUOxB8jjmkKFcjr9byebp\n\tOCv5m46D6GR6wPsgmwWZeYAAxVBnUkGapZ5Ia0aSoQTQOWnqfbtp2LNcQzEL/N5PGIMfOUtpK\n\tt8CPqyC5hnYvBpS3qIfsLkYPgi8xdEjUKxGmjccrBPGaHB6RhAezbX8McOL8ioU1dYIchQ7hc\n\t7UnRJTJG54aSASIYEZs05p1O+ey50z3hudZDVgjdzpeIZnyia46nFhLTi/8EgTuj9sIyZRKFZ\n\tLy6TNXBOu2jYzlRuhtHJiTxHyvyElDmSVZk2MWdEUVoZBYVzI0/ogM4ATzIjTIDKGlzyqNE+A\n\tBG68v/Dpb+YEXOWq2RDZ9wSbPaM6tlQ0/AMPgGBQbYEZtUfP3zg0yL5aHJgymSkGF9maEctIB\n\tUFx4JNMSi3/oK9O54OKEWmr4dnDI/454SAoekXjZCslvW1+TGd5AKfXpNbMdQilsxhtMIvO3F\n\t0xxIZyg0kdXk0t3eIAZz/DcNt+mUtAgdKflBChRUMGvFEgmzrSsiaI0qw==", "Subject": "[libcamera-devel] [PATCH v5 2/4] libcamera: controls: Define size\n\tof array controls as a shape vector", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Christian Rauch via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Christian Rauch <Rauch.Christian@gmx.de>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This follows the convention in other Tensor APIs. Since all tensors are\nrepresented as a Span with a single dimension, values provided in 'size'\nare interpreted as fixed-size Spans, while an empty array (\"[]\") will be\ninterpreted as variable-sized Span.\n\nSigned-off-by: Christian Rauch <Rauch.Christian@gmx.de>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/control_ids.yaml | 4 ++--\n src/libcamera/property_ids.yaml | 4 ++--\n 2 files changed, 4 insertions(+), 4 deletions(-)\n\n--\n2.34.1", "diff": "diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex cd1d4512..f707c1f5 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -291,7 +291,7 @@ controls:\n transformation. The 3x3 matrix is stored in conventional reading\n order in an array of 9 floating point values.\n\n- size: [3x3]\n+ size: [3,3]\n\n - ScalerCrop:\n type: Rectangle\n@@ -515,7 +515,7 @@ controls:\n the window where the focal distance for the objects shown in that part\n of the image are closest to the camera.\n\n- size: [n]\n+ size: []\n\n - AfTrigger:\n type: int32_t\ndiff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\nindex 11b7ebdc..a87485d7 100644\n--- a/src/libcamera/property_ids.yaml\n+++ b/src/libcamera/property_ids.yaml\n@@ -497,7 +497,7 @@ controls:\n\n - PixelArrayOpticalBlackRectangles:\n type: Rectangle\n- size: [n]\n+ size: []\n description: |\n The pixel array region(s) which contain optical black pixels\n considered valid for calibration purposes.\n@@ -592,7 +592,7 @@ controls:\n\n - PixelArrayActiveAreas:\n type: Rectangle\n- size: [n]\n+ size: []\n description: |\n The PixelArrayActiveAreas property defines the (possibly multiple and\n overlapping) portions of the camera sensor readable pixel matrix\n", "prefixes": [ "libcamera-devel", "v5", "2/4" ] }