From patchwork Wed Jun 1 23:18:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Rauch X-Patchwork-Id: 16128 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 232D9C326D for ; Wed, 1 Jun 2022 23:18:21 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6D16C65640; Thu, 2 Jun 2022 01:18:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1654125499; bh=zcOLN4jTQsCp6vUKu3Yx2tGvQEPJLyoWBisxOznYHvg=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=iSy+lAF9VzIfrIRYBHNcmNhIHA4Rv/AwzETtFfSQTGLP6Y4URD9ABI64DbIurK2O7 Sh+93v9sRiWmuZRIW9aKB/Zto5sXDTpqIxdzg9SfXQe9OfaOw6Xmv2lkvsvF+nFFlo nvb5CuQq62+NwXjlBcvmzsBcEkK+Ysd3T2QIj0LiD71nZ7Qsvkd24tIxXT5YGbsJ9J dUk77jvrJj2CIDP9oNVEElQx2Yi8hJ47Tt0f4ojlEaXvXyEJdcZ0Pz71UFi6Ad5ETL CtVx/YAC7/tF+4w5/v9ZKncpcN3gQvVW+W+CCRoav5JJPikkHxh8JeBvBa+AsW/Ohr ezf4p8mYB2srw== Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 187A66559A for ; Thu, 2 Jun 2022 01:18:16 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=gmx.net header.i=@gmx.net header.b="YLxOH5fD"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1654125495; bh=zcOLN4jTQsCp6vUKu3Yx2tGvQEPJLyoWBisxOznYHvg=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=YLxOH5fDz4Z10FPYiv8W2vDTwMvvLFLx7GbuD+GsjMGkx3bBiPRtS4g1NzhNO163y MEFNaWjXtBLuqh7BVv310AHlqKjh9kR7j5EE5pmMRvpDBmLuV7tBQnzPUDVDBC9fal ytzG3j1Qbr3J3768yEYymn/t+/3o6XtOtQ4iDRmM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.localdomain ([92.18.80.244]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MoO6C-1nTlHj2Bq4-00okjI; Thu, 02 Jun 2022 01:18:15 +0200 To: libcamera-devel@lists.libcamera.org Date: Thu, 2 Jun 2022 00:18:00 +0100 Message-Id: <20220601231802.16735-3-Rauch.Christian@gmx.de> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220601231802.16735-1-Rauch.Christian@gmx.de> References: <20220601231802.16735-1-Rauch.Christian@gmx.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:s2PcrFHzj+/gVUnAfhiHzzN9LtlpsroVzFKbRGY0oGxyovhBtNj roD7rn6nB0qxN+Xfh803XRLDFSc64Up8Q0PIrLTsrBdO+NN4IBfqRs5ZiToT4Oo6wjEb7e4 8mSSiZg8qhkj/9D+RG41+u5VL4545Ftcs4fFpk22wrHvlpRB9CMOwsNyDZuz6LyHkHVea+q +ccOf64mFQ0DbGdj2U3EA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:j45yyDPePNw=:qtF+7REW1ZXl8ai9DMyMrI /4ydVDLj0E9a8iorIsA7a3LmGTGOud9Q0ZOphxdHfu4cz/4W9cnDH6jNK3BmDWu1eak4pXQMt LH2NcYx/RN2WHxMwlnD6InAS6ycKji0hOoJM9dgqUagduEaev2F78iz5XtzzX27ACfR+1SEEY k6l4Qt+dZWHptsnbniU9CB9Ha07rYVA/dPj6tLzNYPJ8zNM9SXzBjBgZjeCM5YTALsty7XS9U UJfWlK+TmHegLFR6Mt5hU2AhaVEzQ1lpLWz+jFvWu2h+WdkwVJQcsn6B+/VOIZwSYP/sl0FTv GJiN71JCUYxOvYiqrF6CzLdoF3YagwHDorAaaxZQF4yUqn47GFKqZrpnKZBqK6JTza1EL0dFN bF4PO86WY/wwuNN6nq77riJfk6RVq2L01wXFrvcGQs1m4rJLkoMJ4yJrsDX/JQgwnfVwukhn3 ho7bJauZLP35hSs7SDgjVPeawyqciSWYg/2U/bRfm4MC9vi8iwUS+5WmaBWpJpTP6ow4n6oOh dEQpR3mNVvpT0hbnl/RYqwo8sgFAd1VmEGZOArpSFObK09ss+etzDmjOiEjjldhdunpds6VY9 MwdwCu3gEkDN1ezk2zTB6118j1/fbkVd/xJWenNqGoUT/pReNtnBdUOxB8jjmkKFcjr9byebp OCv5m46D6GR6wPsgmwWZeYAAxVBnUkGapZ5Ia0aSoQTQOWnqfbtp2LNcQzEL/N5PGIMfOUtpK t8CPqyC5hnYvBpS3qIfsLkYPgi8xdEjUKxGmjccrBPGaHB6RhAezbX8McOL8ioU1dYIchQ7hc 7UnRJTJG54aSASIYEZs05p1O+ey50z3hudZDVgjdzpeIZnyia46nFhLTi/8EgTuj9sIyZRKFZ Ly6TNXBOu2jYzlRuhtHJiTxHyvyElDmSVZk2MWdEUVoZBYVzI0/ogM4ATzIjTIDKGlzyqNE+A BG68v/Dpb+YEXOWq2RDZ9wSbPaM6tlQ0/AMPgGBQbYEZtUfP3zg0yL5aHJgymSkGF9maEctIB UFx4JNMSi3/oK9O54OKEWmr4dnDI/454SAoekXjZCslvW1+TGd5AKfXpNbMdQilsxhtMIvO3F 0xxIZyg0kdXk0t3eIAZz/DcNt+mUtAgdKflBChRUMGvFEgmzrSsiaI0qw== Subject: [libcamera-devel] [PATCH v5 2/4] libcamera: controls: Define size of array controls as a shape vector X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christian Rauch via libcamera-devel From: Christian Rauch Reply-To: Christian Rauch Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This follows the convention in other Tensor APIs. Since all tensors are represented as a Span with a single dimension, values provided in 'size' are interpreted as fixed-size Spans, while an empty array ("[]") will be interpreted as variable-sized Span. Signed-off-by: Christian Rauch Reviewed-by: Jacopo Mondi --- src/libcamera/control_ids.yaml | 4 ++-- src/libcamera/property_ids.yaml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) -- 2.34.1 diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml index cd1d4512..f707c1f5 100644 --- a/src/libcamera/control_ids.yaml +++ b/src/libcamera/control_ids.yaml @@ -291,7 +291,7 @@ controls: transformation. The 3x3 matrix is stored in conventional reading order in an array of 9 floating point values. - size: [3x3] + size: [3,3] - ScalerCrop: type: Rectangle @@ -515,7 +515,7 @@ controls: the window where the focal distance for the objects shown in that part of the image are closest to the camera. - size: [n] + size: [] - AfTrigger: type: int32_t diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml index 11b7ebdc..a87485d7 100644 --- a/src/libcamera/property_ids.yaml +++ b/src/libcamera/property_ids.yaml @@ -497,7 +497,7 @@ controls: - PixelArrayOpticalBlackRectangles: type: Rectangle - size: [n] + size: [] description: | The pixel array region(s) which contain optical black pixels considered valid for calibration purposes. @@ -592,7 +592,7 @@ controls: - PixelArrayActiveAreas: type: Rectangle - size: [n] + size: [] description: | The PixelArrayActiveAreas property defines the (possibly multiple and overlapping) portions of the camera sensor readable pixel matrix