Patch Detail
Show a patch.
GET /api/patches/15774/?format=api
{ "id": 15774, "url": "https://patchwork.libcamera.org/api/patches/15774/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15774/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220504132154.9681-2-laurent.pinchart@ideasonboard.com>", "date": "2022-05-04T13:21:50", "name": "[libcamera-devel,1/5] libcamera: pipeline: simple: Improve debug message on config failure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7e7ec6b11199c08936a42e88031fe3a2adb2f6c8", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15774/mbox/", "series": [ { "id": 3090, "url": "https://patchwork.libcamera.org/api/series/3090/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3090", "date": "2022-05-04T13:21:49", "name": "libcamera: pipeline: simple: Support scaling on the camea sensor", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3090/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15774/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15774/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BA089C3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 4 May 2022 13:22:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 58A146564E;\n\tWed, 4 May 2022 15:22:02 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EF4AE65642\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 4 May 2022 15:21:59 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 99B0E835\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 4 May 2022 15:21:59 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651670522;\n\tbh=4xMOvcIug09O0pUCF151klKaOcYTIo+3JA46GmbdTTg=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=gXK4pgAmLhou3P5/WqMd0MK0+AZ3rhwV2vTWpiB3hVQbp3DCTCD6Jvrr0cN/DTUMG\n\tjDTUrM/DXZDz3DxT3SNJdA/jSWg8Gd2s+Ut2aGYYO4MG98Kf/J1BDnQMS1h5kvgsWy\n\tiN08Tfns1yP5jd6K09SE+6rXiX9u7HDtLTtDInfMV0AhcKgy5JgpMtBR1pRCoGJtXS\n\tQTQObeEGpv/LNsMrZgeFHFLruYTgT4vktL0x2G7j8T8U/5kOnBvO7EsK7dYa8KXHCb\n\tqyN7u/QkdBnxvy2tl8/krex2qTqDPhGiP7QCK+nQQL26iFyiTRxPhKwQQyKpQt/Hzu\n\t48OBW4OQg4jPQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1651670519;\n\tbh=4xMOvcIug09O0pUCF151klKaOcYTIo+3JA46GmbdTTg=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=R4fErgmwcZT6b6IZTLk010qePCASATh8T9XP26OUWXupy7djYTrR5DfNefGU3/yef\n\tEqS5ZlVLXxlQasnm7rTBvXTFXN2gDD/KXT5CnQWhZbLgQwKiyLxJXSrkkxAUbyo/JJ\n\tlNj+DeR/aNSfSD5rgiZWBG2CLNJndlYaSdWJs6Fo=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"R4fErgmw\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 4 May 2022 16:21:50 +0300", "Message-Id": "<20220504132154.9681-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220504132154.9681-1-laurent.pinchart@ideasonboard.com>", "References": "<20220504132154.9681-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/5] libcamera: pipeline: simple: Improve\n\tdebug message on config failure", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When pipeline configuration fails, print the format returned by the\nkernel in addition to the one requested by libcamera, to ease debugging.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 76bd228b5aba..22efc8f498dc 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -939,7 +939,8 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \t captureFormat.size != pipeConfig->captureSize) {\n \t\tLOG(SimplePipeline, Error)\n \t\t\t<< \"Unable to configure capture in \"\n-\t\t\t<< pipeConfig->captureSize << \"-\" << videoFormat;\n+\t\t\t<< pipeConfig->captureSize << \"-\" << videoFormat\n+\t\t\t<< \" (got \" << captureFormat << \")\";\n \t\treturn -EINVAL;\n \t}\n \n", "prefixes": [ "libcamera-devel", "1/5" ] }