From patchwork Wed May 4 13:21:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 15774 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BA089C3256 for ; Wed, 4 May 2022 13:22:04 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 58A146564E; Wed, 4 May 2022 15:22:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1651670522; bh=4xMOvcIug09O0pUCF151klKaOcYTIo+3JA46GmbdTTg=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=gXK4pgAmLhou3P5/WqMd0MK0+AZ3rhwV2vTWpiB3hVQbp3DCTCD6Jvrr0cN/DTUMG jDTUrM/DXZDz3DxT3SNJdA/jSWg8Gd2s+Ut2aGYYO4MG98Kf/J1BDnQMS1h5kvgsWy iN08Tfns1yP5jd6K09SE+6rXiX9u7HDtLTtDInfMV0AhcKgy5JgpMtBR1pRCoGJtXS QTQObeEGpv/LNsMrZgeFHFLruYTgT4vktL0x2G7j8T8U/5kOnBvO7EsK7dYa8KXHCb qyN7u/QkdBnxvy2tl8/krex2qTqDPhGiP7QCK+nQQL26iFyiTRxPhKwQQyKpQt/Hzu 48OBW4OQg4jPQ== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id EF4AE65642 for ; Wed, 4 May 2022 15:21:59 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="R4fErgmw"; dkim-atps=neutral Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 99B0E835 for ; Wed, 4 May 2022 15:21:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1651670519; bh=4xMOvcIug09O0pUCF151klKaOcYTIo+3JA46GmbdTTg=; h=From:To:Subject:Date:In-Reply-To:References:From; b=R4fErgmwcZT6b6IZTLk010qePCASATh8T9XP26OUWXupy7djYTrR5DfNefGU3/yef EqS5ZlVLXxlQasnm7rTBvXTFXN2gDD/KXT5CnQWhZbLgQwKiyLxJXSrkkxAUbyo/JJ lNj+DeR/aNSfSD5rgiZWBG2CLNJndlYaSdWJs6Fo= To: libcamera-devel@lists.libcamera.org Date: Wed, 4 May 2022 16:21:50 +0300 Message-Id: <20220504132154.9681-2-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220504132154.9681-1-laurent.pinchart@ideasonboard.com> References: <20220504132154.9681-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/5] libcamera: pipeline: simple: Improve debug message on config failure X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" When pipeline configuration fails, print the format returned by the kernel in addition to the one requested by libcamera, to ease debugging. Signed-off-by: Laurent Pinchart --- src/libcamera/pipeline/simple/simple.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp index 76bd228b5aba..22efc8f498dc 100644 --- a/src/libcamera/pipeline/simple/simple.cpp +++ b/src/libcamera/pipeline/simple/simple.cpp @@ -939,7 +939,8 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c) captureFormat.size != pipeConfig->captureSize) { LOG(SimplePipeline, Error) << "Unable to configure capture in " - << pipeConfig->captureSize << "-" << videoFormat; + << pipeConfig->captureSize << "-" << videoFormat + << " (got " << captureFormat << ")"; return -EINVAL; }